Title: [97847] trunk/Source/WebCore
Revision
97847
Author
[email protected]
Date
2011-10-19 04:29:27 -0700 (Wed, 19 Oct 2011)

Log Message

Web Inspector: Console messages for XHR logging should show call stack if available.
https://bugs.webkit.org/show_bug.cgi?id=70324

Reviewed by Pavel Feldman.

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (97846 => 97847)


--- trunk/Source/WebCore/ChangeLog	2011-10-19 11:18:01 UTC (rev 97846)
+++ trunk/Source/WebCore/ChangeLog	2011-10-19 11:29:27 UTC (rev 97847)
@@ -1,3 +1,13 @@
+2011-10-19  Vsevolod Vlasov  <[email protected]>
+
+        Web Inspector: Console messages for XHR logging should show call stack if available.
+        https://bugs.webkit.org/show_bug.cgi?id=70324
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/ConsoleMessage.js:
+        (WebInspector.ConsoleMessageImpl.prototype._formatMessage):
+
 2011-10-13  Pavel Podivilov  <[email protected]>
 
         Web Inspector: move JS specific popover handling to _javascript_SourceFrame.

Modified: trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js (97846 => 97847)


--- trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js	2011-10-19 11:18:01 UTC (rev 97846)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js	2011-10-19 11:29:27 UTC (rev 97847)
@@ -99,8 +99,8 @@
             }
         } else if (this.source === WebInspector.ConsoleMessage.MessageSource.Network) {
             if (this._request) {
+                this._stackTrace = this._request.stackTrace;
                 if (this.level === WebInspector.ConsoleMessage.MessageLevel.Error) {
-                    this._stackTrace = this._request.stackTrace;
                     messageText = document.createElement("span");
                     messageText.appendChild(document.createTextNode(this._request.requestMethod + " "));
                     var anchor = WebInspector.linkifyURLAsNode(this._request.url);
@@ -152,7 +152,7 @@
 
         this._formattedMessage.appendChild(messageText);
 
-        var dumpStackTrace = !!this._stackTrace && (this.level === WebInspector.ConsoleMessage.MessageLevel.Error || this.type === WebInspector.ConsoleMessage.MessageType.Trace);
+        var dumpStackTrace = !!this._stackTrace && (this.source === WebInspector.ConsoleMessage.MessageSource.Network || this.level === WebInspector.ConsoleMessage.MessageLevel.Error || this.type === WebInspector.ConsoleMessage.MessageType.Trace);
         if (dumpStackTrace) {
             var ol = document.createElement("ol");
             ol.className = "outline-disclosure";
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to