Title: [200275] trunk/Source/WebKit2
Revision
200275
Author
cdu...@apple.com
Date
2016-04-29 18:28:22 -0700 (Fri, 29 Apr 2016)

Log Message

Remove unnecessary isolated String copying from one of NetworkCache::Key's constructor
https://bugs.webkit.org/show_bug.cgi?id=157207

Reviewed by Antti Koivisto.

Remove unnecessary isolated String copying from one of NetworkCache::Key's
constructor. We are anyway going to create isolated copies if the Key ends
up getting copied.

* NetworkProcess/cache/NetworkCacheKey.cpp:
(WebKit::NetworkCache::Key::Key):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (200274 => 200275)


--- trunk/Source/WebKit2/ChangeLog	2016-04-30 01:14:39 UTC (rev 200274)
+++ trunk/Source/WebKit2/ChangeLog	2016-04-30 01:28:22 UTC (rev 200275)
@@ -1,3 +1,17 @@
+2016-04-29  Chris Dumez  <cdu...@apple.com>
+
+        Remove unnecessary isolated String copying from one of NetworkCache::Key's constructor
+        https://bugs.webkit.org/show_bug.cgi?id=157207
+
+        Reviewed by Antti Koivisto.
+
+        Remove unnecessary isolated String copying from one of NetworkCache::Key's
+        constructor. We are anyway going to create isolated copies if the Key ends
+        up getting copied.
+
+        * NetworkProcess/cache/NetworkCacheKey.cpp:
+        (WebKit::NetworkCache::Key::Key):
+
 2016-04-29  Brian Burg  <bb...@apple.com>
 
         Web Automation: performMouseInteraction command computes mouse event coordinates incorrectly

Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheKey.cpp (200274 => 200275)


--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheKey.cpp	2016-04-30 01:14:39 UTC (rev 200274)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheKey.cpp	2016-04-30 01:28:22 UTC (rev 200275)
@@ -53,10 +53,10 @@
 }
 
 Key::Key(const String& partition, const String& type, const String& range, const String& identifier)
-    : m_partition(partition.isEmpty() ? noPartitionString().isolatedCopy() : partition.isolatedCopy())
-    , m_type(type.isolatedCopy())
-    , m_identifier(identifier.isolatedCopy())
-    , m_range(range.isolatedCopy())
+    : m_partition(partition.isEmpty() ? noPartitionString() : partition)
+    , m_type(type)
+    , m_identifier(identifier)
+    , m_range(range)
     , m_hash(computeHash())
 {
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to