Title: [200281] trunk/Source/WebKit2
Revision
200281
Author
[email protected]
Date
2016-04-29 20:36:48 -0700 (Fri, 29 Apr 2016)

Log Message

Drop useless check in SpeculativeLoadManager::registerLoad()
https://bugs.webkit.org/show_bug.cgi?id=157204

Reviewed by Antti Koivisto.

Drop useless check in SpeculativeLoadManager::registerLoad(). There is
no way to end up this code path with a non-HTTP family request.

* NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::SpeculativeLoadManager::registerLoad):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (200280 => 200281)


--- trunk/Source/WebKit2/ChangeLog	2016-04-30 03:21:14 UTC (rev 200280)
+++ trunk/Source/WebKit2/ChangeLog	2016-04-30 03:36:48 UTC (rev 200281)
@@ -1,3 +1,16 @@
+2016-04-29  Chris Dumez  <[email protected]>
+
+        Drop useless check in SpeculativeLoadManager::registerLoad()
+        https://bugs.webkit.org/show_bug.cgi?id=157204
+
+        Reviewed by Antti Koivisto.
+
+        Drop useless check in SpeculativeLoadManager::registerLoad(). There is
+        no way to end up this code path with a non-HTTP family request.
+
+        * NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
+        (WebKit::NetworkCache::SpeculativeLoadManager::registerLoad):
+
 2016-04-29  Brian Burg  <[email protected]>
 
         Web Automation: add SPI to mark an existing NSEvent as synthesized for automation

Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp (200280 => 200281)


--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp	2016-04-30 03:21:14 UTC (rev 200280)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp	2016-04-30 03:36:48 UTC (rev 200281)
@@ -358,8 +358,9 @@
 void SpeculativeLoadManager::registerLoad(const GlobalFrameID& frameID, const ResourceRequest& request, const Key& resourceKey)
 {
     ASSERT(RunLoop::isMain());
+    ASSERT(request.url().protocolIsInHTTPFamily());
 
-    if (!request.url().protocolIsInHTTPFamily() || request.httpMethod() != "GET")
+    if (request.httpMethod() != "GET")
         return;
 
     auto isMainResource = request.requester() == ResourceRequest::Requester::Main;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to