Title: [200339] trunk/Tools
Revision
200339
Author
[email protected]
Date
2016-05-02 14:42:07 -0700 (Mon, 02 May 2016)

Log Message

Add fail-fast option to run-_javascript_core-tests
https://bugs.webkit.org/show_bug.cgi?id=157270

Patch by Srinivasan Vijayaraghavan <[email protected]> on 2016-05-02
Reviewed by Geoffrey Garen.

* Scripts/run-_javascript_core-tests: Add fail-fast command line option.
Defaults to yes, which is the current behavior.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (200338 => 200339)


--- trunk/Tools/ChangeLog	2016-05-02 21:20:15 UTC (rev 200338)
+++ trunk/Tools/ChangeLog	2016-05-02 21:42:07 UTC (rev 200339)
@@ -1,3 +1,13 @@
+2016-05-02  Srinivasan Vijayaraghavan  <[email protected]>
+
+        Add fail-fast option to run-_javascript_core-tests
+        https://bugs.webkit.org/show_bug.cgi?id=157270
+
+        Reviewed by Geoffrey Garen.
+
+        * Scripts/run-_javascript_core-tests: Add fail-fast command line option.
+        Defaults to yes, which is the current behavior.
+
 2016-05-02  Carlos Alberto Lopez Perez  <[email protected]>
 
         [CMake] MiniBrowser fails to build because libsoup link flags are not defined.

Modified: trunk/Tools/Scripts/run-_javascript_core-tests (200338 => 200339)


--- trunk/Tools/Scripts/run-_javascript_core-tests	2016-05-02 21:20:15 UTC (rev 200338)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2016-05-02 21:42:07 UTC (rev 200339)
@@ -67,6 +67,7 @@
 my $enableFTL = isAppleMacWebKit() || isX86_64() && (isGtk() || isEfl());
 my $createTarball = 0;
 my $remoteHost = 0;
+my $failFast = 1;
 my $remoteConfigFile;
 my $jsonFileName;
 
@@ -76,6 +77,7 @@
 my $jscStressDefault = $runJSCStress ? "will run" : " will not run";
 my $jitStressTestsDefault = $runJITStressTests ? "will run" : " will not run";
 my $quickModeDefault = $runQuickMode ? "some" : "all";
+my $failFastDefault = $failFast ? "fail fast" : "don't fail fast";
 my $filter;
 my $usage = <<EOF;
 Usage: $programName [options] [options to pass to build system]
@@ -90,6 +92,7 @@
                                 If the runner only runs some it will run the default and no-cjit-validate modes.
                                 Note, this will not change the behavior of tests that specify their own modes.
 
+  --[no-]fail-fast              Stop this script when a test family reports an error or failure (default: $failFastDefault)
   --json-output=                Create a file at specified path, listing failed stress tests in JSON format.
   --tarball                     Create a tarball of the bundle produced by running the JSC stress tests.
   --remote=                     Run the JSC stress tests on the specified remote host. Implies --tarball.
@@ -116,6 +119,7 @@
     'jsc-stress!' => \$runJSCStress,
     'jit-stress-tests!' => \$runJITStressTests,
     'quick!' => \$runQuickMode,
+    'fail-fast!' => \$failFast,
     'json-output=s' => \$jsonFileName,
     'tarball!' => \$createTarball,
     'remote=s' => \$remoteHost,
@@ -203,7 +207,9 @@
     my $testapiResult = system { $command[0] } @command;
     my $exitStatus = exitStatus($testapiResult);
     print "testAPI completed with rc=$testapiResult ($exitStatus)\n";
-    exit exitStatus($testapiResult) if $testapiResult;
+    if ($testapiResult && $failFast) {
+        exit exitStatus($testapiResult);
+    }
 }
 
 # Find _javascript_Core directory
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to