Title: [200367] trunk
Revision
200367
Author
[email protected]
Date
2016-05-03 02:18:40 -0700 (Tue, 03 May 2016)

Log Message

Unreviewed follow-up testapi fix after r200355.

Source/_javascript_Core:

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
Revert back to non-enumerable. This matches our older behavior,
we can decide to make this Enumerable later if needed.

LayoutTests:

* js/console-expected.txt:
* js/console.html:
Make window.console non-enumerable.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (200366 => 200367)


--- trunk/LayoutTests/ChangeLog	2016-05-03 09:09:25 UTC (rev 200366)
+++ trunk/LayoutTests/ChangeLog	2016-05-03 09:18:40 UTC (rev 200367)
@@ -1,3 +1,11 @@
+2016-05-03  Joseph Pecoraro  <[email protected]>
+
+        Unreviewed follow-up testapi fix after r200355.
+
+        * js/console-expected.txt:
+        * js/console.html:
+        Make window.console non-enumerable.
+
 2016-05-03  Carlos Garcia Campos  <[email protected]>
 
         Unreviewed GTK+ gardening. Update drag and drop tests bug reference.

Modified: trunk/LayoutTests/js/console-expected.txt (200366 => 200367)


--- trunk/LayoutTests/js/console-expected.txt	2016-05-03 09:09:25 UTC (rev 200366)
+++ trunk/LayoutTests/js/console-expected.txt	2016-05-03 09:18:40 UTC (rev 200367)
@@ -14,7 +14,7 @@
 PASS console is console
 PASS consoleDescriptor.configurable is true
 PASS consoleDescriptor.writable is true
-PASS consoleDescriptor.enumerable is true
+PASS consoleDescriptor.enumerable is false
 
 console.debug
 PASS typeof console.debug is "function"

Modified: trunk/LayoutTests/js/console.html (200366 => 200367)


--- trunk/LayoutTests/js/console.html	2016-05-03 09:09:25 UTC (rev 200366)
+++ trunk/LayoutTests/js/console.html	2016-05-03 09:18:40 UTC (rev 200367)
@@ -13,7 +13,7 @@
 var consoleDescriptor = Object.getOwnPropertyDescriptor(window, "console");
 shouldBeTrue('consoleDescriptor.configurable');
 shouldBeTrue('consoleDescriptor.writable');
-shouldBeTrue('consoleDescriptor.enumerable');
+shouldBeFalse('consoleDescriptor.enumerable');
 
 // Console methods don't care what their this object is.
 console.log("log message");

Modified: trunk/Source/_javascript_Core/ChangeLog (200366 => 200367)


--- trunk/Source/_javascript_Core/ChangeLog	2016-05-03 09:09:25 UTC (rev 200366)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-05-03 09:18:40 UTC (rev 200367)
@@ -1,3 +1,12 @@
+2016-05-03  Joseph Pecoraro  <[email protected]>
+
+        Unreviewed follow-up testapi fix after r200355.
+
+        * runtime/JSGlobalObject.cpp:
+        (JSC::JSGlobalObject::init):
+        Revert back to non-enumerable. This matches our older behavior,
+        we can decide to make this Enumerable later if needed.
+
 2016-05-02  Joseph Pecoraro  <[email protected]>
 
         Web Inspector: Reflect.toString() should be [object Object] not [object Reflect]

Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp (200366 => 200367)


--- trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2016-05-03 09:09:25 UTC (rev 200366)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2016-05-03 09:18:40 UTC (rev 200367)
@@ -497,7 +497,7 @@
     ReflectObject* reflectObject = ReflectObject::create(vm, this, ReflectObject::createStructure(vm, this, m_objectPrototype.get()));
     putDirectWithoutTransition(vm, vm.propertyNames->Reflect, reflectObject, DontEnum);
 
-    putDirectWithoutTransition(vm, vm.propertyNames->console, ConsoleObject::create(vm, this, ConsoleObject::createStructure(vm, this, m_objectPrototype.get())));
+    putDirectWithoutTransition(vm, vm.propertyNames->console, ConsoleObject::create(vm, this, ConsoleObject::createStructure(vm, this, m_objectPrototype.get())), DontEnum);
 
     JSTypedArrayViewConstructor* typedArraySuperConstructor = JSTypedArrayViewConstructor::create(vm, this, JSTypedArrayViewConstructor::createStructure(vm, this, m_functionPrototype.get()), typedArrayProto, speciesGetterSetter);
     typedArrayProto->putDirectWithoutTransition(vm, vm.propertyNames->constructor, typedArraySuperConstructor, DontEnum);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to