Log Message
Web Inspector: Update window.console function API description strings in Console https://bugs.webkit.org/show_bug.cgi?id=157298
Patch by Joseph Pecoraro <[email protected]> on 2016-05-03 Reviewed by Timothy Hatcher. * UserInterface/Models/NativeFunctionParameters.js: * UserInterface/Views/ObjectTreePropertyTreeElement.js: (WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString): The Console object changed how it works. Work with the new structure, and the older structure for legacy backends.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (200372 => 200373)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-03 15:30:52 UTC (rev 200372)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-03 15:39:28 UTC (rev 200373)
@@ -1,5 +1,18 @@
2016-05-03 Joseph Pecoraro <[email protected]>
+ Web Inspector: Update window.console function API description strings in Console
+ https://bugs.webkit.org/show_bug.cgi?id=157298
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Models/NativeFunctionParameters.js:
+ * UserInterface/Views/ObjectTreePropertyTreeElement.js:
+ (WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
+ The Console object changed how it works. Work with the new
+ structure, and the older structure for legacy backends.
+
+2016-05-03 Joseph Pecoraro <[email protected]>
+
Web Inspector: Allow format specifiers in console.assert and console.trace
https://bugs.webkit.org/show_bug.cgi?id=157295
<rdar://problem/26056039>
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js (200372 => 200373)
--- trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2016-05-03 15:30:52 UTC (rev 200372)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2016-05-03 15:39:28 UTC (rev 200373)
@@ -160,6 +160,29 @@
__proto__: null,
},
+ Console: {
+ assert: "condition, [message], [...values]",
+ count: "[label]",
+ debug: "message, [...values]",
+ dir: "object",
+ dirxml: "object",
+ error: "message, [...values]",
+ group: "[name]",
+ groupCollapsed: "[name]",
+ groupEnd: "[name]",
+ info: "message, [...values]",
+ log: "message, [...values]",
+ profile: "name",
+ profileEnd: "name",
+ table: "data, [columns]",
+ time: "name",
+ timeEnd: "name",
+ timeStamp: "[label]",
+ trace: "message, [...values]",
+ warn: "message, [...values]",
+ __proto__: null,
+ },
+
// Autogenerated DOM Interface static methods.
IDBKeyRangeConstructor: {
@@ -370,29 +393,6 @@
__proto__: null,
},
- Console: {
- assert: "condition, [message], [...values]",
- count: "[label]",
- debug: "message, [...values]",
- dir: "object",
- dirxml: "object",
- error: "message, [...values]",
- group: "[name]",
- groupCollapsed: "[name]",
- groupEnd: "[name]",
- info: "message, [...values]",
- log: "message, [...values]",
- profile: "name",
- profileEnd: "name",
- table: "data, [columns]",
- time: "name",
- timeEnd: "name",
- timeStamp: "[label]",
- trace: "message, [...values]",
- warn: "message, [...values]",
- __proto__: null,
- },
-
// Curated DOM Interfaces.
Element: {
@@ -2187,4 +2187,9 @@
Object.assign(WebInspector.NativePrototypeFunctionParameters.Element, ParentNode);
Object.assign(WebInspector.NativePrototypeFunctionParameters.Document, ParentNode);
Object.assign(WebInspector.NativePrototypeFunctionParameters.DocumentFragment, ParentNode);
+
+ // COMPATIBILITY (iOS 9): window.console used to be a Console object instance,
+ // now it is just a namespace object on the global object.
+ WebInspector.NativePrototypeFunctionParameters.Console = WebInspector.NativeConstructorFunctionParameters.Console;
+
})();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js (200372 => 200373)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js 2016-05-03 15:30:52 UTC (rev 200372)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js 2016-05-03 15:39:28 UTC (rev 200373)
@@ -272,7 +272,7 @@
}
// Native DOM constructor or on native objects that are not functions.
- if (parentDescription.endsWith("Constructor") || parentDescription === "Math" || parentDescription === "JSON" || parentDescription === "Reflect") {
+ if (parentDescription.endsWith("Constructor") || ["Math", "JSON", "Reflect", "Console"].includes(parentDescription)) {
var name = parentDescription;
if (WebInspector.NativeConstructorFunctionParameters[name]) {
var params = WebInspector.NativeConstructorFunctionParameters[name][this._property.name];
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
