Title: [200384] trunk/Source/_javascript_Core
Revision
200384
Author
[email protected]
Date
2016-05-03 11:38:59 -0700 (Tue, 03 May 2016)

Log Message

Eliminate PassRefPtr conversion from ConsoleObject
https://bugs.webkit.org/show_bug.cgi?id=157300

Reviewed by Timothy Hatcher.

* runtime/ConsoleObject.cpp:
(JSC::consoleLogWithLevel):
(JSC::consoleProtoFuncClear):
(JSC::consoleProtoFuncDir):
(JSC::consoleProtoFuncDirXML):
(JSC::consoleProtoFuncTable):
(JSC::consoleProtoFuncTrace):
(JSC::consoleProtoFuncAssert):
(JSC::consoleProtoFuncCount):
(JSC::consoleProtoFuncTimeStamp):
(JSC::consoleProtoFuncGroup):
(JSC::consoleProtoFuncGroupCollapsed):
(JSC::consoleProtoFuncGroupEnd):
No need to release to a PassRefPtr, we can just move into the RefPtr<>&&.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (200383 => 200384)


--- trunk/Source/_javascript_Core/ChangeLog	2016-05-03 18:36:34 UTC (rev 200383)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-05-03 18:38:59 UTC (rev 200384)
@@ -1,3 +1,25 @@
+2016-05-03  Joseph Pecoraro  <[email protected]>
+
+        Eliminate PassRefPtr conversion from ConsoleObject
+        https://bugs.webkit.org/show_bug.cgi?id=157300
+
+        Reviewed by Timothy Hatcher.
+
+        * runtime/ConsoleObject.cpp:
+        (JSC::consoleLogWithLevel):
+        (JSC::consoleProtoFuncClear):
+        (JSC::consoleProtoFuncDir):
+        (JSC::consoleProtoFuncDirXML):
+        (JSC::consoleProtoFuncTable):
+        (JSC::consoleProtoFuncTrace):
+        (JSC::consoleProtoFuncAssert):
+        (JSC::consoleProtoFuncCount):
+        (JSC::consoleProtoFuncTimeStamp):
+        (JSC::consoleProtoFuncGroup):
+        (JSC::consoleProtoFuncGroupCollapsed):
+        (JSC::consoleProtoFuncGroupEnd):
+        No need to release to a PassRefPtr, we can just move into the RefPtr<>&&.
+
 2016-05-01  Filip Pizlo  <[email protected]>
 
         Speed up JSGlobalObject initialization by making some properties lazy

Modified: trunk/Source/_javascript_Core/runtime/ConsoleObject.cpp (200383 => 200384)


--- trunk/Source/_javascript_Core/runtime/ConsoleObject.cpp	2016-05-03 18:36:34 UTC (rev 200383)
+++ trunk/Source/_javascript_Core/runtime/ConsoleObject.cpp	2016-05-03 18:38:59 UTC (rev 200384)
@@ -111,7 +111,7 @@
         return JSValue::encode(jsUndefined());
 
     RefPtr<Inspector::ScriptArguments> arguments(Inspector::createScriptArguments(exec, 0));
-    client->logWithLevel(exec, arguments.release(), level);
+    client->logWithLevel(exec, WTFMove(arguments), level);
     return JSValue::encode(jsUndefined());
 }
 
@@ -147,7 +147,7 @@
         return JSValue::encode(jsUndefined());
 
     RefPtr<Inspector::ScriptArguments> arguments(Inspector::createScriptArguments(exec, 0));
-    client->clear(exec, arguments.release());
+    client->clear(exec, WTFMove(arguments));
     return JSValue::encode(jsUndefined());
 }
 
@@ -158,7 +158,7 @@
         return JSValue::encode(jsUndefined());
 
     RefPtr<Inspector::ScriptArguments> arguments(Inspector::createScriptArguments(exec, 0));
-    client->dir(exec, arguments.release());
+    client->dir(exec, WTFMove(arguments));
     return JSValue::encode(jsUndefined());
 }
 
@@ -169,7 +169,7 @@
         return JSValue::encode(jsUndefined());
 
     RefPtr<Inspector::ScriptArguments> arguments(Inspector::createScriptArguments(exec, 0));
-    client->dirXML(exec, arguments.release());
+    client->dirXML(exec, WTFMove(arguments));
     return JSValue::encode(jsUndefined());
 }
 
@@ -180,7 +180,7 @@
         return JSValue::encode(jsUndefined());
 
     RefPtr<Inspector::ScriptArguments> arguments(Inspector::createScriptArguments(exec, 0));
-    client->table(exec, arguments.release());
+    client->table(exec, WTFMove(arguments));
     return JSValue::encode(jsUndefined());
 }
 
@@ -191,7 +191,7 @@
         return JSValue::encode(jsUndefined());
 
     RefPtr<Inspector::ScriptArguments> arguments(Inspector::createScriptArguments(exec, 0));
-    client->trace(exec, arguments.release());
+    client->trace(exec, WTFMove(arguments));
     return JSValue::encode(jsUndefined());
 }
 
@@ -209,7 +209,7 @@
         return JSValue::encode(jsUndefined());
 
     RefPtr<Inspector::ScriptArguments> arguments(Inspector::createScriptArguments(exec, 1));
-    client->assertion(exec, arguments.release());
+    client->assertion(exec, WTFMove(arguments));
     return JSValue::encode(jsUndefined());
 }
 
@@ -220,7 +220,7 @@
         return JSValue::encode(jsUndefined());
 
     RefPtr<Inspector::ScriptArguments> arguments(Inspector::createScriptArguments(exec, 0));
-    client->count(exec, arguments.release());
+    client->count(exec, WTFMove(arguments));
     return JSValue::encode(jsUndefined());
 }
 
@@ -325,7 +325,7 @@
         return JSValue::encode(jsUndefined());
 
     RefPtr<Inspector::ScriptArguments> arguments(Inspector::createScriptArguments(exec, 0));
-    client->timeStamp(exec, arguments.release());
+    client->timeStamp(exec, WTFMove(arguments));
     return JSValue::encode(jsUndefined());
 }
 
@@ -336,7 +336,7 @@
         return JSValue::encode(jsUndefined());
 
     RefPtr<Inspector::ScriptArguments> arguments(Inspector::createScriptArguments(exec, 0));
-    client->group(exec, arguments.release());
+    client->group(exec, WTFMove(arguments));
     return JSValue::encode(jsUndefined());
 }
 
@@ -347,7 +347,7 @@
         return JSValue::encode(jsUndefined());
 
     RefPtr<Inspector::ScriptArguments> arguments(Inspector::createScriptArguments(exec, 0));
-    client->groupCollapsed(exec, arguments.release());
+    client->groupCollapsed(exec, WTFMove(arguments));
     return JSValue::encode(jsUndefined());
 }
 
@@ -358,7 +358,7 @@
         return JSValue::encode(jsUndefined());
 
     RefPtr<Inspector::ScriptArguments> arguments(Inspector::createScriptArguments(exec, 0));
-    client->groupEnd(exec, arguments.release());
+    client->groupEnd(exec, WTFMove(arguments));
     return JSValue::encode(jsUndefined());
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to