Title: [200391] trunk/Source/WebKit2
- Revision
- 200391
- Author
- [email protected]
- Date
- 2016-05-03 15:31:16 -0700 (Tue, 03 May 2016)
Log Message
Temporary workaround for Apple Internal builds
<rdar://problem/25992976>
For Apple Internal builds treat error code errSecCSGuestInvalid as if it were error code errSecCSUnsigned.
We will look to remove this workaround in the fix for <rdar://problem/26075714>.
* Shared/mac/CodeSigning.mm:
(WebKit::secCodeSigningIdentifier):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (200390 => 200391)
--- trunk/Source/WebKit2/ChangeLog 2016-05-03 22:20:07 UTC (rev 200390)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-03 22:31:16 UTC (rev 200391)
@@ -1,3 +1,14 @@
+2016-05-03 Daniel Bates <[email protected]>
+
+ Temporary workaround for Apple Internal builds
+ <rdar://problem/25992976>
+
+ For Apple Internal builds treat error code errSecCSGuestInvalid as if it were error code errSecCSUnsigned.
+ We will look to remove this workaround in the fix for <rdar://problem/26075714>.
+
+ * Shared/mac/CodeSigning.mm:
+ (WebKit::secCodeSigningIdentifier):
+
2016-05-03 Chris Dumez <[email protected]>
Unreviewed, rolling out r199259 and r200161.
Modified: trunk/Source/WebKit2/Shared/mac/CodeSigning.mm (200390 => 200391)
--- trunk/Source/WebKit2/Shared/mac/CodeSigning.mm 2016-05-03 22:20:07 UTC (rev 200390)
+++ trunk/Source/WebKit2/Shared/mac/CodeSigning.mm 2016-05-03 22:31:16 UTC (rev 200391)
@@ -79,6 +79,11 @@
OSStatus errorCode = SecCodeCheckValidity(code, kSecCSDefaultFlags, signingRequirement.get());
if (errorCode == errSecCSUnsigned || errorCode == errSecCSReqFailed)
return String(); // Unsigned or signed by a third-party
+#if USE(APPLE_INTERNAL_SDK)
+ // FIXME: Temporary workaround for <rdar://problem/25992976>. We need to fix <rdar://problem/25697779>.
+ if (errorCode == errSecCSGuestInvalid)
+ return String();
+#endif
RELEASE_ASSERT_WITH_MESSAGE(!errorCode, "SecCodeCheckValidity() failed with error: %ld", static_cast<long>(errorCode));
String codeSigningIdentifier;
RetainPtr<CFDictionaryRef> signingInfo = secCodeSigningInformation(code);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
