Title: [200398] trunk/Source/_javascript_Core
- Revision
- 200398
- Author
- [email protected]
- Date
- 2016-05-03 18:06:02 -0700 (Tue, 03 May 2016)
Log Message
Web Inspector: Remove unused parameter of ScriptArguments::getFirstArgumentAsString
https://bugs.webkit.org/show_bug.cgi?id=157301
Patch by Joseph Pecoraro <[email protected]> on 2016-05-03
Reviewed by Timothy Hatcher.
* inspector/ScriptArguments.cpp:
(Inspector::ScriptArguments::getFirstArgumentAsString):
* inspector/ScriptArguments.h:
Remove unused argument and related code.
* runtime/ConsoleClient.cpp:
(JSC::ConsoleClient::printConsoleMessageWithArguments):
Drive by remove unnecessary cast.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (200397 => 200398)
--- trunk/Source/_javascript_Core/ChangeLog 2016-05-04 01:05:05 UTC (rev 200397)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-05-04 01:06:02 UTC (rev 200398)
@@ -1,3 +1,19 @@
+2016-05-03 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Remove unused parameter of ScriptArguments::getFirstArgumentAsString
+ https://bugs.webkit.org/show_bug.cgi?id=157301
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/ScriptArguments.cpp:
+ (Inspector::ScriptArguments::getFirstArgumentAsString):
+ * inspector/ScriptArguments.h:
+ Remove unused argument and related code.
+
+ * runtime/ConsoleClient.cpp:
+ (JSC::ConsoleClient::printConsoleMessageWithArguments):
+ Drive by remove unnecessary cast.
+
2016-05-03 Michael Saboff <[email protected]>
Crash: Array.prototype.slice() and .splice() can call fastSlice() after an array is truncated
Modified: trunk/Source/_javascript_Core/inspector/ScriptArguments.cpp (200397 => 200398)
--- trunk/Source/_javascript_Core/inspector/ScriptArguments.cpp 2016-05-04 01:05:05 UTC (rev 200397)
+++ trunk/Source/_javascript_Core/inspector/ScriptArguments.cpp 2016-05-04 01:06:02 UTC (rev 200398)
@@ -52,7 +52,7 @@
{
}
-const Deprecated::ScriptValue &ScriptArguments::argumentAt(size_t index) const
+const Deprecated::ScriptValue& ScriptArguments::argumentAt(size_t index) const
{
ASSERT(m_arguments.size() > index);
return m_arguments[index];
@@ -66,21 +66,17 @@
return nullptr;
}
-bool ScriptArguments::getFirstArgumentAsString(String& result, bool checkForNullOrUndefined)
+bool ScriptArguments::getFirstArgumentAsString(String& result)
{
if (!argumentCount())
return false;
- const Deprecated::ScriptValue& value = argumentAt(0);
- if (checkForNullOrUndefined && (value.isNull() || value.isUndefined()))
- return false;
-
if (!globalState()) {
ASSERT_NOT_REACHED();
return false;
}
- result = value.toString(globalState());
+ result = argumentAt(0).toString(globalState());
return true;
}
Modified: trunk/Source/_javascript_Core/inspector/ScriptArguments.h (200397 => 200398)
--- trunk/Source/_javascript_Core/inspector/ScriptArguments.h 2016-05-04 01:05:05 UTC (rev 200397)
+++ trunk/Source/_javascript_Core/inspector/ScriptArguments.h 2016-05-04 01:06:02 UTC (rev 200398)
@@ -59,7 +59,7 @@
JSC::ExecState* globalState() const;
- bool getFirstArgumentAsString(String& result, bool checkForNullOrUndefined = false);
+ bool getFirstArgumentAsString(String& result);
bool isEqual(ScriptArguments*) const;
private:
Modified: trunk/Source/_javascript_Core/runtime/ConsoleClient.cpp (200397 => 200398)
--- trunk/Source/_javascript_Core/runtime/ConsoleClient.cpp 2016-05-04 01:05:05 UTC (rev 200397)
+++ trunk/Source/_javascript_Core/runtime/ConsoleClient.cpp 2016-05-04 01:06:02 UTC (rev 200398)
@@ -178,7 +178,7 @@
functionName = ASCIILiteral("(unknown)");
StringBuilder callFrameBuilder;
- callFrameBuilder.appendNumber(static_cast<unsigned long>(i));
+ callFrameBuilder.appendNumber(i);
callFrameBuilder.appendLiteral(": ");
callFrameBuilder.append(functionName);
callFrameBuilder.append('(');
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
