Title: [200410] trunk/Source/WebCore
Revision
200410
Author
[email protected]
Date
2016-05-04 00:44:40 -0700 (Wed, 04 May 2016)

Log Message

CrashTracer: [USER] com.apple.WebKit.WebContent at …ple.WebCore: WebCore::EditCommandComposition::unapply + 105
https://bugs.webkit.org/show_bug.cgi?id=157282
<rdar://problem/25391441>

Reviewed by Darin Adler.

A frame could be destroyed in the middle of executing undo/redo command.
Therefore, add an early return.

* editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (200409 => 200410)


--- trunk/Source/WebCore/ChangeLog	2016-05-04 07:43:17 UTC (rev 200409)
+++ trunk/Source/WebCore/ChangeLog	2016-05-04 07:44:40 UTC (rev 200410)
@@ -1,3 +1,18 @@
+2016-05-04  Jiewen Tan  <[email protected]>
+
+        CrashTracer: [USER] com.apple.WebKit.WebContent at …ple.WebCore: WebCore::EditCommandComposition::unapply + 105
+        https://bugs.webkit.org/show_bug.cgi?id=157282
+        <rdar://problem/25391441>
+
+        Reviewed by Darin Adler.
+
+        A frame could be destroyed in the middle of executing undo/redo command.
+        Therefore, add an early return.
+
+        * editing/CompositeEditCommand.cpp:
+        (WebCore::EditCommandComposition::unapply):
+        (WebCore::EditCommandComposition::reapply):
+
 2016-05-04  Zan Dobersek  <[email protected]>
 
         [CoordGraphics] CompositingCoordinator should hande root compositing and view overlay layers separately

Modified: trunk/Source/WebCore/editing/CompositeEditCommand.cpp (200409 => 200410)


--- trunk/Source/WebCore/editing/CompositeEditCommand.cpp	2016-05-04 07:43:17 UTC (rev 200409)
+++ trunk/Source/WebCore/editing/CompositeEditCommand.cpp	2016-05-04 07:44:40 UTC (rev 200410)
@@ -212,7 +212,8 @@
 {
     ASSERT(m_document);
     RefPtr<Frame> frame = m_document->frame();
-    ASSERT(frame);
+    if (!frame)
+        return;
 
     m_replacedText.captureTextToBeDeletedByUnapply();
 
@@ -243,7 +244,8 @@
 {
     ASSERT(m_document);
     RefPtr<Frame> frame = m_document->frame();
-    ASSERT(frame);
+    if (!frame)
+        return;
 
     m_replacedText.captureTextToBeDeletedByReapply();
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to