- Revision
- 200436
- Author
- [email protected]
- Date
- 2016-05-04 15:28:40 -0700 (Wed, 04 May 2016)
Log Message
TestRunner should always enable all the experimental features
https://bugs.webkit.org/show_bug.cgi?id=157360
<rdar://problem/26099748>
Reviewed by Anders Carlsson.
Source/WebKit2:
Experimental features are disabled by default, but it is
a pain to enable them in every test. Instead, have the
test runner turn them all on.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesEnableAllExperimentalFeatures):
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::enableAllExperimentalFeatures):
* UIProcess/WebPreferences.h:
Tools:
Call the new SPI that enables all the experimental features.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (200435 => 200436)
--- trunk/Source/WebKit2/ChangeLog 2016-05-04 22:27:58 UTC (rev 200435)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-04 22:28:40 UTC (rev 200436)
@@ -1,3 +1,22 @@
+2016-05-04 Dean Jackson <[email protected]>
+
+ TestRunner should always enable all the experimental features
+ https://bugs.webkit.org/show_bug.cgi?id=157360
+ <rdar://problem/26099748>
+
+ Reviewed by Anders Carlsson.
+
+ Experimental features are disabled by default, but it is
+ a pain to enable them in every test. Instead, have the
+ test runner turn them all on.
+
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesEnableAllExperimentalFeatures):
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * UIProcess/WebPreferences.cpp:
+ (WebKit::WebPreferences::enableAllExperimentalFeatures):
+ * UIProcess/WebPreferences.h:
+
2016-05-04 Gyuyoung Kim <[email protected]>
Add WKPreference for SelectionPaintingWithoutSelectionGaps
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (200435 => 200436)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-05-04 22:27:58 UTC (rev 200435)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-05-04 22:28:40 UTC (rev 200436)
@@ -62,6 +62,11 @@
return toAPI(preferences.release().leakRef());
}
+void WKPreferencesEnableAllExperimentalFeatures(WKPreferencesRef preferencesRef)
+{
+ toImpl(preferencesRef)->enableAllExperimentalFeatures();
+}
+
void WKPreferencesSetJavaScriptEnabled(WKPreferencesRef preferencesRef, bool _javascript_Enabled)
{
toImpl(preferencesRef)->setJavaScriptEnabled(_javascript_Enabled);
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (200435 => 200436)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-05-04 22:27:58 UTC (rev 200435)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-05-04 22:28:40 UTC (rev 200436)
@@ -57,6 +57,8 @@
// Creates a copy with no identifier.
WK_EXPORT WKPreferencesRef WKPreferencesCreateCopy(WKPreferencesRef);
+WK_EXPORT void WKPreferencesEnableAllExperimentalFeatures(WKPreferencesRef);
+
// Defaults to kWKFontSmoothingLevelMedium.
WK_EXPORT void WKPreferencesSetFontSmoothingLevel(WKPreferencesRef, WKFontSmoothingLevel);
WK_EXPORT WKFontSmoothingLevel WKPreferencesGetFontSmoothingLevel(WKPreferencesRef);
Modified: trunk/Source/WebKit2/UIProcess/WebPreferences.cpp (200435 => 200436)
--- trunk/Source/WebKit2/UIProcess/WebPreferences.cpp 2016-05-04 22:27:58 UTC (rev 200435)
+++ trunk/Source/WebKit2/UIProcess/WebPreferences.cpp 2016-05-04 22:28:40 UTC (rev 200436)
@@ -263,6 +263,16 @@
}
}
+void WebPreferences::enableAllExperimentalFeatures()
+{
+#define SET_FEATURE_ENABLED(KeyUpper, KeyLower, TypeName, Type, DefaultValue, HumanReadableName, HumanReadableDescription) \
+ set##KeyUpper(true); \
+
+ FOR_EACH_WEBKIT_EXPERIMENTAL_FEATURE_PREFERENCE(SET_FEATURE_ENABLED)
+
+#undef SET_FEATURE_ENABLED
+}
+
bool WebPreferences::anyPagesAreUsingPrivateBrowsing()
{
return privateBrowsingPageCount;
Modified: trunk/Source/WebKit2/UIProcess/WebPreferences.h (200435 => 200436)
--- trunk/Source/WebKit2/UIProcess/WebPreferences.h 2016-05-04 22:27:58 UTC (rev 200435)
+++ trunk/Source/WebKit2/UIProcess/WebPreferences.h 2016-05-04 22:28:40 UTC (rev 200436)
@@ -67,6 +67,7 @@
static const Vector<RefPtr<API::Object>>& experimentalFeatures();
bool isEnabledForFeature(const API::ExperimentalFeature&) const;
void setEnabledForFeature(bool, const API::ExperimentalFeature&);
+ void enableAllExperimentalFeatures();
// Exposed for WebKitTestRunner use only.
void forceUpdate() { update(); }
Modified: trunk/Tools/ChangeLog (200435 => 200436)
--- trunk/Tools/ChangeLog 2016-05-04 22:27:58 UTC (rev 200435)
+++ trunk/Tools/ChangeLog 2016-05-04 22:28:40 UTC (rev 200436)
@@ -1,3 +1,16 @@
+2016-05-04 Dean Jackson <[email protected]>
+
+ TestRunner should always enable all the experimental features
+ https://bugs.webkit.org/show_bug.cgi?id=157360
+ <rdar://problem/26099748>
+
+ Reviewed by Anders Carlsson.
+
+ Call the new SPI that enables all the experimental features.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetPreferencesToConsistentValues):
+
2016-05-04 Mark Lam <[email protected]>
ES6 Function.name inferred from property names of literal objects can break some websites.
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (200435 => 200436)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2016-05-04 22:27:58 UTC (rev 200435)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2016-05-04 22:28:40 UTC (rev 200436)
@@ -643,6 +643,7 @@
// Reset preferences
WKPreferencesRef preferences = platformPreferences();
WKPreferencesResetTestRunnerOverrides(preferences);
+ WKPreferencesEnableAllExperimentalFeatures(preferences);
WKPreferencesSetPageVisibilityBasedProcessSuppressionEnabled(preferences, false);
WKPreferencesSetOfflineWebApplicationCacheEnabled(preferences, true);
WKPreferencesSetFontSmoothingLevel(preferences, kWKFontSmoothingLevelNoSubpixelAntiAliasing);