Log Message
Shadow DOM should not be experimental https://bugs.webkit.org/show_bug.cgi?id=157384 <rdar://problem/26123254>
Reviewed by Anders Carlsson. Shadow DOM is not an experimental feature. We want it enabled by default. This fixes the timeout in: WebKit2.InjectedBundleMakeAllShadowRootOpenTest * Shared/WebPreferencesDefinitions.h: Move the Shadow DOM preference out of Experimental. * WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (200472 => 200473)
--- trunk/Source/WebKit2/ChangeLog 2016-05-05 20:14:56 UTC (rev 200472)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-05 20:27:12 UTC (rev 200473)
@@ -1,3 +1,24 @@
+2016-05-05 Dean Jackson <[email protected]>
+
+ Shadow DOM should not be experimental
+ https://bugs.webkit.org/show_bug.cgi?id=157384
+ <rdar://problem/26123254>
+
+ Reviewed by Anders Carlsson.
+
+ Shadow DOM is not an experimental feature. We want
+ it enabled by default.
+
+ This fixes the timeout in:
+ WebKit2.InjectedBundleMakeAllShadowRootOpenTest
+
+ * Shared/WebPreferencesDefinitions.h: Move the Shadow
+ DOM preference out of Experimental.
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
2016-05-05 Simon Fraser <[email protected]>
Revert r200390, thus putting r199259 and r200161 and back.
Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (200472 => 200473)
--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-05-05 20:14:56 UTC (rev 200472)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-05-05 20:27:12 UTC (rev 200473)
@@ -231,6 +231,7 @@
macro(NewBlockInsideInlineModelEnabled, newBlockInsideInlineModelEnabled, Bool, bool, false, "", "") \
macro(HTTPEquivEnabled, httpEquivEnabled, Bool, bool, true, "", "") \
macro(MockCaptureDevicesEnabled, mockCaptureDevicesEnabled, Bool, bool, false, "", "") \
+ macro(ShadowDOMEnabled, shadowDOMEnabled, Bool, bool, true, "Shadow DOM", "HTML Shadow DOM prototype") \
macro(FetchAPIEnabled, fetchAPIEnabled, Bool, bool, false, "", "") \
macro(DownloadAttributeEnabled, downloadAttributeEnabled, Bool, bool, false, "", "") \
macro(SelectionPaintingWithoutSelectionGapsEnabled, selectionPaintingWithoutSelectionGapsEnabled, Bool, bool, DEFAULT_SELECTION_PAINTING_WITHOUT_SELECTION_GAPS_ENABLED, "", "") \
@@ -292,7 +293,6 @@
#define FOR_EACH_WEBKIT_EXPERIMENTAL_FEATURE_PREFERENCE(macro) \
macro(CSSGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, false, "CSS Grid", "CSS Grid Layout Module support") \
macro(CustomElementsEnabled, customElementsEnabled, Bool, bool, false, "Custom Elements", "HTML Custom Elements prototype") \
- macro(ShadowDOMEnabled, shadowDOMEnabled, Bool, bool, false, "Shadow DOM", "HTML Shadow DOM prototype") \
macro(WebGL2Enabled, webGL2Enabled, Bool, bool, false, "WebGL 2.0", "WebGL 2 prototype") \
\
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (200472 => 200473)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-05-05 20:14:56 UTC (rev 200472)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-05-05 20:27:12 UTC (rev 200473)
@@ -203,6 +203,11 @@
RuntimeEnabledFeatures::sharedFeatures().setDownloadAttributeEnabled(enabled);
#endif
+#if ENABLE(SHADOW_DOM)
+ if (preference == "WebKitShadowDOMEnabled")
+ RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(enabled);
+#endif
+
#if ENABLE(CSS_GRID_LAYOUT)
if (preference == "WebKitCSSGridLayoutEnabled")
RuntimeEnabledFeatures::sharedFeatures().setCSSGridLayoutEnabled(enabled);
@@ -213,11 +218,6 @@
RuntimeEnabledFeatures::sharedFeatures().setCustomElementsEnabled(enabled);
#endif
-#if ENABLE(SHADOW_DOM)
- if (preference == "WebKitShadowDOMEnabled")
- RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(enabled);
-#endif
-
#if ENABLE(WEBGL2)
if (preference == "WebKitWebGL2Enabled")
RuntimeEnabledFeatures::sharedFeatures().setWebGL2Enabled(enabled);
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (200472 => 200473)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-05-05 20:14:56 UTC (rev 200472)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-05-05 20:27:12 UTC (rev 200473)
@@ -3108,6 +3108,10 @@
RuntimeEnabledFeatures::sharedFeatures().setDownloadAttributeEnabled(store.getBoolValueForKey(WebPreferencesKey::downloadAttributeEnabledKey()));
#endif
+#if ENABLE(SHADOW_DOM)
+ RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(store.getBoolValueForKey(WebPreferencesKey::shadowDOMEnabledKey()));
+#endif
+
// Experimental Features.
#if ENABLE(CSS_GRID_LAYOUT)
@@ -3118,10 +3122,6 @@
RuntimeEnabledFeatures::sharedFeatures().setCustomElementsEnabled(store.getBoolValueForKey(WebPreferencesKey::customElementsEnabledKey()));
#endif
-#if ENABLE(SHADOW_DOM)
- RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(store.getBoolValueForKey(WebPreferencesKey::shadowDOMEnabledKey()));
-#endif
-
#if ENABLE(WEBGL2)
RuntimeEnabledFeatures::sharedFeatures().setWebGL2Enabled(store.getBoolValueForKey(WebPreferencesKey::webGL2EnabledKey()));
#endif
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
