[webkit-changes] [200480] trunk/Source/JavaScriptCore

Thu, 05 May 2016 14:53:51 -0700

Title: [200480] trunk/Source/_javascript_Core
Revision
200480
Author
[email protected]
Date
2016-05-05 14:53:27 -0700 (Thu, 05 May 2016)

Log Message

Reduce thresholds that control the maximum IC stub size.

Rubber stamped by Chris Dumez and Benjamin Poulain.
        
This reduces the thresholds to before the megamorphic load optimizations to see if that
recovers a PLT regression.

* runtime/Options.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (200479 => 200480)


--- trunk/Source/_javascript_Core/ChangeLog	2016-05-05 21:38:41 UTC (rev 200479)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-05-05 21:53:27 UTC (rev 200480)
@@ -1,5 +1,16 @@
 2016-05-05  Filip Pizlo  <[email protected]>
 
+        Reduce thresholds that control the maximum IC stub size.
+
+        Rubber stamped by Chris Dumez and Benjamin Poulain.
+        
+        This reduces the thresholds to before the megamorphic load optimizations to see if that
+        recovers a PLT regression.
+
+        * runtime/Options.h:
+
+2016-05-05  Filip Pizlo  <[email protected]>
+
         We shouldn't crash if DFG AI proved that something was unreachable on one run but then decided not to prove it on another run
         https://bugs.webkit.org/show_bug.cgi?id=157379

Modified: trunk/Source/_javascript_Core/runtime/Options.h (200479 => 200480)


--- trunk/Source/_javascript_Core/runtime/Options.h	2016-05-05 21:38:41 UTC (rev 200479)
+++ trunk/Source/_javascript_Core/runtime/Options.h	2016-05-05 21:53:27 UTC (rev 200480)
@@ -123,9 +123,9 @@
     v(bool, forceCodeBlockLiveness, false, Normal, nullptr) \
     v(bool, forceICFailure, false, Normal, nullptr) \
     \
-    v(unsigned, repatchCountForCoolDown, 10, Normal, nullptr) \
+    v(unsigned, repatchCountForCoolDown, 8, Normal, nullptr) \
     v(unsigned, initialCoolDownCount, 20, Normal, nullptr) \
-    v(unsigned, repatchBufferingCountdown, 10, Normal, nullptr) \
+    v(unsigned, repatchBufferingCountdown, 8, Normal, nullptr) \
     \
     v(bool, dumpGeneratedBytecodes, false, Normal, nullptr) \
     v(bool, dumpBytecodeLivenessResults, false, Normal, nullptr) \
@@ -191,7 +191,7 @@
     v(bool, ftlCrashes, false, Normal, nullptr) /* fool-proof way of checking that you ended up in the FTL. ;-) */\
     v(bool, clobberAllRegsInFTLICSlowPath, !ASSERT_DISABLED, Normal, nullptr) \
     v(bool, useAccessInlining, true, Normal, nullptr) \
-    v(unsigned, maxAccessVariantListSize, 13, Normal, nullptr) \
+    v(unsigned, maxAccessVariantListSize, 8, Normal, nullptr) \
     v(unsigned, megamorphicLoadCost, 999, Normal, nullptr) /* This used to be 10, but we're temporarily testing what happens when the feature is disabled. */\
     v(bool, usePolyvariantDevirtualization, true, Normal, nullptr) \
     v(bool, usePolymorphicAccessInlining, true, Normal, nullptr) \

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to