Title: [200497] trunk/Source/WebKit2
- Revision
- 200497
- Author
- [email protected]
- Date
- 2016-05-05 16:59:52 -0700 (Thu, 05 May 2016)
Log Message
[GTK] Add CSS Grid Layout as experimental feature
https://bugs.webkit.org/show_bug.cgi?id=157391
Reviewed by Michael Catanzaro.
Now that we've a runtime feature again for CSS Grid Layout (r200215),
we can recover the old patch (r162215) that allows to enable/disable
CSS Grid Layout through the environment variable
WEBKITGTK_EXPERIMENTAL_FEATURES.
Example: WEBKITGTK_EXPERIMENTAL_FEATURES="CSS_GRID_LAYOUT=1"
* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsConstructed): Use new experimental feature to enable
or disable CSS Grid Layout.
* UIProcess/gtk/ExperimentalFeatures.cpp: Add new experimental feature.
* UIProcess/gtk/ExperimentalFeatures.h: Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (200496 => 200497)
--- trunk/Source/WebKit2/ChangeLog 2016-05-05 23:59:07 UTC (rev 200496)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-05 23:59:52 UTC (rev 200497)
@@ -1,3 +1,23 @@
+2016-05-05 Manuel Rego Casasnovas <[email protected]>
+
+ [GTK] Add CSS Grid Layout as experimental feature
+ https://bugs.webkit.org/show_bug.cgi?id=157391
+
+ Reviewed by Michael Catanzaro.
+
+ Now that we've a runtime feature again for CSS Grid Layout (r200215),
+ we can recover the old patch (r162215) that allows to enable/disable
+ CSS Grid Layout through the environment variable
+ WEBKITGTK_EXPERIMENTAL_FEATURES.
+
+ Example: WEBKITGTK_EXPERIMENTAL_FEATURES="CSS_GRID_LAYOUT=1"
+
+ * UIProcess/API/gtk/WebKitSettings.cpp:
+ (webKitSettingsConstructed): Use new experimental feature to enable
+ or disable CSS Grid Layout.
+ * UIProcess/gtk/ExperimentalFeatures.cpp: Add new experimental feature.
+ * UIProcess/gtk/ExperimentalFeatures.h: Ditto.
+
2016-05-05 Jer Noble <[email protected]>
[WK2] Media controls don't update if controller is created after the interface is created
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (200496 => 200497)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2016-05-05 23:59:07 UTC (rev 200496)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2016-05-05 23:59:52 UTC (rev 200497)
@@ -154,6 +154,10 @@
WebPreferences* prefs = WEBKIT_SETTINGS(object)->priv->preferences.get();
prefs->setShouldRespectImageOrientation(true);
+ ExperimentalFeatures features;
+ bool cssGridLayoutEnabled = features.isEnabled(ExperimentalFeatures::CSSGridLayout);
+ if (prefs->cssGridLayoutEnabled() != cssGridLayoutEnabled)
+ prefs->setCSSGridLayoutEnabled(cssGridLayoutEnabled);
}
static void webKitSettingsSetProperty(GObject* object, guint propId, const GValue* value, GParamSpec* paramSpec)
Modified: trunk/Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.cpp (200496 => 200497)
--- trunk/Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.cpp 2016-05-05 23:59:07 UTC (rev 200496)
+++ trunk/Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.cpp 2016-05-05 23:59:52 UTC (rev 200497)
@@ -39,6 +39,7 @@
};
static Setting settings[] = {
+ { ExperimentalFeatures::CSSGridLayout, "CSS_GRID_LAYOUT", true },
{ ExperimentalFeatures::RegionBasedColumns, "REGION_BASED_COLUMNS", false }
};
Modified: trunk/Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.h (200496 => 200497)
--- trunk/Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.h 2016-05-05 23:59:07 UTC (rev 200496)
+++ trunk/Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.h 2016-05-05 23:59:52 UTC (rev 200497)
@@ -37,6 +37,7 @@
class ExperimentalFeatures {
public:
enum Feature {
+ CSSGridLayout,
RegionBasedColumns
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
