Title: [200505] trunk/Source/WebInspectorUI
- Revision
- 200505
- Author
- [email protected]
- Date
- 2016-05-05 20:14:48 -0700 (Thu, 05 May 2016)
Log Message
REGRESSION(r200474): Exception in autocompletion - `getCompletions` not found
https://bugs.webkit.org/show_bug.cgi?id=157408
Patch by Joseph Pecoraro <[email protected]> on 2016-05-05
Reviewed by Timothy Hatcher.
* UserInterface/Controllers/_javascript_RuntimeCompletionProvider.js:
(WebInspector._javascript_RuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.evaluated):
This function was renamed, but this instance was missed.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (200504 => 200505)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-06 02:40:50 UTC (rev 200504)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-06 03:14:48 UTC (rev 200505)
@@ -1,5 +1,16 @@
2016-05-05 Joseph Pecoraro <[email protected]>
+ REGRESSION(r200474): Exception in autocompletion - `getCompletions` not found
+ https://bugs.webkit.org/show_bug.cgi?id=157408
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Controllers/_javascript_RuntimeCompletionProvider.js:
+ (WebInspector._javascript_RuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.evaluated):
+ This function was renamed, but this instance was missed.
+
+2016-05-05 Joseph Pecoraro <[email protected]>
+
Web Inspector: Provide go-to links next to Functions in GC Root Path popover
https://bugs.webkit.org/show_bug.cgi?id=157381
<rdar://problem/26122531>
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_RuntimeCompletionProvider.js (200504 => 200505)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_RuntimeCompletionProvider.js 2016-05-06 02:40:50 UTC (rev 200504)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_RuntimeCompletionProvider.js 2016-05-06 03:14:48 UTC (rev 200505)
@@ -186,7 +186,7 @@
else if (result.type === "object" || result.type === "function")
result.callFunctionJSON(inspectedPage_evalResult_getCompletions, undefined, receivedPropertyNames.bind(this));
else if (result.type === "string" || result.type === "number" || result.type === "boolean" || result.type === "symbol")
- WebInspector.runtimeManager.evaluateInInspectedWindow("(" + getCompletions + ")(\"" + result.type + "\")", "completion", false, true, true, false, false, receivedPropertyNamesFromEvaluate.bind(this));
+ WebInspector.runtimeManager.evaluateInInspectedWindow("(" + inspectedPage_evalResult_getCompletions + ")(\"" + result.type + "\")", "completion", false, true, true, false, false, receivedPropertyNamesFromEvaluate.bind(this));
else
console.error("Unknown result type: " + result.type);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
