Diff
Modified: trunk/LayoutTests/ChangeLog (200523 => 200524)
--- trunk/LayoutTests/ChangeLog 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/LayoutTests/ChangeLog 2016-05-06 21:21:20 UTC (rev 200524)
@@ -1,3 +1,18 @@
+2016-05-06 Dean Jackson <[email protected]>
+
+ Regions, Shapes and Tracks don't need runtime features
+ https://bugs.webkit.org/show_bug.cgi?id=157426
+ <rdar://problem/26146262>
+
+ Reviewed by Simon Fraser.
+
+ Remove these tests since their runtime flags no longer exist.
+
+ * fast/regions/css-regions-disabled-expected.txt: Removed.
+ * fast/regions/css-regions-disabled.html: Removed.
+ * fast/shapes/css-shapes-disabled-expected.txt: Removed.
+ * fast/shapes/css-shapes-disabled.html: Removed.
+
2016-05-06 Brady Eidson <[email protected]>
Unreviewed IDB test gardening.
Deleted: trunk/LayoutTests/fast/regions/css-regions-disabled-expected.txt (200523 => 200524)
--- trunk/LayoutTests/fast/regions/css-regions-disabled-expected.txt 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/LayoutTests/fast/regions/css-regions-disabled-expected.txt 2016-05-06 21:21:20 UTC (rev 200524)
@@ -1,22 +0,0 @@
-Test that parsing of css regions related properties is disabled by default.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS testWebKitFlowInto("-webkit-flow-into: none") is ""
-PASS testWebKitFlowInto("-webkit-flow-into: first-flow") is ""
-PASS testComputedStyleWebKitFlowInto("none") is "none"
-PASS testComputedStyleWebKitFlowInto("first-flow") is "none"
-PASS testWebKitFlowFrom("-webkit-flow-from: first-flow") is ""
-PASS testWebKitFlowFrom("-webkit-flow-from: none") is ""
-PASS testComputedStyleWebKitFlowFrom("first-flow") is "none"
-PASS testComputedStyleWebKitFlowFrom("none") is "none"
-PASS testWebKitRegionFragment("-webkit-region-fragment: auto") is ""
-PASS testWebKitRegionFragment("-webkit-region-fragment: break") is ""
-PASS testComputedStyleWebKitRegionFragment("auto") is "auto"
-PASS testComputedStyleWebKitRegionFragment("break") is "auto"
-PASS webkitRegionRuleIndex is -1
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/regions/css-regions-disabled.html (200523 => 200524)
--- trunk/LayoutTests/fast/regions/css-regions-disabled.html 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/LayoutTests/fast/regions/css-regions-disabled.html 2016-05-06 21:21:20 UTC (rev 200524)
@@ -1,10 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src=""
-</head>
-<body>
-<script src=""
-<script src=""
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/shapes/css-shapes-disabled-expected.txt (200523 => 200524)
--- trunk/LayoutTests/fast/shapes/css-shapes-disabled-expected.txt 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/LayoutTests/fast/shapes/css-shapes-disabled-expected.txt 2016-05-06 21:21:20 UTC (rev 200524)
@@ -1,13 +0,0 @@
-Test that parsing of css shapes related properties can be disabled.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS testInlineStyle("-webkit-shape-margin", "10px") is ""
-PASS testComputedStyle("-webkit-shape-margin", "10px") is "0px"
-PASS testInlineStyle("-webkit-shape-outside", "circle(10px at 10px 10px)") is ""
-PASS testComputedStyle("-webkit-shape-outside", "circle(10px at 10px 10px)") is "none"
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/shapes/css-shapes-disabled.html (200523 => 200524)
--- trunk/LayoutTests/fast/shapes/css-shapes-disabled.html 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/LayoutTests/fast/shapes/css-shapes-disabled.html 2016-05-06 21:21:20 UTC (rev 200524)
@@ -1,38 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<script src=""
-<script>
-
-description('Test that parsing of css shapes related properties can be disabled.');
-
-if (window.internals)
- window.internals.settings.setCSSShapesEnabled(false);
-
-function testInlineStyle(property, value) {
- var div = document.createElement("div");
- div.setAttribute("style", property + ": " + value);
- return div.style.getPropertyValue(property);
-}
-
-function testComputedStyle(property, value) {
- var div = document.createElement("div");
- document.body.appendChild(div);
- div.style.setProperty(property, value);
- var computedValue = getComputedStyle(div).getPropertyValue(property);
- document.body.removeChild(div);
- return computedValue;
-}
-
-function testStyle(property, value, computedExpected) {
- shouldBeEqualToString('testInlineStyle("' + property + '", "' + value + '")', '');
- shouldBeEqualToString('testComputedStyle("' + property + '", "' + value + '")', computedExpected);
-}
-
-testStyle("-webkit-shape-margin", "10px", "0px");
-testStyle("-webkit-shape-outside", "circle(10px at 10px 10px)", "none");
-
-</script>
-<script src=""
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (200523 => 200524)
--- trunk/Source/WebCore/ChangeLog 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/ChangeLog 2016-05-06 21:21:20 UTC (rev 200524)
@@ -1,3 +1,96 @@
+2016-05-06 Dean Jackson <[email protected]>
+
+ Regions, Shapes and Tracks don't need runtime features
+ https://bugs.webkit.org/show_bug.cgi?id=157426
+ <rdar://problem/26146262>
+
+ Reviewed by Simon Fraser.
+
+ The following RuntimeEnabledFeatures can be removed since
+ we have no need to disable them (they are stable and have
+ shipped for a while):
+ - CSS Regions
+ - CSS Shapes
+ - Media tracks
+
+ * bindings/generic/RuntimeEnabledFeatures.cpp:
+ (WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures): Deleted.
+ * bindings/generic/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::setCSSShapesEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::cssShapesEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::setCSSRegionsEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::cssRegionsEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::setCSSCompositingEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::cssCompositingEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::webkitVideoTrackEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::setWebkitVideoTrackEnabled): Deleted.
+ * css/CSSParser.cpp:
+ (WebCore::isSimpleLengthPropertyID):
+ (WebCore::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParser::parseValue):
+ (WebCore::CSSParser::parseFillProperty):
+ (WebCore::CSSParser::createRegionRule):
+ (WebCore::CSSParserContext::CSSParserContext): Deleted.
+ (WebCore::operator==): Deleted.
+ (WebCore::CSSParser::parseShapeProperty): Deleted.
+ (WebCore::CSSParser::cssRegionsEnabled): Deleted.
+ (WebCore::CSSParser::cssCompositingEnabled): Deleted.
+ (WebCore::CSSParser::parseFlowThread): Deleted.
+ (WebCore::CSSParser::parseRegionThread): Deleted.
+ * css/CSSParser.h:
+ * css/CSSParserMode.h:
+ * dom/Document.cpp:
+ (WebCore::Document::webkitGetNamedFlows):
+ (WebCore::Document::cssRegionsEnabled): Deleted.
+ (WebCore::Document::cssCompositingEnabled): Deleted.
+ * dom/Document.h:
+ * dom/Element.cpp:
+ (WebCore::Element::unregisterNamedFlowContentElement):
+ (WebCore::Element::webkitRegionOverset):
+ (WebCore::Element::webkitGetRegionFlowRanges): Deleted.
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::scheduleDelayedAction):
+ (WebCore::HTMLMediaElement::pendingActionTimerFired):
+ (WebCore::HTMLMediaElement::prepareForLoad):
+ (WebCore::HTMLMediaElement::loadInternal):
+ (WebCore::HTMLMediaElement::setReadyState):
+ (WebCore::HTMLMediaElement::playbackProgressTimerFired):
+ (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
+ (WebCore::HTMLMediaElement::userCancelledLoad):
+ (WebCore::HTMLMediaElement::setVideoFullscreenLayer):
+ (WebCore::HTMLMediaElement::hasClosedCaptions):
+ (WebCore::HTMLMediaElement::setClosedCaptionsVisible):
+ (WebCore::HTMLMediaElement::configureTextTrackDisplay):
+ (WebCore::HTMLMediaElement::finishParsingChildren): Deleted.
+ (WebCore::HTMLMediaElement::audioTrackEnabledChanged): Deleted.
+ (WebCore::HTMLMediaElement::videoTrackSelectedChanged): Deleted.
+ (WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack): Deleted.
+ (WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack): Deleted.
+ (WebCore::HTMLMediaElement::mediaPlayerDidAddVideoTrack): Deleted.
+ (WebCore::HTMLMediaElement::addAudioTrack): Deleted.
+ (WebCore::HTMLMediaElement::addTextTrack): Deleted.
+ (WebCore::HTMLMediaElement::addVideoTrack): Deleted.
+ (WebCore::HTMLMediaElement::removeAudioTrack): Deleted.
+ (WebCore::HTMLMediaElement::removeTextTrack): Deleted.
+ (WebCore::HTMLMediaElement::removeVideoTrack): Deleted.
+ (WebCore::HTMLMediaElement::audioTracks): Deleted.
+ (WebCore::HTMLMediaElement::textTracks): Deleted.
+ (WebCore::HTMLMediaElement::videoTracks): Deleted.
+ (WebCore::HTMLMediaElement::didAddTextTrack): Deleted.
+ (WebCore::HTMLMediaElement::didRemoveTextTrack): Deleted.
+ * html/HTMLTrackElement.cpp:
+ (WebCore::HTMLTrackElement::parseAttribute):
+ (WebCore::HTMLTrackElement::scheduleLoad): Deleted.
+ (WebCore::HTMLTrackElement::canLoadURL): Deleted.
+ * rendering/RenderBlockFlow.cpp:
+ (WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded):
+ * testing/InternalSettings.cpp:
+ (WebCore::InternalSettings::Backup::Backup):
+ (WebCore::InternalSettings::Backup::restoreTo): Deleted.
+ (WebCore::InternalSettings::setCSSShapesEnabled): Deleted.
+ * testing/InternalSettings.h:
+ * testing/InternalSettings.idl:
+
2016-05-06 Brady Eidson <[email protected]>
Modern IDB (Workers): Start running a lot of the workers tests.
Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (200523 => 200524)
--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2016-05-06 21:21:20 UTC (rev 200524)
@@ -50,9 +50,6 @@
, m_isDeviceMotionEnabled(true)
, m_isDeviceOrientationEnabled(true)
, m_isLinkPreloadEnabled(false)
- , m_isCSSShapesEnabled(true)
- , m_isCSSRegionsEnabled(false)
- , m_isCSSCompositingEnabled(false)
, m_isLangAttributeAwareFormControlUIEnabled(false)
#if PLATFORM(IOS)
, m_isPluginReplacementEnabled(true)
@@ -78,9 +75,6 @@
#if ENABLE(_javascript__I18N_API)
, m_isJavaScriptI18NAPIEnabled(false)
#endif
-#if ENABLE(VIDEO_TRACK)
- , m_isVideoTrackEnabled(true)
-#endif
#if ENABLE(INPUT_TYPE_DATE)
, m_isInputTypeDateEnabled(true)
#endif
Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (200523 => 200524)
--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-05-06 21:21:20 UTC (rev 200524)
@@ -72,25 +72,6 @@
bool indexedDBWorkersEnabled() const { return m_isIndexedDBWorkersEnabled; }
#endif
-#if ENABLE(CSS_SHAPES)
- void setCSSShapesEnabled(bool isEnabled) { m_isCSSShapesEnabled = isEnabled; }
- bool cssShapesEnabled() const { return m_isCSSShapesEnabled; }
-#else
- void setCSSShapesEnabled(bool) { }
- bool cssShapesEnabled() const { return false; }
-#endif
-
-#if ENABLE(CSS_REGIONS)
- void setCSSRegionsEnabled(bool isEnabled) { m_isCSSRegionsEnabled = isEnabled; }
- bool cssRegionsEnabled() const { return m_isCSSRegionsEnabled; }
-#else
- void setCSSRegionsEnabled(bool) { }
- bool cssRegionsEnabled() const { return false; }
-#endif
-
- void setCSSCompositingEnabled(bool isEnabled) { m_isCSSCompositingEnabled = isEnabled; }
- bool cssCompositingEnabled() const { return m_isCSSCompositingEnabled; }
-
#if ENABLE(FONT_LOAD_EVENTS)
void setFontLoadEventsEnabled(bool isEnabled) { m_isFontLoadEventsEnabled = isEnabled; }
bool fontLoadEventsEnabled() const { return m_isFontLoadEventsEnabled; }
@@ -154,11 +135,6 @@
bool legacyCSSVendorPrefixesEnabled() const { return m_isLegacyCSSVendorPrefixesEnabled; }
#endif
-#if ENABLE(VIDEO_TRACK)
- bool webkitVideoTrackEnabled() const { return m_isVideoTrackEnabled; }
- void setWebkitVideoTrackEnabled(bool isEnabled) { m_isVideoTrackEnabled = isEnabled; }
-#endif
-
#if ENABLE(INPUT_TYPE_DATE)
bool inputTypeDateEnabled() const { return m_isInputTypeDateEnabled; }
void setInputTypeDateEnabled(bool isEnabled) { m_isInputTypeDateEnabled = isEnabled; }
@@ -265,9 +241,6 @@
bool m_isDeviceMotionEnabled;
bool m_isDeviceOrientationEnabled;
bool m_isLinkPreloadEnabled;
- bool m_isCSSShapesEnabled;
- bool m_isCSSRegionsEnabled;
- bool m_isCSSCompositingEnabled;
bool m_isLangAttributeAwareFormControlUIEnabled;
bool m_isPluginReplacementEnabled;
bool m_isResourceTimingEnabled;
@@ -295,10 +268,6 @@
bool m_isLegacyCSSVendorPrefixesEnabled;
#endif
-#if ENABLE(VIDEO_TRACK)
- bool m_isVideoTrackEnabled;
-#endif
-
#if ENABLE(INPUT_TYPE_DATE)
bool m_isInputTypeDateEnabled;
#endif
Modified: trunk/Source/WebCore/css/CSSParser.cpp (200523 => 200524)
--- trunk/Source/WebCore/css/CSSParser.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2016-05-06 21:21:20 UTC (rev 200524)
@@ -246,8 +246,6 @@
: baseURL(baseURL)
, mode(mode)
, isHTMLDocument(false)
- , isCSSRegionsEnabled(RuntimeEnabledFeatures::sharedFeatures().cssRegionsEnabled())
- , isCSSCompositingEnabled(RuntimeEnabledFeatures::sharedFeatures().cssCompositingEnabled())
#if ENABLE(CSS_GRID_LAYOUT)
, cssGridLayoutEnabled(RuntimeEnabledFeatures::sharedFeatures().isCSSGridLayoutEnabled())
#endif
@@ -268,8 +266,6 @@
, charset(charset)
, mode(document.inQuirksMode() ? CSSQuirksMode : CSSStrictMode)
, isHTMLDocument(document.isHTMLDocument())
- , isCSSRegionsEnabled(document.cssRegionsEnabled())
- , isCSSCompositingEnabled(document.cssCompositingEnabled())
#if ENABLE(CSS_GRID_LAYOUT)
, cssGridLayoutEnabled(document.isCSSGridLayoutEnabled())
#endif
@@ -291,8 +287,6 @@
&& a.charset == b.charset
&& a.mode == b.mode
&& a.isHTMLDocument == b.isHTMLDocument
- && a.isCSSRegionsEnabled == b.isCSSRegionsEnabled
- && a.isCSSCompositingEnabled == b.isCSSCompositingEnabled
#if ENABLE(CSS_GRID_LAYOUT)
&& a.cssGridLayoutEnabled == b.cssGridLayoutEnabled
#endif
@@ -552,13 +546,11 @@
case CSSPropertyGridColumnGap:
case CSSPropertyGridRowGap:
#endif
- acceptsNegativeNumbers = false;
- return true;
#if ENABLE(CSS_SHAPES)
case CSSPropertyWebkitShapeMargin:
- acceptsNegativeNumbers = false;
- return RuntimeEnabledFeatures::sharedFeatures().cssShapesEnabled();
#endif
+ acceptsNegativeNumbers = false;
+ return true;
case CSSPropertyBottom:
case CSSPropertyCx:
case CSSPropertyCy:
@@ -821,14 +813,14 @@
break;
#if ENABLE(CSS_COMPOSITING)
case CSSPropertyMixBlendMode:
- if (parserContext.isCSSCompositingEnabled && (valueID == CSSValueNormal || valueID == CSSValueMultiply || valueID == CSSValueScreen
+ if (valueID == CSSValueNormal || valueID == CSSValueMultiply || valueID == CSSValueScreen
|| valueID == CSSValueOverlay || valueID == CSSValueDarken || valueID == CSSValueLighten || valueID == CSSValueColorDodge
|| valueID == CSSValueColorBurn || valueID == CSSValueHardLight || valueID == CSSValueSoftLight || valueID == CSSValueDifference
- || valueID == CSSValueExclusion || valueID == CSSValuePlusDarker || valueID == CSSValuePlusLighter))
+ || valueID == CSSValueExclusion || valueID == CSSValuePlusDarker || valueID == CSSValuePlusLighter)
return true;
break;
case CSSPropertyIsolation:
- if (parserContext.isCSSCompositingEnabled && (valueID == CSSValueAuto || valueID == CSSValueIsolate))
+ if (valueID == CSSValueAuto || valueID == CSSValueIsolate)
return true;
break;
#endif
@@ -931,15 +923,15 @@
#if ENABLE(CSS_REGIONS)
case CSSPropertyWebkitRegionBreakAfter:
case CSSPropertyWebkitRegionBreakBefore:
- if (parserContext.isCSSRegionsEnabled && (valueID == CSSValueAuto || valueID == CSSValueAlways || valueID == CSSValueAvoid || valueID == CSSValueLeft || valueID == CSSValueRight))
+ if (valueID == CSSValueAuto || valueID == CSSValueAlways || valueID == CSSValueAvoid || valueID == CSSValueLeft || valueID == CSSValueRight)
return true;
break;
case CSSPropertyWebkitRegionBreakInside:
- if (parserContext.isCSSRegionsEnabled && (valueID == CSSValueAuto || valueID == CSSValueAvoid))
+ if (valueID == CSSValueAuto || valueID == CSSValueAvoid)
return true;
break;
case CSSPropertyWebkitRegionFragment:
- if (parserContext.isCSSRegionsEnabled && (valueID == CSSValueAuto || valueID == CSSValueBreak))
+ if (valueID == CSSValueAuto || valueID == CSSValueBreak)
return true;
break;
#endif
@@ -2624,12 +2616,10 @@
break;
#if ENABLE(CSS_COMPOSITING)
case CSSPropertyMixBlendMode:
- if (cssCompositingEnabled())
- validPrimitive = true;
+ validPrimitive = true;
break;
case CSSPropertyIsolation:
- if (cssCompositingEnabled())
- validPrimitive = true;
+ validPrimitive = true;
break;
#endif
case CSSPropertyFlex: {
@@ -2683,12 +2673,8 @@
break;
#if ENABLE(CSS_REGIONS)
case CSSPropertyWebkitFlowInto:
- if (!cssRegionsEnabled())
- return false;
return parseFlowThread(propId, important);
case CSSPropertyWebkitFlowFrom:
- if (!cssRegionsEnabled())
- return false;
return parseRegionThread(propId, important);
#endif
case CSSPropertyTransform:
@@ -3186,10 +3172,10 @@
parsedValue = parseShapeProperty(propId);
break;
case CSSPropertyWebkitShapeMargin:
- validPrimitive = (RuntimeEnabledFeatures::sharedFeatures().cssShapesEnabled() && !id && validateUnit(valueWithCalculation, FLength | FPercent | FNonNeg));
+ validPrimitive = !id && validateUnit(valueWithCalculation, FLength | FPercent | FNonNeg);
break;
case CSSPropertyWebkitShapeImageThreshold:
- validPrimitive = (RuntimeEnabledFeatures::sharedFeatures().cssShapesEnabled() && !id && validateUnit(valueWithCalculation, FNumber));
+ validPrimitive = !id && validateUnit(valueWithCalculation, FNumber);
break;
#endif
#if ENABLE(CSS_IMAGE_ORIENTATION)
@@ -4975,11 +4961,11 @@
}
break;
case CSSPropertyBackgroundBlendMode:
- if (cssCompositingEnabled() && (currentValue->id == CSSValueNormal || currentValue->id == CSSValueMultiply
+ if (currentValue->id == CSSValueNormal || currentValue->id == CSSValueMultiply
|| currentValue->id == CSSValueScreen || currentValue->id == CSSValueOverlay || currentValue->id == CSSValueDarken
|| currentValue->id == CSSValueLighten || currentValue->id == CSSValueColorDodge || currentValue->id == CSSValueColorBurn
|| currentValue->id == CSSValueHardLight || currentValue->id == CSSValueSoftLight || currentValue->id == CSSValueDifference
- || currentValue->id == CSSValueExclusion)) {
+ || currentValue->id == CSSValueExclusion) {
currValue = CSSValuePool::singleton().createIdentifierValue(currentValue->id);
m_valueList->next();
}
@@ -6874,9 +6860,6 @@
#if ENABLE(CSS_SHAPES)
RefPtr<CSSValue> CSSParser::parseShapeProperty(CSSPropertyID propId)
{
- if (!RuntimeEnabledFeatures::sharedFeatures().cssShapesEnabled())
- return nullptr;
-
CSSParserValue& value = *m_valueList->current();
CSSValueID valueId = value.id;
@@ -10267,16 +10250,6 @@
}
#endif
-bool CSSParser::cssRegionsEnabled() const
-{
- return m_context.isCSSRegionsEnabled;
-}
-
-bool CSSParser::cssCompositingEnabled() const
-{
- return m_context.isCSSCompositingEnabled;
-}
-
#if ENABLE(CSS_GRID_LAYOUT)
bool CSSParser::isCSSGridLayoutEnabled() const
{
@@ -10290,7 +10263,6 @@
bool CSSParser::parseFlowThread(CSSPropertyID propId, bool important)
{
ASSERT(propId == CSSPropertyWebkitFlowInto);
- ASSERT(cssRegionsEnabled());
if (m_valueList->size() != 1)
return false;
@@ -10322,7 +10294,6 @@
bool CSSParser::parseRegionThread(CSSPropertyID propId, bool important)
{
ASSERT(propId == CSSPropertyWebkitFlowFrom);
- ASSERT(cssRegionsEnabled());
if (m_valueList->size() != 1)
return false;
@@ -13197,7 +13168,7 @@
RefPtr<StyleRuleBase> CSSParser::createRegionRule(Vector<std::unique_ptr<CSSParserSelector>>* regionSelector, RuleList* rules)
{
- if (!cssRegionsEnabled() || !regionSelector || !rules) {
+ if (!regionSelector || !rules) {
popRuleData();
return nullptr;
}
Modified: trunk/Source/WebCore/css/CSSParser.h (200523 => 200524)
--- trunk/Source/WebCore/css/CSSParser.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/css/CSSParser.h 2016-05-06 21:21:20 UTC (rev 200524)
@@ -348,8 +348,6 @@
bool parseFontFeatureTag(CSSValueList&);
bool parseFontFeatureSettings(bool important);
- bool cssRegionsEnabled() const;
- bool cssCompositingEnabled() const;
bool parseFlowThread(CSSPropertyID, bool important);
bool parseRegionThread(CSSPropertyID, bool important);
Modified: trunk/Source/WebCore/css/CSSParserMode.h (200523 => 200524)
--- trunk/Source/WebCore/css/CSSParserMode.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/css/CSSParserMode.h 2016-05-06 21:21:20 UTC (rev 200524)
@@ -64,8 +64,6 @@
String charset;
CSSParserMode mode;
bool isHTMLDocument;
- bool isCSSRegionsEnabled;
- bool isCSSCompositingEnabled;
#if ENABLE(CSS_GRID_LAYOUT)
bool cssGridLayoutEnabled;
#endif
Modified: trunk/Source/WebCore/dom/Document.cpp (200523 => 200524)
--- trunk/Source/WebCore/dom/Document.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/dom/Document.cpp 2016-05-06 21:21:20 UTC (rev 200524)
@@ -1128,16 +1128,6 @@
return element.releaseNonNull();
}
-bool Document::cssRegionsEnabled() const
-{
- return RuntimeEnabledFeatures::sharedFeatures().cssRegionsEnabled();
-}
-
-bool Document::cssCompositingEnabled() const
-{
- return RuntimeEnabledFeatures::sharedFeatures().cssCompositingEnabled();
-}
-
#if ENABLE(CSS_GRID_LAYOUT)
bool Document::isCSSGridLayoutEnabled() const
{
@@ -1146,17 +1136,15 @@
#endif
#if ENABLE(CSS_REGIONS)
-
RefPtr<DOMNamedFlowCollection> Document::webkitGetNamedFlows()
{
- if (!cssRegionsEnabled() || !renderView())
+ if (!renderView())
return nullptr;
updateStyleIfNeeded();
return namedFlows().createCSSOMSnapshot();
}
-
#endif
NamedFlowCollection& Document::namedFlows()
Modified: trunk/Source/WebCore/dom/Document.h (200523 => 200524)
--- trunk/Source/WebCore/dom/Document.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/dom/Document.h 2016-05-06 21:21:20 UTC (rev 200524)
@@ -392,8 +392,6 @@
WEBCORE_EXPORT RefPtr<Element> createElementNS(const String& namespaceURI, const String& qualifiedName, ExceptionCode&);
WEBCORE_EXPORT Ref<Element> createElement(const QualifiedName&, bool createdByParser);
- bool cssRegionsEnabled() const;
- bool cssCompositingEnabled() const;
#if ENABLE(CSS_GRID_LAYOUT)
bool isCSSGridLayoutEnabled() const;
#endif
Modified: trunk/Source/WebCore/dom/Element.cpp (200523 => 200524)
--- trunk/Source/WebCore/dom/Element.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/dom/Element.cpp 2016-05-06 21:21:20 UTC (rev 200524)
@@ -1614,7 +1614,7 @@
void Element::unregisterNamedFlowContentElement()
{
- if (document().cssRegionsEnabled() && isNamedFlowContentNode() && document().renderView())
+ if (isNamedFlowContentNode() && document().renderView())
document().renderView()->flowThreadController().unregisterNamedFlowContentElement(*this);
}
@@ -2930,7 +2930,7 @@
document().updateLayoutIgnorePendingStylesheets();
static NeverDestroyed<AtomicString> undefinedState("undefined", AtomicString::ConstructFromLiteral);
- if (!document().cssRegionsEnabled() || !renderNamedFlowFragment())
+ if (!renderNamedFlowFragment())
return undefinedState;
switch (regionOversetState()) {
@@ -2957,9 +2957,6 @@
Vector<RefPtr<Range>> Element::webkitGetRegionFlowRanges() const
{
Vector<RefPtr<Range>> rangeObjects;
- if (!document().cssRegionsEnabled())
- return rangeObjects;
-
document().updateLayoutIgnorePendingStylesheets();
if (renderer() && renderer()->isRenderNamedFlowFragmentContainer()) {
RenderNamedFlowFragment& namedFlowFragment = *downcast<RenderBlockFlow>(*renderer()).renderNamedFlowFragment();
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (200523 => 200524)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2016-05-06 21:21:20 UTC (rev 200524)
@@ -719,9 +719,6 @@
m_parsingInProgress = false;
#if ENABLE(VIDEO_TRACK)
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
if (descendantsOfType<HTMLTrackElement>(*this).first())
scheduleDelayedAction(ConfigureTextTracks);
#endif
@@ -864,7 +861,7 @@
}
#if ENABLE(VIDEO_TRACK)
- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled() && (actionType & ConfigureTextTracks))
+ if (actionType & ConfigureTextTracks)
setFlags(m_pendingActionFlags, ConfigureTextTracks);
#endif
@@ -910,7 +907,7 @@
m_pendingActionFlags = 0;
#if ENABLE(VIDEO_TRACK)
- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled() && (pendingActions & ConfigureTextTracks))
+ if (pendingActions & ConfigureTextTracks)
configureTextTracks();
#endif
@@ -1099,8 +1096,7 @@
updateMediaController();
#if ENABLE(VIDEO_TRACK)
- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- updateActiveTextTrackCues(MediaTime::zeroTime());
+ updateActiveTextTrackCues(MediaTime::zeroTime());
#endif
}
@@ -1176,14 +1172,12 @@
// HTMLMediaElement::textTracksAreReady will need "... the text tracks whose mode was not in the
// disabled state when the element's resource selection algorithm last started".
- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled()) {
- m_textTracksWhenResourceSelectionBegan.clear();
- if (m_textTracks) {
- for (unsigned i = 0; i < m_textTracks->length(); ++i) {
- TextTrack* track = m_textTracks->item(i);
- if (track->mode() != TextTrack::Mode::Disabled)
- m_textTracksWhenResourceSelectionBegan.append(track);
- }
+ m_textTracksWhenResourceSelectionBegan.clear();
+ if (m_textTracks) {
+ for (unsigned i = 0; i < m_textTracks->length(); ++i) {
+ TextTrack* track = m_textTracks->item(i);
+ if (track->mode() != TextTrack::Mode::Disabled)
+ m_textTracksWhenResourceSelectionBegan.append(track);
}
}
#endif
@@ -1711,8 +1705,6 @@
void HTMLMediaElement::audioTrackEnabledChanged(AudioTrack* track)
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
if (m_audioTracks && m_audioTracks->contains(track))
m_audioTracks->scheduleChangeEvent();
}
@@ -1754,8 +1746,6 @@
void HTMLMediaElement::videoTrackSelectedChanged(VideoTrack* track)
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
if (m_videoTracks && m_videoTracks->contains(track))
m_videoTracks->scheduleChangeEvent();
}
@@ -2161,7 +2151,7 @@
ReadyState newState = static_cast<ReadyState>(state);
#if ENABLE(VIDEO_TRACK)
- bool tracksAreReady = !RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled() || textTracksAreReady();
+ bool tracksAreReady = textTracksAreReady();
if (newState == oldState && m_tracksAreReady == tracksAreReady)
return;
@@ -2283,8 +2273,7 @@
updatePlayState();
updateMediaController();
#if ENABLE(VIDEO_TRACK)
- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- updateActiveTextTrackCues(currentMediaTime());
+ updateActiveTextTrackCues(currentMediaTime());
#endif
}
@@ -3425,8 +3414,7 @@
mediaControls()->playbackProgressed();
#if ENABLE(VIDEO_TRACK)
- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- updateActiveTextTrackCues(currentMediaTime());
+ updateActiveTextTrackCues(currentMediaTime());
#endif
#if ENABLE(MEDIA_SOURCE)
@@ -3486,17 +3474,11 @@
if (isPlaying() && !m_mediaSession->playbackPermitted(*this))
pauseInternal();
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
addAudioTrack(AudioTrack::create(this, prpTrack));
}
void HTMLMediaElement::mediaPlayerDidAddTextTrack(PassRefPtr<InbandTextTrackPrivate> prpTrack)
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
// 4.8.10.12.2 Sourcing in-band text tracks
// 1. Associate the relevant data with a new text track and its corresponding new TextTrack object.
RefPtr<InbandTextTrack> textTrack = InbandTextTrack::create(ActiveDOMObject::scriptExecutionContext(), this, prpTrack);
@@ -3530,9 +3512,6 @@
void HTMLMediaElement::mediaPlayerDidAddVideoTrack(PassRefPtr<VideoTrackPrivate> prpTrack)
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
addVideoTrack(VideoTrack::create(this, prpTrack));
}
@@ -3559,17 +3538,11 @@
void HTMLMediaElement::addAudioTrack(PassRefPtr<AudioTrack> track)
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
audioTracks()->append(track);
}
void HTMLMediaElement::addTextTrack(PassRefPtr<TextTrack> track)
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
if (!m_requireCaptionPreferencesChangedCallbacks) {
m_requireCaptionPreferencesChangedCallbacks = true;
Document& document = this->document();
@@ -3585,25 +3558,16 @@
void HTMLMediaElement::addVideoTrack(PassRefPtr<VideoTrack> track)
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
videoTracks()->append(track);
}
void HTMLMediaElement::removeAudioTrack(AudioTrack* track)
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
m_audioTracks->remove(track);
}
void HTMLMediaElement::removeTextTrack(TextTrack* track, bool scheduleEvent)
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
TrackDisplayUpdateScope scope(this);
if (TextTrackCueList* cues = track->cues())
textTrackRemoveCues(track, cues);
@@ -3616,9 +3580,6 @@
void HTMLMediaElement::removeVideoTrack(VideoTrack* track)
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
m_videoTracks->remove(track);
}
@@ -3643,9 +3604,6 @@
PassRefPtr<TextTrack> HTMLMediaElement::addTextTrack(const String& kind, const String& label, const String& language, ExceptionCode& ec)
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return 0;
-
// 4.8.10.12.4 Text track API
// The addTextTrack(kind, label, language) method of media elements, when invoked, must run the following steps:
@@ -3680,9 +3638,6 @@
AudioTrackList* HTMLMediaElement::audioTracks()
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return 0;
-
if (!m_audioTracks)
m_audioTracks = AudioTrackList::create(this, ActiveDOMObject::scriptExecutionContext());
@@ -3691,9 +3646,6 @@
TextTrackList* HTMLMediaElement::textTracks()
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return 0;
-
if (!m_textTracks)
m_textTracks = TextTrackList::create(this, ActiveDOMObject::scriptExecutionContext());
@@ -3702,9 +3654,6 @@
VideoTrackList* HTMLMediaElement::videoTracks()
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return 0;
-
if (!m_videoTracks)
m_videoTracks = VideoTrackList::create(this, ActiveDOMObject::scriptExecutionContext());
@@ -3715,9 +3664,6 @@
{
ASSERT(trackElement->hasTagName(trackTag));
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
// 4.8.10.12.3 Sourcing out-of-band text tracks
// When a track element's parent element changes and the new parent is a media element,
// then the user agent must add the track element's corresponding text track to the
@@ -3741,9 +3687,6 @@
{
ASSERT(trackElement->hasTagName(trackTag));
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
#if !LOG_DISABLED
if (trackElement->hasTagName(trackTag)) {
URL url = ""
@@ -4321,8 +4264,7 @@
LOG(Media, "HTMLMediaElement::mediaPlayerTimeChanged(%p)", this);
#if ENABLE(VIDEO_TRACK)
- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- updateActiveTextTrackCues(currentMediaTime());
+ updateActiveTextTrackCues(currentMediaTime());
#endif
beginProcessingMediaPlayerCallback();
@@ -4967,8 +4909,7 @@
m_readyState = HAVE_NOTHING;
updateMediaController();
#if ENABLE(VIDEO_TRACK)
- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- updateActiveTextTrackCues(MediaTime::zeroTime());
+ updateActiveTextTrackCues(MediaTime::zeroTime());
#endif
}
@@ -5469,8 +5410,7 @@
m_player->setVideoFullscreenLayer(platformLayer);
setNeedsStyleRecalc(SyntheticStyleChange);
#if ENABLE(VIDEO_TRACK)
- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- updateTextTrackDisplay();
+ updateTextTrackDisplay();
#endif
}
@@ -5496,7 +5436,7 @@
return true;
#if ENABLE(VIDEO_TRACK)
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled() || !m_textTracks)
+ if (!m_textTracks)
return false;
for (unsigned i = 0; i < m_textTracks->length(); ++i) {
@@ -5547,10 +5487,8 @@
m_player->setClosedCaptionsVisible(closedCaptionVisible);
#if ENABLE(VIDEO_TRACK)
- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled()) {
- markCaptionAndSubtitleTracksAsUnconfigured(Immediately);
- updateTextTrackDisplay();
- }
+ markCaptionAndSubtitleTracksAsUnconfigured(Immediately);
+ updateTextTrackDisplay();
#else
if (hasMediaControls())
mediaControls()->changedClosedCaptionsVisibility();
@@ -5797,10 +5735,8 @@
mediaControls()->changedClosedCaptionsVisibility();
- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled()) {
- updateTextTrackDisplay();
- updateActiveTextTrackCues(currentMediaTime());
- }
+ updateTextTrackDisplay();
+ updateActiveTextTrackCues(currentMediaTime());
#endif
}
Modified: trunk/Source/WebCore/html/HTMLTrackElement.cpp (200523 => 200524)
--- trunk/Source/WebCore/html/HTMLTrackElement.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/html/HTMLTrackElement.cpp 2016-05-06 21:21:20 UTC (rev 200524)
@@ -92,24 +92,22 @@
void HTMLTrackElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled()) {
- if (name == srcAttr) {
- if (!value.isEmpty())
- scheduleLoad();
- else if (m_track)
- m_track->removeAllCues();
+ if (name == srcAttr) {
+ if (!value.isEmpty())
+ scheduleLoad();
+ else if (m_track)
+ m_track->removeAllCues();
- // 4.8.10.12.3 Sourcing out-of-band text tracks
- // As the kind, label, and srclang attributes are set, changed, or removed, the text track must update accordingly...
- } else if (name == kindAttr)
- ensureTrack().setKindKeywordIgnoringASCIICase(value.string());
- else if (name == labelAttr)
- ensureTrack().setLabel(value);
- else if (name == srclangAttr)
- ensureTrack().setLanguage(value);
- else if (name == defaultAttr)
- ensureTrack().setIsDefault(!value.isNull());
- }
+ // 4.8.10.12.3 Sourcing out-of-band text tracks
+ // As the kind, label, and srclang attributes are set, changed, or removed, the text track must update accordingly...
+ } else if (name == kindAttr)
+ ensureTrack().setKindKeywordIgnoringASCIICase(value.string());
+ else if (name == labelAttr)
+ ensureTrack().setLabel(value);
+ else if (name == srclangAttr)
+ ensureTrack().setLanguage(value);
+ else if (name == defaultAttr)
+ ensureTrack().setIsDefault(!value.isNull());
HTMLElement::parseAttribute(name, value);
}
@@ -170,9 +168,6 @@
if (m_loadTimer.isActive())
return;
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
// 2. If the text track's text track mode is not set to one of hidden or showing, abort these steps.
if (ensureTrack().mode() != TextTrack::Mode::Hidden && ensureTrack().mode() != TextTrack::Mode::Showing)
return;
@@ -208,9 +203,6 @@
bool HTMLTrackElement::canLoadURL(const URL& url)
{
- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return false;
-
HTMLMediaElement* parent = mediaElement();
if (!parent)
return false;
Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (200523 => 200524)
--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2016-05-06 21:21:20 UTC (rev 200524)
@@ -3142,7 +3142,7 @@
void RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded()
{
- if (!document().cssRegionsEnabled() || renderNamedFlowFragment() || isRenderNamedFlowFragment())
+ if (renderNamedFlowFragment() || isRenderNamedFlowFragment())
return;
// FIXME: Multicolumn regions not yet supported (http://dev.w3.org/csswg/css-regions/#multi-column-regions)
Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (200523 => 200524)
--- trunk/Source/WebCore/testing/InternalSettings.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp 2016-05-06 21:21:20 UTC (rev 200524)
@@ -66,8 +66,7 @@
namespace WebCore {
InternalSettings::Backup::Backup(Settings& settings)
- : m_originalCSSShapesEnabled(RuntimeEnabledFeatures::sharedFeatures().cssShapesEnabled())
- , m_originalEditingBehavior(settings.editingBehaviorType())
+ : m_originalEditingBehavior(settings.editingBehaviorType())
#if ENABLE(TEXT_AUTOSIZING)
, m_originalTextAutosizingEnabled(settings.textAutosizingEnabled())
, m_originalTextAutosizingWindowSizeOverride(settings.textAutosizingWindowSizeOverride())
@@ -113,7 +112,6 @@
void InternalSettings::Backup::restoreTo(Settings& settings)
{
- RuntimeEnabledFeatures::sharedFeatures().setCSSShapesEnabled(m_originalCSSShapesEnabled);
settings.setEditingBehaviorType(m_originalEditingBehavior);
for (const auto& standardFont : m_standardFontFamilies)
@@ -365,12 +363,6 @@
#endif
}
-void InternalSettings::setCSSShapesEnabled(bool enabled, ExceptionCode& ec)
-{
- UNUSED_PARAM(ec);
- RuntimeEnabledFeatures::sharedFeatures().setCSSShapesEnabled(enabled);
-}
-
void InternalSettings::setCanStartMedia(bool enabled, ExceptionCode& ec)
{
InternalSettingsGuardForSettings();
Modified: trunk/Source/WebCore/testing/InternalSettings.h (200523 => 200524)
--- trunk/Source/WebCore/testing/InternalSettings.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/testing/InternalSettings.h 2016-05-06 21:21:20 UTC (rev 200524)
@@ -53,7 +53,6 @@
explicit Backup(Settings&);
void restoreTo(Settings&);
- bool m_originalCSSShapesEnabled;
EditingBehaviorType m_originalEditingBehavior;
// Initially empty, only used if changed by a test.
@@ -131,7 +130,6 @@
void setTextAutosizingWindowSizeOverride(int width, int height, ExceptionCode&);
void setTextAutosizingFontScaleFactor(float fontScaleFactor, ExceptionCode&);
void setMediaTypeOverride(const String& mediaType, ExceptionCode&);
- void setCSSShapesEnabled(bool, ExceptionCode&);
void setCanStartMedia(bool, ExceptionCode&);
void setWirelessPlaybackDisabled(bool);
void setEditingBehavior(const String&, ExceptionCode&);
Modified: trunk/Source/WebCore/testing/InternalSettings.idl (200523 => 200524)
--- trunk/Source/WebCore/testing/InternalSettings.idl 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/testing/InternalSettings.idl 2016-05-06 21:21:20 UTC (rev 200524)
@@ -45,9 +45,6 @@
[RaisesException] void setTextAutosizingWindowSizeOverride(long width, long height);
[RaisesException] void setTextAutosizingFontScaleFactor(unrestricted float fontScaleFactor);
- // Features
- [RaisesException] void setCSSShapesEnabled(boolean enabled);
-
// Media
[RaisesException] void setCanStartMedia(boolean enabled);
[Conditional=VIDEO_TRACK, RaisesException] void setShouldDisplayTrackKind(DOMString kind, boolean enabled);
Modified: trunk/Source/WebKit/mac/ChangeLog (200523 => 200524)
--- trunk/Source/WebKit/mac/ChangeLog 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-05-06 21:21:20 UTC (rev 200524)
@@ -1,3 +1,29 @@
+2016-05-06 Dean Jackson <[email protected]>
+
+ Regions, Shapes and Tracks don't need runtime features
+ https://bugs.webkit.org/show_bug.cgi?id=157426
+ <rdar://problem/26146262>
+
+ Reviewed by Simon Fraser.
+
+ The following RuntimeEnabledFeatures can be removed since
+ we have no need to disable them (they are stable and have
+ shipped for a while):
+ - CSS Regions
+ - CSS Shapes
+ - Media tracks
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]): Deleted.
+ (-[WebPreferences cssRegionsEnabled]): Deleted.
+ (-[WebPreferences setCSSRegionsEnabled:]): Deleted.
+ (-[WebPreferences cssCompositingEnabled]): Deleted.
+ (-[WebPreferences setCSSCompositingEnabled:]): Deleted.
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]): Deleted.
+
2016-05-06 Daniel Bates <[email protected]>
Remove workaround for Apple Internal bots
Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (200523 => 200524)
--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-05-06 21:21:20 UTC (rev 200524)
@@ -102,8 +102,6 @@
#define WebKitDisplayListDrawingEnabledPreferenceKey @"WebKitDisplayListDrawingEnabled"
#define WebKitCanvasUsesAcceleratedDrawingPreferenceKey @"WebKitCanvasUsesAcceleratedDrawing"
#define WebKitAcceleratedCompositingEnabledPreferenceKey @"WebKitAcceleratedCompositingEnabled"
-#define WebKitCSSRegionsEnabledPreferenceKey @"WebKitCSSRegionsEnabled"
-#define WebKitCSSCompositingEnabledPreferenceKey @"WebKitCSSCompositingEnabled"
#define WebKitShowDebugBordersPreferenceKey @"WebKitShowDebugBorders"
#define WebKitSimpleLineLayoutDebugBordersEnabledPreferenceKey @"WebKitSimpleLineLayoutDebugBordersEnabled"
#define WebKitShowRepaintCounterPreferenceKey @"WebKitShowRepaintCounter"
Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (200523 => 200524)
--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-05-06 21:21:20 UTC (rev 200524)
@@ -490,8 +490,6 @@
[NSNumber numberWithBool:NO], WebKitJavaScriptCanAccessClipboardPreferenceKey,
[NSNumber numberWithBool:YES], WebKitXSSAuditorEnabledPreferenceKey,
[NSNumber numberWithBool:YES], WebKitAcceleratedCompositingEnabledPreferenceKey,
- [NSNumber numberWithBool:YES], WebKitCSSRegionsEnabledPreferenceKey,
- [NSNumber numberWithBool:YES], WebKitCSSCompositingEnabledPreferenceKey,
[NSNumber numberWithBool:NO], WebKitDisplayListDrawingEnabledPreferenceKey,
#if PLATFORM(IOS) && !PLATFORM(IOS_SIMULATOR)
[NSNumber numberWithBool:YES], WebKitAcceleratedDrawingEnabledPreferenceKey,
@@ -1880,26 +1878,6 @@
[self _setBoolValue:enabled forKey:WebKitAcceleratedCompositingEnabledPreferenceKey];
}
-- (BOOL)cssRegionsEnabled
-{
- return [self _boolValueForKey:WebKitCSSRegionsEnabledPreferenceKey];
-}
-
-- (void)setCSSRegionsEnabled:(BOOL)enabled
-{
- [self _setBoolValue:enabled forKey:WebKitCSSRegionsEnabledPreferenceKey];
-}
-
-- (BOOL)cssCompositingEnabled
-{
- return [self _boolValueForKey:WebKitCSSCompositingEnabledPreferenceKey];
-}
-
-- (void)setCSSCompositingEnabled:(BOOL)enabled
-{
- [self _setBoolValue:enabled forKey:WebKitCSSCompositingEnabledPreferenceKey];
-}
-
- (BOOL)showDebugBorders
{
return [self _boolValueForKey:WebKitShowDebugBordersPreferenceKey];
Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (200523 => 200524)
--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-05-06 21:21:20 UTC (rev 200524)
@@ -212,12 +212,6 @@
- (BOOL)acceleratedCompositingEnabled;
- (void)setAcceleratedCompositingEnabled:(BOOL)enabled;
-- (BOOL)cssRegionsEnabled;
-- (void)setCSSRegionsEnabled:(BOOL)enabled;
-
-- (BOOL)cssCompositingEnabled;
-- (void)setCSSCompositingEnabled:(BOOL)enabled;
-
- (BOOL)showDebugBorders;
- (void)setShowDebugBorders:(BOOL)show;
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (200523 => 200524)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-05-06 21:21:20 UTC (rev 200524)
@@ -2313,8 +2313,6 @@
settings.setFrameFlatteningEnabled([preferences isFrameFlatteningEnabled]);
settings.setSpatialNavigationEnabled([preferences isSpatialNavigationEnabled]);
settings.setPaginateDuringLayoutEnabled([preferences paginateDuringLayoutEnabled]);
- RuntimeEnabledFeatures::sharedFeatures().setCSSRegionsEnabled([preferences cssRegionsEnabled]);
- RuntimeEnabledFeatures::sharedFeatures().setCSSCompositingEnabled([preferences cssCompositingEnabled]);
settings.setAsynchronousSpellCheckingEnabled([preferences asynchronousSpellCheckingEnabled]);
settings.setHyperlinkAuditingEnabled([preferences hyperlinkAuditingEnabled]);
Modified: trunk/Source/WebKit/win/WebView.cpp (200523 => 200524)
--- trunk/Source/WebKit/win/WebView.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit/win/WebView.cpp 2016-05-06 21:21:20 UTC (rev 200524)
@@ -5034,11 +5034,6 @@
return hr;
settings.setPluginsEnabled(!!enabled);
- hr = preferences->isCSSRegionsEnabled(&enabled);
- if (FAILED(hr))
- return hr;
- RuntimeEnabledFeatures::sharedFeatures().setCSSRegionsEnabled(!!enabled);
-
#if ENABLE(INDEXED_DATABASE)
RuntimeEnabledFeatures::sharedFeatures().setWebkitIndexedDBEnabled(true);
#endif
Modified: trunk/Source/WebKit2/ChangeLog (200523 => 200524)
--- trunk/Source/WebKit2/ChangeLog 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-06 21:21:20 UTC (rev 200524)
@@ -1,3 +1,31 @@
+2016-05-06 Dean Jackson <[email protected]>
+
+ Regions, Shapes and Tracks don't need runtime features
+ https://bugs.webkit.org/show_bug.cgi?id=157426
+ <rdar://problem/26146262>
+
+ Reviewed by Simon Fraser.
+
+ The following RuntimeEnabledFeatures can be removed since
+ we have no need to disable them (they are stable and have
+ shipped for a while):
+ - CSS Regions
+ - CSS Shapes
+ - Media tracks
+
+ * Shared/WebPreferencesDefinitions.h:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetCSSRegionsEnabled): Deleted.
+ (WKPreferencesGetCSSRegionsEnabled): Deleted.
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Deleted.
+ (WebKit::InjectedBundle::setCSSRegionsEnabled): Deleted.
+ (WebKit::InjectedBundle::setCSSCompositingEnabled): Deleted.
+ * WebProcess/InjectedBundle/InjectedBundle.h:
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences): Deleted.
+
2016-05-05 Ada Chan <[email protected]>
Create a fence in WebVideoFullscreenManagerProxy::setVideoLayerFrame() to pass to the web process
Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (200523 => 200524)
--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-05-06 21:21:20 UTC (rev 200524)
@@ -132,8 +132,6 @@
macro(Accelerated2dCanvasEnabled, accelerated2dCanvasEnabled, Bool, bool, false, "", "") \
macro(CSSAnimationTriggersEnabled, cssAnimationTriggersEnabled, Bool, bool, true, "", "") \
macro(WebAnimationsEnabled, webAnimationsEnabled, Bool, bool, false, "", "") \
- macro(CSSRegionsEnabled, cssRegionsEnabled, Bool, bool, true, "", "") \
- macro(CSSCompositingEnabled, cssCompositingEnabled, Bool, bool, true, "", "") \
macro(ForceFTPDirectoryListings, forceFTPDirectoryListings, Bool, bool, false, "", "") \
macro(TabsToLinks, tabsToLinks, Bool, bool, DEFAULT_WEBKIT_TABSTOLINKS_ENABLED, "", "") \
macro(DNSPrefetchingEnabled, dnsPrefetchingEnabled, Bool, bool, false, "", "") \
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (200523 => 200524)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-05-06 21:21:20 UTC (rev 200524)
@@ -508,16 +508,6 @@
return toImpl(preferencesRef)->webAnimationsEnabled();
}
-void WKPreferencesSetCSSRegionsEnabled(WKPreferencesRef preferencesRef, bool flag)
-{
- toImpl(preferencesRef)->setCSSRegionsEnabled(flag);
-}
-
-bool WKPreferencesGetCSSRegionsEnabled(WKPreferencesRef preferencesRef)
-{
- return toImpl(preferencesRef)->cssRegionsEnabled();
-}
-
void WKPreferencesSetNeedsSiteSpecificQuirks(WKPreferencesRef preferencesRef, bool flag)
{
toImpl(preferencesRef)->setNeedsSiteSpecificQuirks(flag);
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (200523 => 200524)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-05-06 21:21:20 UTC (rev 200524)
@@ -115,10 +115,6 @@
WK_EXPORT void WKPreferencesSetWebAnimationsEnabled(WKPreferencesRef, bool flag);
WK_EXPORT bool WKPreferencesGetWebAnimationsEnabled(WKPreferencesRef);
-// Defaults to true
-WK_EXPORT void WKPreferencesSetCSSRegionsEnabled(WKPreferencesRef, bool flag);
-WK_EXPORT bool WKPreferencesGetCSSRegionsEnabled(WKPreferencesRef);
-
// Defaults to false.
WK_EXPORT void WKPreferencesSetNeedsSiteSpecificQuirks(WKPreferencesRef, bool);
WK_EXPORT bool WKPreferencesGetNeedsSiteSpecificQuirks(WKPreferencesRef);
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (200523 => 200524)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-05-06 21:21:20 UTC (rev 200524)
@@ -183,16 +183,6 @@
RuntimeEnabledFeatures::sharedFeatures().setWebAnimationsEnabled(enabled);
#endif
-#if ENABLE(CSS_REGIONS)
- if (preference == "WebKitCSSRegionsEnabled")
- RuntimeEnabledFeatures::sharedFeatures().setCSSRegionsEnabled(enabled);
-#endif
-
-#if ENABLE(CSS_COMPOSITING)
- if (preference == "WebKitCSSCompositingEnabled")
- RuntimeEnabledFeatures::sharedFeatures().setCSSCompositingEnabled(enabled);
-#endif
-
#if ENABLE(FETCH_API)
if (preference == "WebKitFetchAPIEnabled")
RuntimeEnabledFeatures::sharedFeatures().setFetchAPIEnabled(enabled);
@@ -595,22 +585,4 @@
#endif
}
-void InjectedBundle::setCSSRegionsEnabled(bool enabled)
-{
-#if ENABLE(CSS_REGIONS)
- RuntimeEnabledFeatures::sharedFeatures().setCSSRegionsEnabled(enabled);
-#else
- UNUSED_PARAM(enabled);
-#endif
-}
-
-void InjectedBundle::setCSSCompositingEnabled(bool enabled)
-{
-#if ENABLE(CSS_COMPOSITING)
- RuntimeEnabledFeatures::sharedFeatures().setCSSCompositingEnabled(enabled);
-#else
- UNUSED_PARAM(enabled);
-#endif
-}
-
} // namespace WebKit
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h (200523 => 200524)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2016-05-06 21:21:20 UTC (rev 200524)
@@ -153,8 +153,6 @@
void setSerialLoadingEnabled(bool);
void setCSSAnimationTriggersEnabled(bool);
void setWebAnimationsEnabled(bool);
- void setCSSRegionsEnabled(bool);
- void setCSSCompositingEnabled(bool);
void dispatchPendingLoadRequests();
#if PLATFORM(COCOA) && WK_API_ENABLED
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (200523 => 200524)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-05-06 21:21:20 UTC (rev 200524)
@@ -2919,8 +2919,6 @@
#if ENABLE(WEB_ANIMATIONS)
RuntimeEnabledFeatures::sharedFeatures().setWebAnimationsEnabled(store.getBoolValueForKey(WebPreferencesKey::webAnimationsEnabledKey()));
#endif
- RuntimeEnabledFeatures::sharedFeatures().setCSSRegionsEnabled(store.getBoolValueForKey(WebPreferencesKey::cssRegionsEnabledKey()));
- RuntimeEnabledFeatures::sharedFeatures().setCSSCompositingEnabled(store.getBoolValueForKey(WebPreferencesKey::cssCompositingEnabledKey()));
settings.setWebGLEnabled(store.getBoolValueForKey(WebPreferencesKey::webGLEnabledKey()));
settings.setForceSoftwareWebGLRendering(store.getBoolValueForKey(WebPreferencesKey::forceSoftwareWebGLRenderingKey()));
settings.setAccelerated2dCanvasEnabled(store.getBoolValueForKey(WebPreferencesKey::accelerated2dCanvasEnabledKey()));
Modified: trunk/Tools/ChangeLog (200523 => 200524)
--- trunk/Tools/ChangeLog 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Tools/ChangeLog 2016-05-06 21:21:20 UTC (rev 200524)
@@ -1,3 +1,21 @@
+2016-05-06 Dean Jackson <[email protected]>
+
+ Regions, Shapes and Tracks don't need runtime features
+ https://bugs.webkit.org/show_bug.cgi?id=157426
+ <rdar://problem/26146262>
+
+ Reviewed by Simon Fraser.
+
+ The following RuntimeEnabledFeatures can be removed since
+ we have no need to disable them (they are stable and have
+ shipped for a while):
+ - CSS Regions
+ - CSS Shapes
+ - Media tracks
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues): Deleted.
+
2016-05-06 Ryan Haddad <[email protected]>
Increase delay when launching multiple ios-simulators in parallel
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (200523 => 200524)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-05-06 21:21:20 UTC (rev 200524)
@@ -966,7 +966,6 @@
[preferences setCanvasUsesAcceleratedDrawing:YES];
[preferences setAcceleratedDrawingEnabled:useAcceleratedDrawing];
#endif
- [preferences setCSSRegionsEnabled:YES];
[preferences setUsePreHTML5ParserQuirks:NO];
[preferences setAsynchronousSpellCheckingEnabled:NO];
#if !PLATFORM(IOS)
