Title: [200527] trunk/LayoutTests
- Revision
- 200527
- Author
- beid...@apple.com
- Date
- 2016-05-06 15:06:29 -0700 (Fri, 06 May 2016)
Log Message
Unreviewed IDB test gardening.
Fix a failing test, and add better classification/comments to a different failing test.
* TestExpectations:
* storage/indexeddb/dont-commit-on-blocked-expected.txt:
* storage/indexeddb/dont-commit-on-blocked.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (200526 => 200527)
--- trunk/LayoutTests/ChangeLog 2016-05-06 21:38:10 UTC (rev 200526)
+++ trunk/LayoutTests/ChangeLog 2016-05-06 22:06:29 UTC (rev 200527)
@@ -2,6 +2,16 @@
Unreviewed IDB test gardening.
+ Fix a failing test, and add better classification/comments to a different failing test.
+
+ * TestExpectations:
+ * storage/indexeddb/dont-commit-on-blocked-expected.txt:
+ * storage/indexeddb/dont-commit-on-blocked.html:
+
+2016-05-06 Brady Eidson <beid...@apple.com>
+
+ Unreviewed IDB test gardening.
+
Update the workers variant of "deletedatabase-delayed-by-open-and-versionchange" to the modern expected results.
* TestExpectations:
Modified: trunk/LayoutTests/TestExpectations (200526 => 200527)
--- trunk/LayoutTests/TestExpectations 2016-05-06 21:38:10 UTC (rev 200526)
+++ trunk/LayoutTests/TestExpectations 2016-05-06 22:06:29 UTC (rev 200527)
@@ -908,9 +908,11 @@
webkit.org/b/154619 storage/indexeddb/odd-strings.html [ Skip ]
-# IDB workers tests that fail
+# IDB workers test fails - The worker's attempt to open the database creates a new UniqueIDBDatabase
+# Could be a SessionID difference? Something is giving the worker a different namespace.
storage/indexeddb/dont-commit-on-blocked-private.html [ Failure ]
-storage/indexeddb/dont-commit-on-blocked.html [ Failure ]
+
+# IDB workers tests that fail for unknown reasons
storage/indexeddb/pending-activity-workers.html [ Failure ]
# IDB workers tests that timeout
Modified: trunk/LayoutTests/storage/indexeddb/dont-commit-on-blocked-expected.txt (200526 => 200527)
--- trunk/LayoutTests/storage/indexeddb/dont-commit-on-blocked-expected.txt 2016-05-06 21:38:10 UTC (rev 200526)
+++ trunk/LayoutTests/storage/indexeddb/dont-commit-on-blocked-expected.txt 2016-05-06 22:06:29 UTC (rev 200527)
@@ -5,7 +5,6 @@
indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
-dbname = "dont-commit-on-blocked.html"
indexedDB.deleteDatabase(dbname)
indexedDB.open(dbname)
db._onversionchange_ = onVersionChange
Modified: trunk/LayoutTests/storage/indexeddb/dont-commit-on-blocked.html (200526 => 200527)
--- trunk/LayoutTests/storage/indexeddb/dont-commit-on-blocked.html 2016-05-06 21:38:10 UTC (rev 200526)
+++ trunk/LayoutTests/storage/indexeddb/dont-commit-on-blocked.html 2016-05-06 22:06:29 UTC (rev 200527)
@@ -30,7 +30,10 @@
function onVersionChange(e)
{
// Timing of logging from worker vs. this event is racy, so do not log here.
- db.close();
+ // Don't close within this turn of the event loop, so that worker sees 'blocked'.
+ setTimeout(function() {
+ db.close();
+ }, 0);
}
</script>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
