Title: [200549] trunk/Source/WebCore
Revision
200549
Author
[email protected]
Date
2016-05-07 15:29:01 -0700 (Sat, 07 May 2016)

Log Message

Fix crash introduced by the last patch.

Fix suggested by Chris Dumez.

* css/FontFace.cpp:
(WebCore::FontFace::FontFace): Roll out incorrect change. Things were getting
initialized in the wrong order in a change I had made to the FontFace constructor
that takes a CSSFontSelector.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (200548 => 200549)


--- trunk/Source/WebCore/ChangeLog	2016-05-07 21:36:39 UTC (rev 200548)
+++ trunk/Source/WebCore/ChangeLog	2016-05-07 22:29:01 UTC (rev 200549)
@@ -1,3 +1,14 @@
+2016-05-07  Darin Adler  <[email protected]>
+
+        Fix crash introduced by the last patch.
+
+        Fix suggested by Chris Dumez.
+
+        * css/FontFace.cpp:
+        (WebCore::FontFace::FontFace): Roll out incorrect change. Things were getting
+        initialized in the wrong order in a change I had made to the FontFace constructor
+        that takes a CSSFontSelector.
+
 2016-05-07  Chris Dumez  <[email protected]>
 
         Unreviewed, rebaseline bindings tests after r200547.

Modified: trunk/Source/WebCore/css/FontFace.cpp (200548 => 200549)


--- trunk/Source/WebCore/css/FontFace.cpp	2016-05-07 21:36:39 UTC (rev 200548)
+++ trunk/Source/WebCore/css/FontFace.cpp	2016-05-07 22:29:01 UTC (rev 200549)
@@ -84,8 +84,10 @@
 }
 
 FontFace::FontFace(CSSFontSelector& fontSelector)
-    : FontFace(CSSFontFace::create(&fontSelector, nullptr, this))
+    : m_weakPtrFactory(this)
+    , m_backing(CSSFontFace::create(&fontSelector, nullptr, this))
 {
+    m_backing->addClient(*this);
 }
 
 FontFace::FontFace(CSSFontFace& face)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to