Title: [200599] trunk/Source/WebKit/mac
- Revision
- 200599
- Author
- [email protected]
- Date
- 2016-05-09 17:00:06 -0700 (Mon, 09 May 2016)
Log Message
[WebKit1] Invoking a link preview on a complex link (e.g. an image) results in an empty TextIndicator
https://bugs.webkit.org/show_bug.cgi?id=157497
<rdar://problem/25872773>
Reviewed by Anders Carlsson.
* WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _defaultAnimationController]):
r198578 fixed this for WebKit2, but forgot about WebKit1.
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (200598 => 200599)
--- trunk/Source/WebKit/mac/ChangeLog 2016-05-09 23:59:55 UTC (rev 200598)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-05-10 00:00:06 UTC (rev 200599)
@@ -1,3 +1,15 @@
+2016-05-09 Tim Horton <[email protected]>
+
+ [WebKit1] Invoking a link preview on a complex link (e.g. an image) results in an empty TextIndicator
+ https://bugs.webkit.org/show_bug.cgi?id=157497
+ <rdar://problem/25872773>
+
+ Reviewed by Anders Carlsson.
+
+ * WebView/WebImmediateActionController.mm:
+ (-[WebImmediateActionController _defaultAnimationController]):
+ r198578 fixed this for WebKit2, but forgot about WebKit1.
+
2016-05-08 Myles C. Maxfield <[email protected]>
[OS X] Migrate our Font classes entirely off of NSFont
Modified: trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm (200598 => 200599)
--- trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm 2016-05-09 23:59:55 UTC (rev 200598)
+++ trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm 2016-05-10 00:00:06 UTC (rev 200599)
@@ -278,7 +278,7 @@
_type = WebImmediateActionLinkPreview;
RefPtr<Range> linkRange = rangeOfContents(*_hitTestResult.URLElement());
- auto indicator = TextIndicator::createWithRange(*linkRange, TextIndicatorOptionDefault, TextIndicatorPresentationTransition::FadeIn);
+ auto indicator = TextIndicator::createWithRange(*linkRange, TextIndicatorOptionUseBoundingRectAndPaintAllContentForComplexRanges, TextIndicatorPresentationTransition::FadeIn);
if (indicator)
[_webView _setTextIndicator:*indicator withLifetime:TextIndicatorWindowLifetime::Permanent];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
