Title: [200610] trunk/Source/_javascript_Core
Revision
200610
Author
[email protected]
Date
2016-05-09 20:22:39 -0700 (Mon, 09 May 2016)

Log Message

Crash beneath ObjCCallbackFunctionImpl::call
https://bugs.webkit.org/show_bug.cgi?id=157491

Reviewed by Saam Barati.

Clear any exceptions after the micro task runs.

Tried creating a test case, but I don't have source for the app.
I can't seem to find the right combination of Promises and ObjC code.

* runtime/JSJob.cpp:
(JSC::JSJobMicrotask::run):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (200609 => 200610)


--- trunk/Source/_javascript_Core/ChangeLog	2016-05-10 02:55:20 UTC (rev 200609)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-05-10 03:22:39 UTC (rev 200610)
@@ -1,3 +1,18 @@
+2016-05-09  Michael Saboff  <[email protected]>
+
+        Crash beneath ObjCCallbackFunctionImpl::call
+        https://bugs.webkit.org/show_bug.cgi?id=157491
+
+        Reviewed by Saam Barati.
+
+        Clear any exceptions after the micro task runs.
+
+        Tried creating a test case, but I don't have source for the app.
+        I can't seem to find the right combination of Promises and ObjC code.
+
+        * runtime/JSJob.cpp:
+        (JSC::JSJobMicrotask::run):
+
 2016-05-09  Filip Pizlo  <[email protected]>
 
         Polymorphic operands in operators coerces downstream values to double.

Modified: trunk/Source/_javascript_Core/runtime/JSJob.cpp (200609 => 200610)


--- trunk/Source/_javascript_Core/runtime/JSJob.cpp	2016-05-10 02:55:20 UTC (rev 200609)
+++ trunk/Source/_javascript_Core/runtime/JSJob.cpp	2016-05-10 03:22:39 UTC (rev 200610)
@@ -71,6 +71,7 @@
     for (unsigned index = 0, length = m_arguments->length(); index < length; ++index)
         handlerArguments.append(m_arguments->JSArray::get(exec, index));
     profiledCall(exec, ProfilingReason::Microtask, m_job.get(), handlerCallType, handlerCallData, jsUndefined(), handlerArguments);
+    exec->vm().clearException();
 }
 
 } // namespace JSC
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to