Diff
Modified: trunk/LayoutTests/ChangeLog (200618 => 200619)
--- trunk/LayoutTests/ChangeLog 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/LayoutTests/ChangeLog 2016-05-10 09:47:44 UTC (rev 200619)
@@ -1,3 +1,18 @@
+2016-05-10 Youenn Fablet <[email protected]>
+
+ NodeList should be iterable
+ https://bugs.webkit.org/show_bug.cgi?id=131443
+ <rdar://problem/25731519>
+
+ Reviewed by Darin Adler.
+
+ * fast/dom/domListEnumeration-expected.txt:
+ * fast/dom/nodeListIterator-expected.txt: Added.
+ * fast/dom/nodeListIterator.html: Added.
+ * fast/dom/script-tests/domListEnumeration.js:
+ * fast/text/font-face-set-_javascript_-expected.txt:
+ * fast/text/font-face-set-_javascript_.html:
+
2016-05-09 Sergio Villar Senin <[email protected]>
[css-grid] Implement auto-repeat computation
Modified: trunk/LayoutTests/fast/dom/domListEnumeration-expected.txt (200618 => 200619)
--- trunk/LayoutTests/fast/dom/domListEnumeration-expected.txt 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/LayoutTests/fast/dom/domListEnumeration-expected.txt 2016-05-10 09:47:44 UTC (rev 200619)
@@ -5,7 +5,7 @@
[object NodeList]
-PASS resultArray.length is 11
+PASS resultArray.length is 15
PASS resultArray[0].i is '0'
PASS resultArray[0].item is nodeList.item(0)
PASS resultArray[1].i is '1'
Added: trunk/LayoutTests/fast/dom/nodeListIterator-expected.txt (0 => 200619)
--- trunk/LayoutTests/fast/dom/nodeListIterator-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/nodeListIterator-expected.txt 2016-05-10 09:47:44 UTC (rev 200619)
@@ -0,0 +1,38 @@
+Testing of NodeList iterable capacities.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS nodeList.length is 2
+PASS item is children[index++]
+PASS item is children[index++]
+PASS pair[0] is children[0]
+PASS pair[1] is children[1]
+PASS forEachContainer is nodeList
+FAIL forEachIndex should be 0 (of type number). Was [object HTMLDivElement] (of type object).
+PASS node is children[index++]
+PASS forEachContainer is nodeList
+FAIL forEachIndex should be 1 (of type number). Was [object HTMLOListElement] (of type object).
+PASS node is children[index++]
+PASS iterator.next().value is children[0]
+PASS iterator.next().value is children[1]
+PASS end.done is true
+PASS end.value is undefined
+PASS iterator.next().value is children[0]
+PASS iterator.next().value is children[1]
+PASS end.done is true
+PASS end.value is undefined
+PASS pair.length is 2
+FAIL pair[0] should be 0 (of type number). Was [object HTMLDivElement] (of type object).
+PASS pair[1] is children[0]
+PASS pair.length is 2
+FAIL pair[0] should be 1 (of type number). Was [object HTMLOListElement] (of type object).
+PASS pair[1] is children[1]
+PASS end.done is true
+PASS end.value is undefined
+FAIL end.done should be true. Was false.
+FAIL end.value should be undefined (of type undefined). Was [object HTMLParagraphElement],[object HTMLParagraphElement] (of type object).
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/nodeListIterator.html (0 => 200619)
--- trunk/LayoutTests/fast/dom/nodeListIterator.html (rev 0)
+++ trunk/LayoutTests/fast/dom/nodeListIterator.html 2016-05-10 09:47:44 UTC (rev 200619)
@@ -0,0 +1,79 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+ <head>
+ <script src=""
+ </head>
+ <body>
+ <script>
+ description('Testing of NodeList iterable capacities.');
+
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
+ var end;
+ function checkEndIterator(iteratorValue) {
+ end = iteratorValue;
+ shouldBe('end.done', 'true');
+ shouldBe('end.value', 'undefined');
+ }
+
+ var testingGround = document.createElement('div');
+ var children = [document.createElement('div'), document.createElement('ol')];
+ testingGround.appendChild(children[0]);
+ testingGround.appendChild(children[1]);
+ document.body.appendChild(testingGround);
+
+ var nodeList = testingGround.childNodes;
+
+ shouldBe("nodeList.length", "2");
+
+ var index = 0;
+ for (var item of nodeList)
+ shouldBe('item', 'children[index++]');
+
+ pair = Array.from(nodeList);
+ shouldBe('pair[0]', 'children[0]');
+ shouldBe('pair[1]', 'children[1]');
+
+ index = 0;
+ var node;
+ var forEachIndex;
+ var forEachContainer;
+ nodeList.forEach(function(n, i, c) {
+ node = n;
+ forEachIndex = i;
+ forEachContainer = c;
+ shouldBe('forEachContainer', 'nodeList');
+ shouldBe('forEachIndex', 'index');
+ shouldBe('node', 'children[index++]');
+ });
+
+ var iterator = nodeList.keys();
+ shouldBe('iterator.next().value', 'children[0]');
+ shouldBe('iterator.next().value', 'children[1]');
+ checkEndIterator(iterator.next());
+
+ var iterator = nodeList.values();
+ shouldBe('iterator.next().value', 'children[0]');
+ shouldBe('iterator.next().value', 'children[1]');
+ checkEndIterator(iterator.next());
+
+ var iterator = nodeList.entries();
+ var pair = iterator.next().value;
+ shouldBe('pair.length', '2');
+ shouldBe('pair[0]', '0');
+ shouldBe('pair[1]', 'children[0]');
+ pair = iterator.next().value;
+ shouldBe('pair.length', '2');
+ shouldBe('pair[0]', '1');
+ shouldBe('pair[1]', 'children[1]');
+ checkEndIterator(iterator.next());
+
+ testingGround.appendChild(document.createElement('ul'));
+ testingGround.appendChild(document.createElement('p'));
+ checkEndIterator(iterator.next());
+
+ </script>
+ <script src=""
+ </body>
+</html>
Modified: trunk/LayoutTests/fast/dom/script-tests/domListEnumeration.js (200618 => 200619)
--- trunk/LayoutTests/fast/dom/script-tests/domListEnumeration.js 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/LayoutTests/fast/dom/script-tests/domListEnumeration.js 2016-05-10 09:47:44 UTC (rev 200619)
@@ -97,7 +97,7 @@
var nodeList = testingGround.childNodes;
resultArray = iterateList(nodeList);
-shouldBe("resultArray.length", "11");
+shouldBe("resultArray.length", "15");
shouldBe("resultArray[0].i", "'0'");
shouldBe("resultArray[0].item", "nodeList.item(0)");
shouldBe("resultArray[1].i", "'1'");
Modified: trunk/LayoutTests/fast/text/font-face-set-_javascript_-expected.txt (200618 => 200619)
--- trunk/LayoutTests/fast/text/font-face-set-_javascript_-expected.txt 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/LayoutTests/fast/text/font-face-set-_javascript_-expected.txt 2016-05-10 09:47:44 UTC (rev 200619)
@@ -3,8 +3,11 @@
PASS new FontFaceSet([fontFace1]).size is 1
PASS fontFaceSet.status is "loaded"
PASS item.done is false
-PASS item.value is [fontFace1, fontFace1]
+PASS item.value.length is 2
+FAIL item.value[0] should be 0 (of type number). Was [object FontFace] (of type object).
+PASS item.value[1] is fontFace1
PASS item.done is true
+PASS item.value is undefined
PASS item.done is false
PASS item.value is fontFace1
PASS item.done is true
Modified: trunk/LayoutTests/fast/text/font-face-set-_javascript_.html (200618 => 200619)
--- trunk/LayoutTests/fast/text/font-face-set-_javascript_.html 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/LayoutTests/fast/text/font-face-set-_javascript_.html 2016-05-10 09:47:44 UTC (rev 200619)
@@ -23,9 +23,12 @@
var iterator = fontFaceSet.entries();
var item = iterator.next();
shouldBeFalse("item.done");
-shouldBe("item.value", "[fontFace1, fontFace1]");
+shouldBe("item.value.length", "2");
+shouldBe("item.value[0]", "0");
+shouldBe("item.value[1]", "fontFace1");
item = iterator.next();
shouldBeTrue("item.done");
+shouldBe("item.value", "undefined");
iterator = fontFaceSet.keys();
item = iterator.next();
Modified: trunk/Source/WebCore/ChangeLog (200618 => 200619)
--- trunk/Source/WebCore/ChangeLog 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/Source/WebCore/ChangeLog 2016-05-10 09:47:44 UTC (rev 200619)
@@ -1,3 +1,45 @@
+2016-05-10 Youenn Fablet <[email protected]>
+
+ NodeList should be iterable
+ https://bugs.webkit.org/show_bug.cgi?id=131443
+ <rdar://problem/25731519>
+
+ Reviewed by Darin Adler.
+
+ Test: fast/dom/nodeListIterator.html
+
+ Updating JSKeyValueIterator to support map and set iterators,
+ depending on the signature of the result type of DOMClass::Iterator::next method.
+ Symbol.iterator method is made the same as values method for set iterators.
+
+ Adding support for NodeList.
+ Updating FontFaceSet to take benefit of that.
+
+ * bindings/js/JSDOMBinding.h:
+ (WebCore::jsPair):.
+ * bindings/js/JSKeyValueIterator.h:
+ (WebCore::IteratorInspector::decltype): IteratorInspector detects whether the iterator is a set or map iterator.
+ (WebCore::IteratorInspector::test):
+ (WebCore::fillForEachArgumentsWithIteratorValue): Specializing according set/map iterator.
+ (WebCore::iteratorValueToJS): Ditto.
+ (WebCore::keyValueIteratorForEach):
+ (WebCore::JSKeyValueIterator<JSWrapper>::next):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateImplementationIterableFunctions): Removed the line forbidding set iterators.
+ Making Symbol.iterator function equal to values for set iterators.
+ * bindings/scripts/test/JS/JSTestNode.cpp: Rebasing with set iterator functions.
+ * bindings/scripts/test/JS/JSTestObj.cpp: Rebasing according updated function names.
+ * bindings/scripts/test/TestNode.idl: Making TestNode set iterable.
+ * css/FontFaceSet.cpp:
+ (WebCore::FontFaceSet::Iterator::next): Refactoring to make it a set iterator.
+ * css/FontFaceSet.h:
+ * css/FontFaceSet.idl:
+ * dom/NodeList.h: Making NodeList iterable.
+ (WebCore::NodeList::Iterator::Iterator):
+ (WebCore::NodeList::Iterator::next):
+ (WebCore::NodeList::createIterator):
+ * dom/NodeList.idl:
+
2016-05-09 Sergio Villar Senin <[email protected]>
[css-grid] Implement auto-repeat computation
Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (200618 => 200619)
--- trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2016-05-10 09:47:44 UTC (rev 200619)
@@ -266,7 +266,8 @@
template<typename T, size_t inlineCapacity> JSC::JSValue jsArray(JSC::ExecState*, JSDOMGlobalObject*, const Vector<T, inlineCapacity>*);
WEBCORE_EXPORT JSC::JSValue jsArray(JSC::ExecState*, JSDOMGlobalObject*, PassRefPtr<DOMStringList>);
-template<typename Value1, typename Value2> JSC::JSValue jsPair(JSC::ExecState&, JSDOMGlobalObject*, const Value1&, const Value2&);
+JSC::JSValue jsPair(JSC::ExecState&, JSDOMGlobalObject*, JSC::JSValue, JSC::JSValue);
+template<typename FirstType, typename SecondType> JSC::JSValue jsPair(JSC::ExecState&, JSDOMGlobalObject*, const FirstType&, const SecondType&);
RefPtr<JSC::ArrayBufferView> toArrayBufferView(JSC::JSValue);
RefPtr<JSC::Int8Array> toInt8Array(JSC::JSValue);
@@ -635,14 +636,19 @@
return jsArray(exec, globalObject, *vector);
}
-template<typename Value1, typename Value2> inline JSC::JSValue jsPair(JSC::ExecState& state, JSDOMGlobalObject* globalObject, const Value1& value1, const Value2& value2)
+inline JSC::JSValue jsPair(JSC::ExecState& state, JSDOMGlobalObject* globalObject, JSC::JSValue value1, JSC::JSValue value2)
{
JSC::MarkedArgumentBuffer args;
- args.append(toJS(&state, globalObject, value1));
- args.append(toJS(&state, globalObject, value2));
+ args.append(value1);
+ args.append(value2);
return constructArray(&state, 0, globalObject, args);
}
+template<typename FirstType, typename SecondType> inline JSC::JSValue jsPair(JSC::ExecState& state, JSDOMGlobalObject* globalObject, const FirstType& value1, const SecondType& value2)
+{
+ return jsPair(state, globalObject, toJS(&state, globalObject, value1), toJS(&state, globalObject, value2));
+}
+
inline RefPtr<JSC::ArrayBufferView> toArrayBufferView(JSC::JSValue value)
{
auto* wrapper = JSC::jsDynamicCast<JSC::JSArrayBufferView*>(value);
Modified: trunk/Source/WebCore/bindings/js/JSDOMIterator.h (200618 => 200619)
--- trunk/Source/WebCore/bindings/js/JSDOMIterator.h 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/Source/WebCore/bindings/js/JSDOMIterator.h 2016-05-10 09:47:44 UTC (rev 200619)
@@ -60,6 +60,16 @@
void finishCreation(JSC::VM&, JSC::JSGlobalObject*);
};
+template<typename IteratorValue>
+class IteratorInspector {
+private:
+ template<typename T> static constexpr auto test(int) -> decltype(std::declval<T>()->key, std::declval<T>()->value, bool()) { return true; }
+ template<typename T> static constexpr bool test(...) { return false; }
+public:
+ static constexpr bool isMap = test<IteratorValue>(0);
+ static constexpr bool isSet = !isMap;
+};
+
enum class IterationKind { Key, Value, KeyValue };
template<typename JSWrapper>
@@ -105,7 +115,12 @@
};
template<typename JSWrapper>
-JSC::EncodedJSValue createKeyValueIterator(JSC::ExecState& state, IterationKind kind, const char* propertyName)
+JSC::EncodedJSValue iteratorCreate(JSC::ExecState&, IterationKind, const char*);
+template<typename JSWrapper>
+JSC::EncodedJSValue iteratorForEach(JSC::ExecState&, const char*);
+
+template<typename JSWrapper>
+JSC::EncodedJSValue iteratorCreate(JSC::ExecState& state, IterationKind kind, const char* propertyName)
{
auto wrapper = JSC::jsDynamicCast<JSWrapper*>(state.thisValue());
if (UNLIKELY(!wrapper))
@@ -114,8 +129,47 @@
return JSC::JSValue::encode(JSDOMIterator<JSWrapper>::create(globalObject.vm(), getDOMStructure<JSDOMIterator<JSWrapper>>(globalObject.vm(), globalObject), *wrapper, kind));
}
+template<typename IteratorValue> typename std::enable_if<IteratorInspector<IteratorValue>::isMap, JSC::JSValue>::type
+toJS(JSC::ExecState& state, JSDOMGlobalObject* globalObject, IteratorValue& value, IterationKind kind)
+{
+ ASSERT(value);
+ if (kind != IterationKind::KeyValue)
+ return toJS(&state, globalObject, (kind == IterationKind::Key) ? value->key : value->value);
+
+ return jsPair(state, globalObject, value->key, value->value);
+}
+
+template<typename IteratorValue> typename std::enable_if<IteratorInspector<IteratorValue>::isSet, JSC::JSValue>::type
+toJS(JSC::ExecState& state, JSDOMGlobalObject* globalObject, IteratorValue& value, IterationKind kind)
+{
+ ASSERT(value);
+ JSC::JSValue result = toJS(&state, globalObject, *value);
+ if (kind != IterationKind::KeyValue)
+ return result;
+
+ // FIXME: first pair value should be the index of result.
+ return jsPair(state, globalObject, result, result);
+}
+
+template<typename IteratorValue> typename std::enable_if<IteratorInspector<IteratorValue>::isMap, void>::type
+appendForEachArguments(JSC::ExecState& state, JSDOMGlobalObject* globalObject, JSC::MarkedArgumentBuffer& arguments, IteratorValue& value)
+{
+ ASSERT(value);
+ arguments.append(toJS(&state, globalObject, value->value));
+ arguments.append(toJS(&state, globalObject, value->key));
+}
+
+template<typename IteratorValue> typename std::enable_if<IteratorInspector<IteratorValue>::isSet, void>::type
+appendForEachArguments(JSC::ExecState& state, JSDOMGlobalObject* globalObject, JSC::MarkedArgumentBuffer& arguments, IteratorValue& value)
+{
+ ASSERT(value);
+ JSC::JSValue argument = toJS(&state, globalObject, *value);
+ arguments.append(argument);
+ arguments.append(argument);
+}
+
template<typename JSWrapper>
-JSC::EncodedJSValue keyValueIteratorForEach(JSC::ExecState& state, const char* propertyName)
+JSC::EncodedJSValue iteratorForEach(JSC::ExecState& state, const char* propertyName)
{
auto wrapper = JSC::jsDynamicCast<JSWrapper*>(state.thisValue());
if (UNLIKELY(!wrapper))
@@ -129,8 +183,7 @@
auto iterator = wrapper->wrapped().createIterator();
while (auto value = iterator.next()) {
JSC::MarkedArgumentBuffer arguments;
- arguments.append(toJS(&state, wrapper->globalObject(), value.value().value));
- arguments.append(toJS(&state, wrapper->globalObject(), value.value().key));
+ appendForEachArguments(state, wrapper->globalObject(), arguments, value);
arguments.append(wrapper);
JSC::call(&state, state.argument(0), callType, callData, wrapper, arguments);
if (state.hadException())
@@ -152,16 +205,7 @@
auto iteratorValue = m_iterator.next();
if (!iteratorValue)
return createIteratorResultObject(&state, JSC::jsUndefined(), true);
-
- JSC::JSValue value;
- if (m_kind == IterationKind::Value)
- value = toJS(&state, globalObject(), iteratorValue.value().value);
- else if (m_kind == IterationKind::Key)
- value = toJS(&state, globalObject(), iteratorValue.value().key);
- else
- value = jsPair(state, globalObject(), iteratorValue.value().key, iteratorValue.value().value);
-
- return createIteratorResultObject(&state, value, false);
+ return createIteratorResultObject(&state, toJS(state, globalObject(), iteratorValue, m_kind), false);
}
template<typename JSWrapper>
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (200618 => 200619)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-05-10 09:47:44 UTC (rev 200619)
@@ -4208,10 +4208,6 @@
{
my $interface = shift;
- if (not $interface->iterable->isKeyValue) {
- die "No support yet for set iterators";
- }
-
my $interfaceName = $interface->name;
my $className = "JS$interfaceName";
my $visibleInterfaceName = $codeGenerator->GetVisibleInterfaceName($interface);
@@ -4238,10 +4234,11 @@
my $iterationKind = "KeyValue";
$iterationKind = "Key" if $propertyName eq "keys";
$iterationKind = "Value" if $propertyName eq "values";
+ $iterationKind = "Value" if $propertyName eq "[Symbol.Iterator]" and not $interface->iterable->isKeyValue;
push(@implContent, <<END);
JSC::EncodedJSValue JSC_HOST_CALL ${functionName}(JSC::ExecState* state)
{
- return createKeyValueIterator<${className}>(*state, IterationKind::${iterationKind}, "${propertyName}");
+ return iteratorCreate<${className}>(*state, IterationKind::${iterationKind}, "${propertyName}");
}
END
@@ -4249,7 +4246,7 @@
push(@implContent, <<END);
JSC::EncodedJSValue JSC_HOST_CALL ${functionName}(JSC::ExecState* state)
{
- return keyValueIteratorForEach<${className}>(*state, "${propertyName}");
+ return iteratorForEach<${className}>(*state, "${propertyName}");
}
END
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp (200618 => 200619)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp 2016-05-10 09:47:44 UTC (rev 200619)
@@ -24,6 +24,7 @@
#include "ExceptionCode.h"
#include "JSDOMBinding.h"
#include "JSDOMConstructor.h"
+#include "JSDOMIterator.h"
#include "URL.h"
#include <runtime/Error.h>
#include <runtime/JSString.h>
@@ -33,6 +34,14 @@
namespace WebCore {
+// Functions
+
+JSC::EncodedJSValue JSC_HOST_CALL jsTestNodePrototypeFunctionSymbolIterator(JSC::ExecState*);
+JSC::EncodedJSValue JSC_HOST_CALL jsTestNodePrototypeFunctionEntries(JSC::ExecState*);
+JSC::EncodedJSValue JSC_HOST_CALL jsTestNodePrototypeFunctionKeys(JSC::ExecState*);
+JSC::EncodedJSValue JSC_HOST_CALL jsTestNodePrototypeFunctionValues(JSC::ExecState*);
+JSC::EncodedJSValue JSC_HOST_CALL jsTestNodePrototypeFunctionForEach(JSC::ExecState*);
+
// Attributes
JSC::EncodedJSValue jsTestNodeName(JSC::ExecState*, JSC::EncodedJSValue, JSC::PropertyName);
@@ -94,6 +103,10 @@
{
{ "constructor", DontEnum, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestNodeConstructor), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(setJSTestNodeConstructor) } },
{ "name", CustomAccessor, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestNodeName), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(setJSTestNodeName) } },
+ { "entries", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestNodePrototypeFunctionEntries), (intptr_t) (0) } },
+ { "keys", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestNodePrototypeFunctionKeys), (intptr_t) (0) } },
+ { "values", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestNodePrototypeFunctionValues), (intptr_t) (0) } },
+ { "forEach", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestNodePrototypeFunctionForEach), (intptr_t) (1) } },
};
const ClassInfo JSTestNodePrototype::s_info = { "TestNodePrototype", &Base::s_info, 0, CREATE_METHOD_TABLE(JSTestNodePrototype) };
@@ -102,6 +115,7 @@
{
Base::finishCreation(vm);
reifyStaticProperties(vm, JSTestNodePrototypeTableValues, *this);
+ putDirect(vm, vm.propertyNames->iteratorSymbol, JSFunction::create(vm, globalObject(), 0, ASCIILiteral("[Symbol.Iterator]"), jsTestNodePrototypeFunctionSymbolIterator), ReadOnly | DontEnum);
}
const ClassInfo JSTestNode::s_info = { "TestNode", &Base::s_info, 0, CREATE_METHOD_TABLE(JSTestNode) };
@@ -178,6 +192,40 @@
return getDOMConstructor<JSTestNodeConstructor>(vm, *jsCast<const JSDOMGlobalObject*>(globalObject));
}
+using TestNodeIterator = JSDOMIterator<JSTestNode>;
+using TestNodeIteratorPrototype = JSDOMIteratorPrototype<JSTestNode>;
+
+template<>
+const JSC::ClassInfo TestNodeIterator::s_info = { "TestNode Iterator", &Base::s_info, 0, CREATE_METHOD_TABLE(TestNodeIterator) };
+
+template<>
+const JSC::ClassInfo TestNodeIteratorPrototype::s_info = { "TestNode Iterator", &Base::s_info, 0, CREATE_METHOD_TABLE(TestNodeIteratorPrototype) };
+
+JSC::EncodedJSValue JSC_HOST_CALL jsTestNodePrototypeFunctionSymbolIterator(JSC::ExecState* state)
+{
+ return iteratorCreate<JSTestNode>(*state, IterationKind::Value, "[Symbol.Iterator]");
+}
+
+JSC::EncodedJSValue JSC_HOST_CALL jsTestNodePrototypeFunctionEntries(JSC::ExecState* state)
+{
+ return iteratorCreate<JSTestNode>(*state, IterationKind::KeyValue, "entries");
+}
+
+JSC::EncodedJSValue JSC_HOST_CALL jsTestNodePrototypeFunctionKeys(JSC::ExecState* state)
+{
+ return iteratorCreate<JSTestNode>(*state, IterationKind::Key, "keys");
+}
+
+JSC::EncodedJSValue JSC_HOST_CALL jsTestNodePrototypeFunctionValues(JSC::ExecState* state)
+{
+ return iteratorCreate<JSTestNode>(*state, IterationKind::Value, "values");
+}
+
+JSC::EncodedJSValue JSC_HOST_CALL jsTestNodePrototypeFunctionForEach(JSC::ExecState* state)
+{
+ return iteratorForEach<JSTestNode>(*state, "forEach");
+}
+
void JSTestNode::visitChildren(JSCell* cell, SlotVisitor& visitor)
{
auto* thisObject = jsCast<JSTestNode*>(cell);
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (200618 => 200619)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-05-10 09:47:44 UTC (rev 200619)
@@ -6152,27 +6152,27 @@
JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionSymbolIterator(JSC::ExecState* state)
{
- return createKeyValueIterator<JSTestObj>(*state, IterationKind::KeyValue, "[Symbol.Iterator]");
+ return iteratorCreate<JSTestObj>(*state, IterationKind::KeyValue, "[Symbol.Iterator]");
}
JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionEntries(JSC::ExecState* state)
{
- return createKeyValueIterator<JSTestObj>(*state, IterationKind::KeyValue, "entries");
+ return iteratorCreate<JSTestObj>(*state, IterationKind::KeyValue, "entries");
}
JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionKeys(JSC::ExecState* state)
{
- return createKeyValueIterator<JSTestObj>(*state, IterationKind::Key, "keys");
+ return iteratorCreate<JSTestObj>(*state, IterationKind::Key, "keys");
}
JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionValues(JSC::ExecState* state)
{
- return createKeyValueIterator<JSTestObj>(*state, IterationKind::Value, "values");
+ return iteratorCreate<JSTestObj>(*state, IterationKind::Value, "values");
}
JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionForEach(JSC::ExecState* state)
{
- return keyValueIteratorForEach<JSTestObj>(*state, "forEach");
+ return iteratorForEach<JSTestObj>(*state, "forEach");
}
void JSTestObj::visitChildren(JSCell* cell, SlotVisitor& visitor)
Modified: trunk/Source/WebCore/bindings/scripts/test/TestNode.idl (200618 => 200619)
--- trunk/Source/WebCore/bindings/scripts/test/TestNode.idl 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/Source/WebCore/bindings/scripts/test/TestNode.idl 2016-05-10 09:47:44 UTC (rev 200619)
@@ -23,5 +23,7 @@
ExportMacro=WEBCORE_TESTSUPPORT_EXPORT,
] interface TestNode : Node {
attribute DOMString name;
+
+ iterable<TestNode>;
};
Modified: trunk/Source/WebCore/css/FontFaceSet.cpp (200618 => 200619)
--- trunk/Source/WebCore/css/FontFaceSet.cpp 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/Source/WebCore/css/FontFaceSet.cpp 2016-05-10 09:47:44 UTC (rev 200619)
@@ -76,12 +76,11 @@
{
}
-Optional<WTF::KeyValuePair<RefPtr<FontFace>, RefPtr<FontFace>>> FontFaceSet::Iterator::next()
+RefPtr<FontFace> FontFaceSet::Iterator::next()
{
if (m_index == m_target->size())
- return Nullopt;
- RefPtr<FontFace> item = m_target->backing()[m_index++].wrapper();
- return WTF::KeyValuePair<RefPtr<FontFace>, RefPtr<FontFace>>(item, item);
+ return nullptr;
+ return m_target->backing()[m_index++].wrapper();
}
FontFaceSet::PendingPromise::PendingPromise(Promise&& promise)
Modified: trunk/Source/WebCore/css/FontFaceSet.h (200618 => 200619)
--- trunk/Source/WebCore/css/FontFaceSet.h 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/Source/WebCore/css/FontFaceSet.h 2016-05-10 09:47:44 UTC (rev 200619)
@@ -61,7 +61,7 @@
class Iterator {
public:
explicit Iterator(FontFaceSet&);
- Optional<WTF::KeyValuePair<RefPtr<FontFace>, RefPtr<FontFace>>> next();
+ RefPtr<FontFace> next();
private:
Ref<FontFaceSet> m_target;
Modified: trunk/Source/WebCore/css/FontFaceSet.idl (200618 => 200619)
--- trunk/Source/WebCore/css/FontFaceSet.idl 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/Source/WebCore/css/FontFaceSet.idl 2016-05-10 09:47:44 UTC (rev 200619)
@@ -35,8 +35,7 @@
boolean has(FontFace font);
// FIXME: We should add support for the setlike declaration.
- // As a first step this map iterable declaration should be changed to a set iterable.
- iterable<FontFace, FontFace>;
+ iterable<FontFace>;
readonly attribute long size;
Modified: trunk/Source/WebCore/dom/NodeList.h (200618 => 200619)
--- trunk/Source/WebCore/dom/NodeList.h 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/Source/WebCore/dom/NodeList.h 2016-05-10 09:47:44 UTC (rev 200619)
@@ -40,6 +40,17 @@
virtual unsigned length() const = 0;
virtual Node* item(unsigned index) const = 0;
+ class Iterator {
+ public:
+ explicit Iterator(NodeList& list) : m_list(list) { }
+ Node* next() { return m_list->item(m_index++); }
+
+ private:
+ size_t m_index { 0 };
+ Ref<NodeList> m_list;
+ };
+ Iterator createIterator() { return Iterator(*this); }
+
// Other methods (not part of DOM)
virtual bool isLiveNodeList() const { return false; }
virtual bool isChildNodeList() const { return false; }
Modified: trunk/Source/WebCore/dom/NodeList.idl (200618 => 200619)
--- trunk/Source/WebCore/dom/NodeList.idl 2016-05-10 07:46:08 UTC (rev 200618)
+++ trunk/Source/WebCore/dom/NodeList.idl 2016-05-10 09:47:44 UTC (rev 200619)
@@ -27,5 +27,6 @@
] interface NodeList {
getter Node item(unsigned long index);
readonly attribute unsigned long length;
+ iterable<Node>;
};
