Title: [200666] trunk/Source/_javascript_Core
- Revision
- 200666
- Author
- [email protected]
- Date
- 2016-05-10 18:56:00 -0700 (Tue, 10 May 2016)
Log Message
REGRESSION(r200447): Unable to build C_LOOP with clang version 800.0.12 or higher
https://bugs.webkit.org/show_bug.cgi?id=157549
Reviewed by Keith Miller.
Disable debug annotations for C_LOOP builds. They are inline assembly directives,
unnecessary and they cause syntax errors.
* offlineasm/asm.rb:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (200665 => 200666)
--- trunk/Source/_javascript_Core/ChangeLog 2016-05-11 01:55:47 UTC (rev 200665)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-05-11 01:56:00 UTC (rev 200666)
@@ -1,3 +1,15 @@
+2016-05-10 Michael Saboff <[email protected]>
+
+ REGRESSION(r200447): Unable to build C_LOOP with clang version 800.0.12 or higher
+ https://bugs.webkit.org/show_bug.cgi?id=157549
+
+ Reviewed by Keith Miller.
+
+ Disable debug annotations for C_LOOP builds. They are inline assembly directives,
+ unnecessary and they cause syntax errors.
+
+ * offlineasm/asm.rb:
+
2016-05-10 Filip Pizlo <[email protected]>
Internal JSC profiler should have a timestamped log of events for each code block
Modified: trunk/Source/_javascript_Core/offlineasm/asm.rb (200665 => 200666)
--- trunk/Source/_javascript_Core/offlineasm/asm.rb 2016-05-11 01:55:47 UTC (rev 200665)
+++ trunk/Source/_javascript_Core/offlineasm/asm.rb 2016-05-11 01:56:00 UTC (rev 200666)
@@ -347,6 +347,14 @@
configIndex = configuration[1]
forSettings(computeSettingsCombinations(ast)[configIndex], ast) {
| concreteSettings, lowLevelAST, backend |
+
+ # There could be multiple backends we are generating for, but the C_LOOP is
+ # always by itself so this check to turn off $enableDebugAnnotations won't
+ # affect the generation for any other backend.
+ if backend == "C_LOOP"
+ $enableDebugAnnotations = false
+ end
+
lowLevelAST = lowLevelAST.resolve(*buildOffsetsMap(lowLevelAST, offsetsList))
lowLevelAST.validate
emitCodeInConfiguration(concreteSettings, lowLevelAST, backend) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
