Title: [97911] trunk/Source/WebCore
- Revision
- 97911
- Author
- [email protected]
- Date
- 2011-10-19 18:51:13 -0700 (Wed, 19 Oct 2011)
Log Message
[EFL] Remove the empty paint() implementation in ScrollbarEfl.
https://bugs.webkit.org/show_bug.cgi?id=70428
Patch by Raphael Kubo da Costa <[email protected]> on 2011-10-19
Reviewed by Antonio Gomes.
Remove the empty reimplementation of Scrollbar::paint(), as this would
cause ScrollView::paintScrollbars() to paint nothing at all.
If we have mock scrollbars enabled, this will paint them; otherwise,
the code path will end up in WidgetEfl::paint(), which also does
nothing, so the behavior should not change.
No new tests, this is machinery needed to run the current ones.
* platform/efl/ScrollbarEfl.cpp:
(ScrollbarEfl::frameRectsChanged):
* platform/efl/ScrollbarEfl.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97910 => 97911)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 01:47:45 UTC (rev 97910)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 01:51:13 UTC (rev 97911)
@@ -1,5 +1,25 @@
2011-10-19 Raphael Kubo da Costa <[email protected]>
+ [EFL] Remove the empty paint() implementation in ScrollbarEfl.
+ https://bugs.webkit.org/show_bug.cgi?id=70428
+
+ Reviewed by Antonio Gomes.
+
+ Remove the empty reimplementation of Scrollbar::paint(), as this would
+ cause ScrollView::paintScrollbars() to paint nothing at all.
+
+ If we have mock scrollbars enabled, this will paint them; otherwise,
+ the code path will end up in WidgetEfl::paint(), which also does
+ nothing, so the behavior should not change.
+
+ No new tests, this is machinery needed to run the current ones.
+
+ * platform/efl/ScrollbarEfl.cpp:
+ (ScrollbarEfl::frameRectsChanged):
+ * platform/efl/ScrollbarEfl.h:
+
+2011-10-19 Raphael Kubo da Costa <[email protected]>
+
[EFL] Do not always consider a ScrollView will have an Evas/Evas_Object.
https://bugs.webkit.org/show_bug.cgi?id=70426
Modified: trunk/Source/WebCore/platform/efl/ScrollbarEfl.cpp (97910 => 97911)
--- trunk/Source/WebCore/platform/efl/ScrollbarEfl.cpp 2011-10-20 01:47:45 UTC (rev 97910)
+++ trunk/Source/WebCore/platform/efl/ScrollbarEfl.cpp 2011-10-20 01:51:13 UTC (rev 97911)
@@ -209,8 +209,3 @@
evas_object_move(object, x + rect.x(), y + rect.y());
evas_object_resize(object, rect.width(), rect.height());
}
-
-void ScrollbarEfl::paint(GraphicsContext* graphicsContext, const IntRect& damageRect)
-{
-}
-
Modified: trunk/Source/WebCore/platform/efl/ScrollbarEfl.h (97910 => 97911)
--- trunk/Source/WebCore/platform/efl/ScrollbarEfl.h 2011-10-20 01:47:45 UTC (rev 97910)
+++ trunk/Source/WebCore/platform/efl/ScrollbarEfl.h 2011-10-20 01:51:13 UTC (rev 97911)
@@ -49,8 +49,6 @@
virtual void frameRectsChanged();
- virtual void paint(GraphicsContext*, const IntRect&);
-
protected:
ScrollbarEfl(ScrollableArea*, ScrollbarOrientation, ScrollbarControlSize);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
