Title: [200773] trunk/Source/WebInspectorUI
- Revision
- 200773
- Author
- [email protected]
- Date
- 2016-05-12 08:43:43 -0700 (Thu, 12 May 2016)
Log Message
Web Inspector: 3.8% of timeline recording spent in NavigationSidebarPanel _updateContentOverflowShadowVisibility for background tab
https://bugs.webkit.org/show_bug.cgi?id=157616
Patch by Joseph Pecoraro <[email protected]> on 2016-05-12
Reviewed by Timothy Hatcher.
* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
Don't update or schedule and update if we aren't visible.
When we are shown we will force an update.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (200772 => 200773)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-12 15:42:37 UTC (rev 200772)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-12 15:43:43 UTC (rev 200773)
@@ -1,5 +1,18 @@
2016-05-12 Joseph Pecoraro <[email protected]>
+ Web Inspector: 3.8% of timeline recording spent in NavigationSidebarPanel _updateContentOverflowShadowVisibility for background tab
+ https://bugs.webkit.org/show_bug.cgi?id=157616
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/NavigationSidebarPanel.js:
+ (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
+ (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
+ Don't update or schedule and update if we aren't visible.
+ When we are shown we will force an update.
+
+2016-05-12 Joseph Pecoraro <[email protected]>
+
Web Inspector: Reduce rAF churn in DefaultDashboardView on pages with lots of resources
https://bugs.webkit.org/show_bug.cgi?id=157618
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (200772 => 200773)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2016-05-12 15:42:37 UTC (rev 200772)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2016-05-12 15:43:43 UTC (rev 200773)
@@ -489,6 +489,9 @@
_updateContentOverflowShadowVisibility()
{
+ if (!this.visible)
+ return;
+
this._updateContentOverflowShadowVisibility.cancelDebounce();
let scrollHeight = this.contentView.element.scrollHeight;
@@ -628,8 +631,10 @@
}
this._checkForEmptyFilterResults();
- this.soon._updateContentOverflowShadowVisibility();
+ if (this.visible)
+ this.soon._updateContentOverflowShadowVisibility();
+
if (this.selected)
this._checkElementsForPendingViewStateCookie([treeElement]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
