Title: [200794] trunk/Source/WebCore
- Revision
- 200794
- Author
- [email protected]
- Date
- 2016-05-12 15:13:10 -0700 (Thu, 12 May 2016)
Log Message
Prevent clicks in the placeholder from playing or pausing the video in a MediaDocument.
https://bugs.webkit.org/show_bug.cgi?id=157625
Reviewed by Jer Noble.
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls):
(Controller.prototype.handlePlaceholderClick):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (200793 => 200794)
--- trunk/Source/WebCore/ChangeLog 2016-05-12 22:09:03 UTC (rev 200793)
+++ trunk/Source/WebCore/ChangeLog 2016-05-12 22:13:10 UTC (rev 200794)
@@ -1,3 +1,14 @@
+2016-05-12 Ada Chan <[email protected]>
+
+ Prevent clicks in the placeholder from playing or pausing the video in a MediaDocument.
+ https://bugs.webkit.org/show_bug.cgi?id=157625
+
+ Reviewed by Jer Noble.
+
+ * Modules/mediacontrols/mediaControlsApple.js:
+ (Controller.prototype.createControls):
+ (Controller.prototype.handlePlaceholderClick):
+
2016-05-12 Chris Dumez <[email protected]>
Drop toJS() overload taking a PassRefPtr<> parameter
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (200793 => 200794)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2016-05-12 22:09:03 UTC (rev 200793)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2016-05-12 22:13:10 UTC (rev 200794)
@@ -493,6 +493,8 @@
var inlinePlaybackPlaceholder = this.controls.inlinePlaybackPlaceholder = document.createElement('div');
inlinePlaybackPlaceholder.setAttribute('pseudo', '-webkit-media-controls-wireless-playback-status');
inlinePlaybackPlaceholder.setAttribute('aria-label', this.UIString('Video Playback Placeholder'));
+ this.listenFor(inlinePlaybackPlaceholder, 'click', this.handlePlaceholderClick);
+ this.listenFor(inlinePlaybackPlaceholder, 'dblclick', this.handlePlaceholderClick);
if (!Controller.gSimulatePictureInPictureAvailable)
inlinePlaybackPlaceholder.classList.add(this.ClassNames.hidden);
@@ -974,6 +976,12 @@
event.preventDefault();
},
+ handlePlaceholderClick: function(event)
+ {
+ // Prevent clicks in the placeholder from playing or pausing the video in a MediaDocument.
+ event.preventDefault();
+ },
+
handleRewindButtonClicked: function(event)
{
var newTime = Math.max(
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes