Title: [200809] trunk/Source/WebInspectorUI
Revision
200809
Author
[email protected]
Date
2016-05-12 21:19:21 -0700 (Thu, 12 May 2016)

Log Message

Web Inspector: Can't filter Rendering Frames by duration
https://bugs.webkit.org/show_bug.cgi?id=157654

Reviewed by Timothy Hatcher.

* UserInterface/Views/RenderingFrameTimelineView.js:
(WebInspector.RenderingFrameTimelineView.prototype._scopeBarSelectionDidChange):
Call filterDidChange on the grid, not the base class.
TimelineView.filterDidChange exists to let TimelineViews perform
additional work when the grid filter changes (see LayoutTimelineView).
(WebInspector.RenderingFrameTimelineView):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (200808 => 200809)


--- trunk/Source/WebInspectorUI/ChangeLog	2016-05-13 04:15:56 UTC (rev 200808)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-05-13 04:19:21 UTC (rev 200809)
@@ -1,3 +1,17 @@
+2016-05-12  Matt Baker  <[email protected]>
+
+        Web Inspector: Can't filter Rendering Frames by duration
+        https://bugs.webkit.org/show_bug.cgi?id=157654
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/RenderingFrameTimelineView.js:
+        (WebInspector.RenderingFrameTimelineView.prototype._scopeBarSelectionDidChange):
+        Call filterDidChange on the grid, not the base class.
+        TimelineView.filterDidChange exists to let TimelineViews perform
+        additional work when the grid filter changes (see LayoutTimelineView).
+        (WebInspector.RenderingFrameTimelineView):
+
 2016-05-12  Joseph Pecoraro  <[email protected]>
 
         Web Inspector: Deleting nodes in DOM Tree sometimes changes selection to parent instead of sibling

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js (200808 => 200809)


--- trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js	2016-05-13 04:15:56 UTC (rev 200808)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js	2016-05-13 04:19:21 UTC (rev 200809)
@@ -293,7 +293,7 @@
 
     _scopeBarSelectionDidChange()
     {
-        this.filterDidChange();
+        this._dataGrid.filterDidChange();
     }
 };
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to