Title: [200814] trunk/Source/WebCore
Revision
200814
Author
[email protected]
Date
2016-05-12 23:28:36 -0700 (Thu, 12 May 2016)

Log Message

Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation
https://bugs.webkit.org/show_bug.cgi?id=157662

Reviewed by Darin Adler.

Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation as
it is no longer needed after <http://trac.webkit.org/changeset/196678>.

JSC::getStaticPropertySlot() now properly checks for overrides *before*
checking the static table.

No new tests, no web-exposed behavior change.

* bindings/js/JSWorkerGlobalScopeCustom.cpp:
(WebCore::JSWorkerGlobalScope::getOwnPropertySlotDelegate): Deleted.
* workers/WorkerGlobalScope.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (200813 => 200814)


--- trunk/Source/WebCore/ChangeLog	2016-05-13 05:52:11 UTC (rev 200813)
+++ trunk/Source/WebCore/ChangeLog	2016-05-13 06:28:36 UTC (rev 200814)
@@ -1,3 +1,22 @@
+2016-05-12  Chris Dumez  <[email protected]>
+
+        Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation
+        https://bugs.webkit.org/show_bug.cgi?id=157662
+
+        Reviewed by Darin Adler.
+
+        Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation as
+        it is no longer needed after <http://trac.webkit.org/changeset/196678>.
+
+        JSC::getStaticPropertySlot() now properly checks for overrides *before*
+        checking the static table.
+
+        No new tests, no web-exposed behavior change.
+
+        * bindings/js/JSWorkerGlobalScopeCustom.cpp:
+        (WebCore::JSWorkerGlobalScope::getOwnPropertySlotDelegate): Deleted.
+        * workers/WorkerGlobalScope.idl:
+
 2016-05-12  Zan Dobersek  <[email protected]>
 
         CoordinatedGraphicsLayer::syncLayerState() should set the m_layerState.contentsOpaque flag

Modified: trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp (200813 => 200814)


--- trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp	2016-05-13 05:52:11 UTC (rev 200813)
+++ trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp	2016-05-13 06:28:36 UTC (rev 200814)
@@ -59,14 +59,6 @@
         visitor.addOpaqueRoot(navigator);
 }
 
-bool JSWorkerGlobalScope::getOwnPropertySlotDelegate(ExecState* exec, PropertyName propertyName, PropertySlot& slot)
-{
-    // Look for overrides before looking at any of our own properties.
-    if (JSGlobalObject::getOwnPropertySlot(this, exec, propertyName, slot))
-        return true;
-    return false;
-}
-
 JSValue JSWorkerGlobalScope::importScripts(ExecState& state)
 {
     if (!state.argumentCount())

Modified: trunk/Source/WebCore/workers/WorkerGlobalScope.idl (200813 => 200814)


--- trunk/Source/WebCore/workers/WorkerGlobalScope.idl	2016-05-13 05:52:11 UTC (rev 200813)
+++ trunk/Source/WebCore/workers/WorkerGlobalScope.idl	2016-05-13 06:28:36 UTC (rev 200814)
@@ -28,7 +28,6 @@
     Exposed=Worker,
     CustomProxyToJSObject,
     JSCustomMarkFunction,
-    JSCustomGetOwnPropertySlotAndDescriptor,
     JSLegacyParent=JSWorkerGlobalScopeBase,
 ] interface WorkerGlobalScope : EventTarget {
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to