Title: [200828] releases/WebKitGTK/webkit-2.12/Source/WebKit2
Revision
200828
Author
[email protected]
Date
2016-05-13 03:02:25 -0700 (Fri, 13 May 2016)

Log Message

Merge r199875 - NetworkCacheIOChannelSoup: detach the newly-created IOChannel::readSync thread
https://bugs.webkit.org/show_bug.cgi?id=156907

Reviewed by Carlos Garcia Campos.

* NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
(WebKit::NetworkCache::IOChannel::readSyncInThread): Detach the new thread,
ensuring the resources are released after the thread exits. Next step is
to set up a thread pool and use that, avoiding thread re-creation.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.12/Source/WebKit2/ChangeLog (200827 => 200828)


--- releases/WebKitGTK/webkit-2.12/Source/WebKit2/ChangeLog	2016-05-13 10:01:07 UTC (rev 200827)
+++ releases/WebKitGTK/webkit-2.12/Source/WebKit2/ChangeLog	2016-05-13 10:02:25 UTC (rev 200828)
@@ -1,3 +1,15 @@
+2016-04-22  Zan Dobersek  <[email protected]>
+
+        NetworkCacheIOChannelSoup: detach the newly-created IOChannel::readSync thread
+        https://bugs.webkit.org/show_bug.cgi?id=156907
+
+        Reviewed by Carlos Garcia Campos.
+
+        * NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
+        (WebKit::NetworkCache::IOChannel::readSyncInThread): Detach the new thread,
+        ensuring the resources are released after the thread exits. Next step is
+        to set up a thread pool and use that, avoiding thread re-creation.
+
 2016-04-28  Carlos Garcia Campos  <[email protected]>
 
         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.12.2 release.

Modified: releases/WebKitGTK/webkit-2.12/Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp (200827 => 200828)


--- releases/WebKitGTK/webkit-2.12/Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp	2016-05-13 10:01:07 UTC (rev 200827)
+++ releases/WebKitGTK/webkit-2.12/Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp	2016-05-13 10:02:25 UTC (rev 200828)
@@ -184,7 +184,7 @@
     ASSERT(!isMainThread());
 
     RefPtr<IOChannel> channel(this);
-    createThread("IOChannel::readSync", [channel, size, queue, completionHandler] {
+    detachThread(createThread("IOChannel::readSync", [channel, size, queue, completionHandler] {
         size_t bufferSize = std::min(size, gDefaultReadBufferSize);
         uint8_t* bufferData = static_cast<uint8_t*>(fastMalloc(bufferSize));
         GRefPtr<SoupBuffer> readBuffer = adoptGRef(soup_buffer_new_with_owner(bufferData, bufferSize, bufferData, fastFree));
@@ -218,7 +218,7 @@
             Data data = { WTFMove(buffer) };
             completionHandler(data, 0);
         }, queue);
-    });
+    }));
 }
 
 struct WriteAsyncData {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to