Title: [200841] releases/WebKitGTK/webkit-2.12
- Revision
- 200841
- Author
- [email protected]
- Date
- 2016-05-13 04:43:30 -0700 (Fri, 13 May 2016)
Log Message
Merge r200126 - [EFL][GTK] Volume slider only changes volume when thumb is released, not while dragging
https://bugs.webkit.org/show_bug.cgi?id=156970
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Volume slider have to change the volume while dragging the thumb.
Test: media/video-volume-slider-drag.html
* Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.createControls): Use the 'input' event instead of the 'change' to
check the changed value correctly.
(Controller.prototype.handleMaxButtonClicked):
(Controller.prototype.handleVolumeSliderInput): Renamed from handleVolumeSliderChange.
(Controller.prototype.handleVolumeSliderChange): Deleted.
LayoutTests:
Removed the passed test.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog (200840 => 200841)
--- releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-05-13 11:38:40 UTC (rev 200840)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-05-13 11:43:30 UTC (rev 200841)
@@ -1,3 +1,15 @@
+2016-04-27 Hunseop Jeong <[email protected]>
+
+ [EFL][GTK] Volume slider only changes volume when thumb is released, not while dragging
+ https://bugs.webkit.org/show_bug.cgi?id=156970
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ Removed the passed test.
+
+ * platform/efl/TestExpectations:
+ * platform/gtk/TestExpectations:
+
2016-04-25 Brent Fulgham <[email protected]>
Add port 4190 (managesieve) to port blacklist
Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/TestExpectations (200840 => 200841)
--- releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/TestExpectations 2016-05-13 11:38:40 UTC (rev 200840)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/TestExpectations 2016-05-13 11:43:30 UTC (rev 200841)
@@ -2295,7 +2295,6 @@
webkit.org/b/137109 accessibility/legend-children-are-visible.html [ Failure ]
webkit.org/b/137695 media/video-controls-audiotracks-trackmenu.html [ Failure ]
-webkit.org/b/138074 media/video-volume-slider-drag.html [ Failure ]
# Font is clipped incorrectly
webkit.org/b/138077 editing/caret/color-span-inside-editable-background.html [ ImageOnlyFailure ]
Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog (200840 => 200841)
--- releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-05-13 11:38:40 UTC (rev 200840)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-05-13 11:43:30 UTC (rev 200841)
@@ -1,3 +1,21 @@
+2016-04-27 Hunseop Jeong <[email protected]>
+
+ [EFL][GTK] Volume slider only changes volume when thumb is released, not while dragging
+ https://bugs.webkit.org/show_bug.cgi?id=156970
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ Volume slider have to change the volume while dragging the thumb.
+
+ Test: media/video-volume-slider-drag.html
+
+ * Modules/mediacontrols/mediaControlsBase.js:
+ (Controller.prototype.createControls): Use the 'input' event instead of the 'change' to
+ check the changed value correctly.
+ (Controller.prototype.handleMaxButtonClicked):
+ (Controller.prototype.handleVolumeSliderInput): Renamed from handleVolumeSliderChange.
+ (Controller.prototype.handleVolumeSliderChange): Deleted.
+
2016-04-26 Brent Fulgham <[email protected]>
GuardMalloc crash in WebCore::HTMLFrameElementBase::marginHeight()
Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js (200840 => 200841)
--- releases/WebKitGTK/webkit-2.12/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js 2016-05-13 11:38:40 UTC (rev 200840)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js 2016-05-13 11:43:30 UTC (rev 200841)
@@ -390,7 +390,7 @@
volume.min = 0;
volume.max = 1;
volume.step = .01;
- this.listenFor(volume, 'change', this.handleVolumeSliderChange);
+ this.listenFor(volume, 'input', this.handleVolumeSliderInput);
var captionButton = this.controls.captionButton = document.createElement('button');
captionButton.setAttribute('pseudo', '-webkit-media-controls-toggle-closed-captions-button');
@@ -820,7 +820,7 @@
this.video.volume = 1;
},
- handleVolumeSliderChange: function(event)
+ handleVolumeSliderInput: function(event)
{
if (this.video.muted) {
this.video.muted = false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
