Title: [200857] trunk/Source/WebCore
- Revision
- 200857
- Author
- [email protected]
- Date
- 2016-05-13 07:58:53 -0700 (Fri, 13 May 2016)
Log Message
Have the WorkerGlobalScope API return more references
https://bugs.webkit.org/show_bug.cgi?id=157663
Reviewed by Alexey Proskuryakov.
Have the WorkerGlobalScope API return more references instead of
pointers.
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::location):
(WebCore::WorkerGlobalScope::navigator):
* workers/WorkerGlobalScope.h:
(WebCore::WorkerGlobalScope::self):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (200856 => 200857)
--- trunk/Source/WebCore/ChangeLog 2016-05-13 14:28:30 UTC (rev 200856)
+++ trunk/Source/WebCore/ChangeLog 2016-05-13 14:58:53 UTC (rev 200857)
@@ -1,3 +1,19 @@
+2016-05-13 Chris Dumez <[email protected]>
+
+ Have the WorkerGlobalScope API return more references
+ https://bugs.webkit.org/show_bug.cgi?id=157663
+
+ Reviewed by Alexey Proskuryakov.
+
+ Have the WorkerGlobalScope API return more references instead of
+ pointers.
+
+ * workers/WorkerGlobalScope.cpp:
+ (WebCore::WorkerGlobalScope::location):
+ (WebCore::WorkerGlobalScope::navigator):
+ * workers/WorkerGlobalScope.h:
+ (WebCore::WorkerGlobalScope::self):
+
2016-05-13 Youenn Fablet <[email protected]>
DOMPromise should only restrict the resolution type
Modified: trunk/Source/WebCore/workers/WorkerGlobalScope.cpp (200856 => 200857)
--- trunk/Source/WebCore/workers/WorkerGlobalScope.cpp 2016-05-13 14:28:30 UTC (rev 200856)
+++ trunk/Source/WebCore/workers/WorkerGlobalScope.cpp 2016-05-13 14:58:53 UTC (rev 200857)
@@ -134,11 +134,11 @@
}
#endif // ENABLE(INDEXED_DATABASE)
-WorkerLocation* WorkerGlobalScope::location() const
+WorkerLocation& WorkerGlobalScope::location() const
{
if (!m_location)
m_location = WorkerLocation::create(m_url);
- return m_location.get();
+ return *m_location;
}
void WorkerGlobalScope::close()
@@ -158,11 +158,11 @@
} });
}
-WorkerNavigator* WorkerGlobalScope::navigator() const
+WorkerNavigator& WorkerGlobalScope::navigator() const
{
if (!m_navigator)
m_navigator = WorkerNavigator::create(m_userAgent);
- return m_navigator.get();
+ return *m_navigator;
}
void WorkerGlobalScope::postTask(Task task)
Modified: trunk/Source/WebCore/workers/WorkerGlobalScope.h (200856 => 200857)
--- trunk/Source/WebCore/workers/WorkerGlobalScope.h 2016-05-13 14:28:30 UTC (rev 200856)
+++ trunk/Source/WebCore/workers/WorkerGlobalScope.h 2016-05-13 14:58:53 UTC (rev 200857)
@@ -90,13 +90,13 @@
void postTask(Task) override; // Executes the task on context's thread asynchronously.
// WorkerGlobalScope
- WorkerGlobalScope* self() { return this; }
- WorkerLocation* location() const;
+ WorkerGlobalScope& self() { return *this; }
+ WorkerLocation& location() const;
void close();
// WorkerUtils
virtual void importScripts(const Vector<String>& urls, ExceptionCode&);
- WorkerNavigator* navigator() const;
+ WorkerNavigator& navigator() const;
// Timers
int setTimeout(std::unique_ptr<ScheduledAction>, int timeout);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
