Title: [200886] trunk/Source/WebInspectorUI
- Revision
- 200886
- Author
- [email protected]
- Date
- 2016-05-13 15:22:45 -0700 (Fri, 13 May 2016)
Log Message
Web Inspector: Typing "layout" in filter for Layout and Rendering Timeline matches everything
https://bugs.webkit.org/show_bug.cgi?id=157684
<rdar://problem/26276588>
Reviewed by Joseph Pecoraro.
Hidden columns should not participate in built-in grid filtering
using DataGrid.filterText. Hidden columns can still be custom filtered,
which is how TimelineDataGrid filters scopebar columns.
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGridNode.prototype.get filterableData):
Skip hidden columns.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (200885 => 200886)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-13 21:40:10 UTC (rev 200885)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-13 22:22:45 UTC (rev 200886)
@@ -1,5 +1,21 @@
2016-05-13 Matt Baker <[email protected]>
+ Web Inspector: Typing "layout" in filter for Layout and Rendering Timeline matches everything
+ https://bugs.webkit.org/show_bug.cgi?id=157684
+ <rdar://problem/26276588>
+
+ Reviewed by Joseph Pecoraro.
+
+ Hidden columns should not participate in built-in grid filtering
+ using DataGrid.filterText. Hidden columns can still be custom filtered,
+ which is how TimelineDataGrid filters scopebar columns.
+
+ * UserInterface/Views/DataGrid.js:
+ (WebInspector.DataGridNode.prototype.get filterableData):
+ Skip hidden columns.
+
+2016-05-13 Matt Baker <[email protected]>
+
Web Inspector: Script ProfileViews should be searchable
https://bugs.webkit.org/show_bug.cgi?id=157581
<rdar://problem/26228530>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (200885 => 200886)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2016-05-13 21:40:10 UTC (rev 200885)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2016-05-13 22:22:45 UTC (rev 200886)
@@ -1894,6 +1894,9 @@
this._cachedFilterableData = [];
for (let column of this.dataGrid.columns.values()) {
+ if (column.hidden)
+ continue;
+
let value = this.filterableDataForColumn(column.columnIdentifier);
if (!value)
continue;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
