Title: [201036] trunk/Source/WebCore
- Revision
- 201036
- Author
- [email protected]
- Date
- 2016-05-17 12:04:04 -0700 (Tue, 17 May 2016)
Log Message
Tidy unused parameters with build flags in isValidKeywordPropertyAndValue
https://bugs.webkit.org/show_bug.cgi?id=157780
<rdar://problem/26327312>
Reviewed by Alex Christensen.
CSS_COMPOSITING and CSS_REGIONS aren't runtime flags any more, so
don't need a parser context. Meanwhile CSS_GRID_LAYOUT does, even
though it wasn't in the condition for the UNUSED_PARAM.
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (201035 => 201036)
--- trunk/Source/WebCore/ChangeLog 2016-05-17 18:49:30 UTC (rev 201035)
+++ trunk/Source/WebCore/ChangeLog 2016-05-17 19:04:04 UTC (rev 201036)
@@ -1,3 +1,18 @@
+2016-05-16 Dean Jackson <[email protected]>
+
+ Tidy unused parameters with build flags in isValidKeywordPropertyAndValue
+ https://bugs.webkit.org/show_bug.cgi?id=157780
+ <rdar://problem/26327312>
+
+ Reviewed by Alex Christensen.
+
+ CSS_COMPOSITING and CSS_REGIONS aren't runtime flags any more, so
+ don't need a parser context. Meanwhile CSS_GRID_LAYOUT does, even
+ though it wasn't in the condition for the UNUSED_PARAM.
+
+ * css/CSSParser.cpp:
+ (WebCore::isValidKeywordPropertyAndValue):
+
2016-05-17 Chris Dumez <[email protected]>
Regression(r177786): GlyphMetricsMap<T>::locatePageSlowCase() fills existing pages with unknown metrics
Modified: trunk/Source/WebCore/css/CSSParser.cpp (201035 => 201036)
--- trunk/Source/WebCore/css/CSSParser.cpp 2016-05-17 18:49:30 UTC (rev 201035)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2016-05-17 19:04:04 UTC (rev 201036)
@@ -677,8 +677,6 @@
#if ENABLE(CSS_GRID_LAYOUT)
if (parserContext.cssGridLayoutEnabled && (valueID == CSSValueGrid || valueID == CSSValueInlineGrid))
return true;
-#else
- UNUSED_PARAM(parserContext);
#endif
break;
@@ -1049,7 +1047,7 @@
ASSERT_NOT_REACHED();
return false;
}
-#if !ENABLE(CSS_COMPOSITING) && !ENABLE(CSS_REGIONS)
+#if !ENABLE(CSS_GRID_LAYOUT)
UNUSED_PARAM(parserContext);
#endif
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
