Title: [201041] trunk/Websites/perf.webkit.org
- Revision
- 201041
- Author
- [email protected]
- Date
- 2016-05-17 14:17:28 -0700 (Tue, 17 May 2016)
Log Message
Add a subtitle under platform name in the summary page
https://bugs.webkit.org/show_bug.cgi?id=157809
Reviewed by Chris Dumez.
Add a description beneath the platform names.
* public/v3/pages/summary-page.js:
(SummaryPage.prototype._constructTable): Add a br and a span if subtitle is present.
(SummaryPage.cssTemplate): Added CSS rules for .subtitle.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (201040 => 201041)
--- trunk/Websites/perf.webkit.org/ChangeLog 2016-05-17 21:02:01 UTC (rev 201040)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2016-05-17 21:17:28 UTC (rev 201041)
@@ -1,3 +1,16 @@
+2016-05-17 Ryosuke Niwa <[email protected]>
+
+ Add a subtitle under platform name in the summary page
+ https://bugs.webkit.org/show_bug.cgi?id=157809
+
+ Reviewed by Chris Dumez.
+
+ Add a description beneath the platform names.
+
+ * public/v3/pages/summary-page.js:
+ (SummaryPage.prototype._constructTable): Add a br and a span if subtitle is present.
+ (SummaryPage.cssTemplate): Added CSS rules for .subtitle.
+
2016-05-13 Ryosuke Niwa <[email protected]>
v3 UI shows full git hash instead of the first 8 characters for a blame range
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js (201040 => 201041)
--- trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js 2016-05-17 21:02:01 UTC (rev 201040)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js 2016-05-17 21:17:28 UTC (rev 201041)
@@ -6,7 +6,7 @@
super('Summary', null);
this._table = {
- heading: summarySettings.platformGroups.map(function (platformGroup) { return platformGroup.name; }),
+ heading: summarySettings.platformGroups,
groups: [],
};
this._shouldConstructTable = true;
@@ -76,7 +76,14 @@
element('thead',
element('tr', [
element('td', {colspan: 2}),
- this._table.heading.map(function (label) { return element('td', label); }),
+ this._table.heading.map(function (group) {
+ var nodes = [group.name];
+ if (group.subtitle) {
+ nodes.push(element('br'));
+ nodes.push(element('span', {class: 'subtitle'}, group.subtitle));
+ }
+ return element('td', nodes);
+ }),
])),
this._table.groups.map(function (rowGroup) {
return element('tbody', rowGroup.rows.map(function (row, rowIndex) {
@@ -196,8 +203,16 @@
.summary-table thead td {
font-size: 1.2rem;
+ line-height: 1.3rem;
}
+ .summary-table .subtitle {
+ display: block;
+ font-size: 0.9rem;
+ line-height: 1.2rem;
+ color: #666;
+ }
+
.summary-table tbody td {
position: relative;
font-weight: inherit;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
