Title: [201064] trunk/Source/WebCore
- Revision
- 201064
- Author
- [email protected]
- Date
- 2016-05-17 18:26:11 -0700 (Tue, 17 May 2016)
Log Message
Unreviewed, fix Darin's post-mortem review comments for r201052.
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::findLegend):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (201063 => 201064)
--- trunk/Source/WebCore/ChangeLog 2016-05-18 01:05:04 UTC (rev 201063)
+++ trunk/Source/WebCore/ChangeLog 2016-05-18 01:26:11 UTC (rev 201064)
@@ -1,3 +1,12 @@
+2016-05-17 Chris Dumez <[email protected]>
+
+ Unreviewed, fix Darin's post-mortem review comments for r201052.
+
+ * rendering/RenderFieldset.cpp:
+ (WebCore::RenderFieldset::findLegend):
+ * rendering/svg/SVGRenderSupport.cpp:
+ (WebCore::SVGRenderSupport::layoutChildren):
+
2016-05-17 Beth Dakin <[email protected]>
Make handleAcceptedCandidate a public function
Modified: trunk/Source/WebCore/rendering/RenderFieldset.cpp (201063 => 201064)
--- trunk/Source/WebCore/rendering/RenderFieldset.cpp 2016-05-18 01:05:04 UTC (rev 201063)
+++ trunk/Source/WebCore/rendering/RenderFieldset.cpp 2016-05-18 01:26:11 UTC (rev 201064)
@@ -127,12 +127,12 @@
RenderBox* RenderFieldset::findLegend(FindLegendOption option)
{
- for (auto& legend : childrenOfType<RenderElement>(*this)) {
+ for (auto& legend : childrenOfType<RenderBox>(*this)) {
if (option == IgnoreFloatingOrOutOfFlow && legend.isFloatingOrOutOfFlowPositioned())
continue;
if (is<HTMLLegendElement>(legend.element()))
- return &downcast<RenderBox>(legend);
+ return &legend;
}
return nullptr;
}
Modified: trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp (201063 => 201064)
--- trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp 2016-05-18 01:05:04 UTC (rev 201063)
+++ trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp 2016-05-18 01:26:11 UTC (rev 201064)
@@ -266,7 +266,7 @@
needsLayout = true;
}
- if (layoutSizeChanged && is<SVGElement>(child.node())) {
+ if (layoutSizeChanged && is<SVGElement>(*child.node())) {
// When selfNeedsLayout is false and the layout size changed, we have to check whether this child uses relative lengths
auto& element = downcast<SVGElement>(*child.node());
if (element.hasRelativeLengths()) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
