Title: [97944] trunk/Source/WebCore
- Revision
- 97944
- Author
- jer.no...@apple.com
- Date
- 2011-10-20 00:20:55 -0700 (Thu, 20 Oct 2011)
Log Message
compositing/video tests time out on Lion
https://bugs.webkit.org/show_bug.cgi?id=70448
Reviewed by Eric Carlson.
Covered by existing tests.
AVFoundation will occasionally fill it's playback buffers before collecting enough
statistical information to answer YES to isLikelyToKeepUp. In this situation, set the
ready state to HAVE_ENOUGH_DATA, on the presumption that if the playback buffers are
full, playback will probably not stall.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::updateStates):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97943 => 97944)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 06:47:43 UTC (rev 97943)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 07:20:55 UTC (rev 97944)
@@ -1,3 +1,20 @@
+2011-10-19 Jer Noble <jer.no...@apple.com>
+
+ compositing/video tests time out on Lion
+ https://bugs.webkit.org/show_bug.cgi?id=70448
+
+ Reviewed by Eric Carlson.
+
+ Covered by existing tests.
+
+ AVFoundation will occasionally fill it's playback buffers before collecting enough
+ statistical information to answer YES to isLikelyToKeepUp. In this situation, set the
+ ready state to HAVE_ENOUGH_DATA, on the presumption that if the playback buffers are
+ full, playback will probably not stall.
+
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+ (WebCore::MediaPlayerPrivateAVFoundation::updateStates):
+
2011-10-19 Kentaro Hara <hara...@chromium.org>
MessageEvent.data can be stored as ScriptValue.
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (97943 => 97944)
--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2011-10-20 06:47:43 UTC (rev 97943)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2011-10-20 07:20:55 UTC (rev 97944)
@@ -450,10 +450,13 @@
break;
case MediaPlayerAVPlayerItemStatusPlaybackLikelyToKeepUp:
+ case MediaPlayerAVPlayerItemStatusPlaybackBufferFull:
+ // If the status becomes PlaybackBufferFull, loading stops and the status will not
+ // progress to LikelyToKeepUp. Set the readyState to HAVE_ENOUGH_DATA, on the
+ // presumption that if the playback buffer is full, playback will probably not stall.
m_readyState = MediaPlayer::HaveEnoughData;
break;
- case MediaPlayerAVPlayerItemStatusPlaybackBufferFull:
case MediaPlayerAVPlayerItemStatusReadyToPlay:
// If the readyState is already HaveEnoughData, don't go lower because of this state change.
if (m_readyState == MediaPlayer::HaveEnoughData)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
