Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (201100 => 201101)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-18 21:36:29 UTC (rev 201100)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-18 21:50:35 UTC (rev 201101)
@@ -1,5 +1,20 @@
2016-05-18 Brian Burg <[email protected]>
+ Web Inspector: InspectorFrontendAPI.setTimelineProfilingEnabled should not implicitly show Timelines tab
+ https://bugs.webkit.org/show_bug.cgi?id=157846
+
+ Reviewed by Timothy Hatcher.
+
+ Currently, if the Web Inspector opens for an in-progress or finished automation session,
+ it will always show the Timelines tab, disregarding any previous user view state. This
+ is annoying and is a bad user experience when trying to debug the same test repeatedly.
+
+ * UserInterface/Protocol/InspectorFrontendAPI.js:
+ (InspectorFrontendAPI.setTimelineProfilingEnabled): Don't implicitly show Timelines tab.
+ (InspectorFrontendAPI.showTimelines): Added. This is called explicitly when desired.
+
+2016-05-18 Brian Burg <[email protected]>
+
Web Inspector: DebuggerSidebarPanel doesn't need to help manage temporarily disabling breakpoints while capturing
https://bugs.webkit.org/show_bug.cgi?id=157854
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js (201100 => 201101)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js 2016-05-18 21:36:29 UTC (rev 201100)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js 2016-05-18 21:50:35 UTC (rev 201101)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013, 2016 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -47,12 +47,10 @@
if (WebInspector.timelineManager.isCapturing() === enabled)
return;
- if (enabled) {
- WebInspector.showTimelineTab();
+ if (enabled)
WebInspector.timelineManager.startCapturing();
- } else {
+ else
WebInspector.timelineManager.stopCapturing();
- }
},
setElementSelectionEnabled: function(enabled)
@@ -99,6 +97,11 @@
WebInspector.showResourcesTab();
},
+ showTimelines: function()
+ {
+ WebInspector.showTimelineTab();
+ },
+
showMainResourceForFrame: function(frameIdentifier)
{
WebInspector.showSourceCodeForFrame(frameIdentifier);
Modified: trunk/Source/WebKit2/ChangeLog (201100 => 201101)
--- trunk/Source/WebKit2/ChangeLog 2016-05-18 21:36:29 UTC (rev 201100)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-18 21:50:35 UTC (rev 201101)
@@ -1,3 +1,30 @@
+2016-05-18 Brian Burg <[email protected]>
+
+ Web Inspector: InspectorFrontendAPI.setTimelineProfilingEnabled should not implicitly show Timelines tab
+ https://bugs.webkit.org/show_bug.cgi?id=157846
+
+ Reviewed by Timothy Hatcher.
+
+ Add a separate ShowTimelines message to WebInspector and WebInspectorUI. Have the
+ start/stop profiling methods in public APIs explicitly call showTimelines() rather than
+ relying on InspectorFrontendAPI to do it.
+
+ * UIProcess/API/C/WKInspector.cpp:
+ (WKInspectorTogglePageProfiling):
+ * UIProcess/WebInspectorProxy.cpp:
+ (WebKit::WebInspectorProxy::showTimelines):
+ * UIProcess/WebInspectorProxy.h:
+ * WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
+ (WKBundleInspectorSetPageProfilingEnabled):
+ * WebProcess/WebPage/WebInspector.cpp:
+ (WebKit::WebInspector::showTimelines):
+ * WebProcess/WebPage/WebInspector.h:
+ * WebProcess/WebPage/WebInspector.messages.in:
+ * WebProcess/WebPage/WebInspectorUI.cpp:
+ (WebKit::WebInspectorUI::showTimelines):
+ * WebProcess/WebPage/WebInspectorUI.h:
+ * WebProcess/WebPage/WebInspectorUI.messages.in:
+
2016-05-18 Brady Eidson <[email protected]>
Modern IDB: Add support for server side closing of open database connections.
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKInspector.cpp (201100 => 201101)
--- trunk/Source/WebKit2/UIProcess/API/C/WKInspector.cpp 2016-05-18 21:36:29 UTC (rev 201100)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKInspector.cpp 2016-05-18 21:50:35 UTC (rev 201101)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010 Apple Inc. All rights reserved.
+ * Copyright (C) 2010, 2016 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -117,7 +117,7 @@
void WKInspectorTogglePageProfiling(WKInspectorRef inspectorRef)
{
- toImpl(inspectorRef)->show();
+ toImpl(inspectorRef)->showTimelines();
toImpl(inspectorRef)->togglePageProfiling();
}
Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (201100 => 201101)
--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2016-05-18 21:36:29 UTC (rev 201100)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2016-05-18 21:50:35 UTC (rev 201101)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010, 2014 Apple Inc. All rights reserved.
+ * Copyright (C) 2010, 2014, 2016 Apple Inc. All rights reserved.
* Portions Copyright (c) 2011 Motorola Mobility, Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
@@ -209,6 +209,16 @@
m_inspectedPage->process().send(Messages::WebInspector::ShowResources(), m_inspectedPage->pageID());
}
+void WebInspectorProxy::showTimelines()
+{
+ if (!m_inspectedPage)
+ return;
+
+ eagerlyCreateInspectorPage();
+
+ m_inspectedPage->process().send(Messages::WebInspector::ShowTimelines(), m_inspectedPage->pageID());
+}
+
void WebInspectorProxy::showMainResourceForFrame(WebFrameProxy* frame)
{
if (!m_inspectedPage)
Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h (201100 => 201101)
--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h 2016-05-18 21:36:29 UTC (rev 201100)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h 2016-05-18 21:50:35 UTC (rev 201101)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010, 2014 Apple Inc. All rights reserved.
+ * Copyright (C) 2010, 2014, 2016 Apple Inc. All rights reserved.
* Portions Copyright (c) 2011 Motorola Mobility, Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
@@ -117,6 +117,7 @@
void showConsole();
void showResources();
+ void showTimelines();
void showMainResourceForFrame(WebFrameProxy*);
AttachmentSide attachmentSide() const { return m_attachmentSide; }
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp (201100 => 201101)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp 2016-05-18 21:36:29 UTC (rev 201100)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp 2016-05-18 21:50:35 UTC (rev 201101)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2011 Apple Inc. All rights reserved.
+ * Copyright (C) 2011, 2016 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -55,7 +55,7 @@
void WKBundleInspectorSetPageProfilingEnabled(WKBundleInspectorRef inspectorRef, bool enabled)
{
- toImpl(inspectorRef)->show();
+ toImpl(inspectorRef)->showTimelines();
if (enabled)
toImpl(inspectorRef)->startPageProfiling();
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp (201100 => 201101)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp 2016-05-18 21:36:29 UTC (rev 201100)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp 2016-05-18 21:50:35 UTC (rev 201101)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010, 2014, 2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2010, 2014-2016 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -176,6 +176,15 @@
m_frontendConnection->send(Messages::WebInspectorUI::ShowResources(), 0);
}
+void WebInspector::showTimelines()
+{
+ if (!m_page->corePage())
+ return;
+
+ m_page->corePage()->inspectorController().show();
+ m_frontendConnection->send(Messages::WebInspectorUI::ShowTimelines(), 0);
+}
+
void WebInspector::showMainResourceForFrame(uint64_t frameIdentifier)
{
WebFrame* frame = WebProcess::singleton().webFrame(frameIdentifier);
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h (201100 => 201101)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h 2016-05-18 21:36:29 UTC (rev 201100)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h 2016-05-18 21:50:35 UTC (rev 201101)
@@ -69,6 +69,7 @@
void showConsole();
void showResources();
+ void showTimelines();
void showMainResourceForFrame(uint64_t frameIdentifier);
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.messages.in (201100 => 201101)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.messages.in 2016-05-18 21:36:29 UTC (rev 201100)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.messages.in 2016-05-18 21:50:35 UTC (rev 201101)
@@ -28,6 +28,7 @@
ShowConsole()
ShowResources()
+ ShowTimelines()
ShowMainResourceForFrame(uint64_t frameIdentifier)
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp (201100 => 201101)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2016-05-18 21:36:29 UTC (rev 201100)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2016-05-18 21:50:35 UTC (rev 201101)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2014 Apple Inc. All rights reserved.
+ * Copyright (C) 2014, 2016 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -223,6 +223,11 @@
m_frontendAPIDispatcher.dispatchCommand(ASCIILiteral("showResources"));
}
+void WebInspectorUI::showTimelines()
+{
+ m_frontendAPIDispatcher.dispatchCommand(ASCIILiteral("showTimelines"));
+}
+
void WebInspectorUI::showMainResourceForFrame(const String& frameIdentifier)
{
m_frontendAPIDispatcher.dispatchCommand(ASCIILiteral("showMainResourceForFrame"), frameIdentifier);
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h (201100 => 201101)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h 2016-05-18 21:36:29 UTC (rev 201100)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h 2016-05-18 21:50:35 UTC (rev 201101)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2014, 2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2014-2016 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -57,6 +57,7 @@
void showConsole();
void showResources();
+ void showTimelines();
void showMainResourceForFrame(const String& frameIdentifier);
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.messages.in (201100 => 201101)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.messages.in 2016-05-18 21:36:29 UTC (rev 201100)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.messages.in 2016-05-18 21:50:35 UTC (rev 201101)
@@ -1,4 +1,4 @@
-# Copyright (C) 2014 Apple Inc. All rights reserved.
+# Copyright (C) 2014, 2016 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -30,6 +30,7 @@
ShowConsole()
ShowResources()
+ ShowTimelines()
ShowMainResourceForFrame(String frameIdentifier)
