Title: [201158] trunk/Tools
Revision
201158
Author
[email protected]
Date
2016-05-19 05:03:16 -0700 (Thu, 19 May 2016)

Log Message

Slow JSC stress tests times out in 32 bit debug mode
https://bugs.webkit.org/show_bug.cgi?id=154964

Reviewed by Michael Catanzaro.

* Scripts/run-_javascript_core-tests:
(runJSCStressTests): Pass through the --debug option.
* Scripts/run-jsc-stress-tests: Increase the timeout for debug builds.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (201157 => 201158)


--- trunk/Tools/ChangeLog	2016-05-19 09:36:05 UTC (rev 201157)
+++ trunk/Tools/ChangeLog	2016-05-19 12:03:16 UTC (rev 201158)
@@ -1,3 +1,14 @@
+2016-05-19  Csaba Osztrogonác  <[email protected]>
+
+        Slow JSC stress tests times out in 32 bit debug mode
+        https://bugs.webkit.org/show_bug.cgi?id=154964
+
+        Reviewed by Michael Catanzaro.
+
+        * Scripts/run-_javascript_core-tests:
+        (runJSCStressTests): Pass through the --debug option.
+        * Scripts/run-jsc-stress-tests: Increase the timeout for debug builds.
+
 2016-05-18  Aakash Jain  <[email protected]>
 
         Remove underline from Status Bubbles on dashboard

Modified: trunk/Tools/Scripts/run-_javascript_core-tests (201157 => 201158)


--- trunk/Tools/Scripts/run-_javascript_core-tests	2016-05-19 09:36:05 UTC (rev 201157)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2016-05-19 12:03:16 UTC (rev 201158)
@@ -265,6 +265,10 @@
         shift @jscStressDriverCmd; # Remove /usr/bin/env
     }
 
+    if (configuration() eq "Debug") {
+        push(@jscStressDriverCmd, "--debug");
+    }
+
     if ($envVars ne "") {
             push(@jscStressDriverCmd, "--env-vars");
             push(@jscStressDriverCmd, $envVars);

Modified: trunk/Tools/Scripts/run-jsc-stress-tests (201157 => 201158)


--- trunk/Tools/Scripts/run-jsc-stress-tests	2016-05-19 09:36:05 UTC (rev 201157)
+++ trunk/Tools/Scripts/run-jsc-stress-tests	2016-05-19 12:03:16 UTC (rev 201158)
@@ -2012,9 +2012,10 @@
     end
 end
 
-if $enableFTL and ENV["JSCTEST_timeout"]
+if $enableFTL and ENV["JSCTEST_timeout"] or !ifJSCArgIsntProvidedAreWeReleaseBuild
     # Currently, using the FTL is a performance regression particularly in real
     # (i.e. non-loopy) benchmarks. Account for this in the timeout.
+    # Increase the timeout for debug builds too. (--debug command line option)
     ENV["JSCTEST_timeout"] = (ENV["JSCTEST_timeout"].to_i * 2).to_s
 end
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to