Title: [201177] trunk/Source/WebInspectorUI
- Revision
- 201177
- Author
- [email protected]
- Date
- 2016-05-19 13:22:19 -0700 (Thu, 19 May 2016)
Log Message
Web Inspector: Timelines "Edit" button should be right-aligned
https://bugs.webkit.org/show_bug.cgi?id=157909
rdar://problem/26373969
Reviewed by Joseph Pecoraro.
* UserInterface/Views/ButtonNavigationItem.css:
(.navigation-bar .item.button.text-only): Deleted height: auto. Now inherited.
* UserInterface/Views/NavigationBar.css:
(.navigation-bar .item): Change height to auto to support any NavigationBar height.
This is needed since the Timelines tab has a shorter NavigationBar height, and
flexible items were overflowing.
* UserInterface/Views/TextNavigationItem.css:
(.navigation-bar .item.text): Deleted height: auto. Now inherited.
* UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview): Add a FlexibleSpaceNavigationItem before the Edit button.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (201176 => 201177)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-19 20:09:47 UTC (rev 201176)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-19 20:22:19 UTC (rev 201177)
@@ -1,3 +1,22 @@
+2016-05-19 Timothy Hatcher <[email protected]>
+
+ Web Inspector: Timelines "Edit" button should be right-aligned
+ https://bugs.webkit.org/show_bug.cgi?id=157909
+ rdar://problem/26373969
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/ButtonNavigationItem.css:
+ (.navigation-bar .item.button.text-only): Deleted height: auto. Now inherited.
+ * UserInterface/Views/NavigationBar.css:
+ (.navigation-bar .item): Change height to auto to support any NavigationBar height.
+ This is needed since the Timelines tab has a shorter NavigationBar height, and
+ flexible items were overflowing.
+ * UserInterface/Views/TextNavigationItem.css:
+ (.navigation-bar .item.text): Deleted height: auto. Now inherited.
+ * UserInterface/Views/TimelineOverview.js:
+ (WebInspector.TimelineOverview): Add a FlexibleSpaceNavigationItem before the Edit button.
+
2016-05-19 Brian Burg <[email protected]>
Web Inspector: timelines should not update via requestAnimationFrame unless Web Inspector is visible
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.css (201176 => 201177)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.css 2016-05-19 20:09:47 UTC (rev 201176)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.css 2016-05-19 20:22:19 UTC (rev 201177)
@@ -38,7 +38,6 @@
border: 1px solid transparent;
border-radius: 3px;
text-align: center;
- height: auto;
}
.navigation-bar .item.button > .glyph {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.css (201176 => 201177)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.css 2016-05-19 20:09:47 UTC (rev 201176)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.css 2016-05-19 20:22:19 UTC (rev 201177)
@@ -43,6 +43,6 @@
align-items: center;
flex-wrap: wrap;
- height: 28px;
+ height: auto;
outline: none;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextNavigationItem.css (201176 => 201177)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TextNavigationItem.css 2016-05-19 20:09:47 UTC (rev 201176)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextNavigationItem.css 2016-05-19 20:22:19 UTC (rev 201177)
@@ -31,5 +31,4 @@
line-height: 11px;
color: hsl(0, 0%, 18%);
text-align: center;
- height: auto;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js (201176 => 201177)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2016-05-19 20:09:47 UTC (rev 201176)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2016-05-19 20:22:19 UTC (rev 201177)
@@ -64,6 +64,7 @@
let instrumentsNavigationBar = new WebInspector.NavigationBar;
instrumentsNavigationBar.element.classList.add("timelines");
+ instrumentsNavigationBar.addNavigationItem(new WebInspector.FlexibleSpaceNavigationItem);
instrumentsNavigationBar.addNavigationItem(this._editInstrumentsButton);
this.addSubview(instrumentsNavigationBar);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
