Title: [201190] trunk/Source/WebKit2
- Revision
- 201190
- Author
- [email protected]
- Date
- 2016-05-19 15:20:10 -0700 (Thu, 19 May 2016)
Log Message
Web Inspector: CRASH when closing a page while element selection mode is enabled via Develop menu
https://bugs.webkit.org/show_bug.cgi?id=157925
<rdar://problem/26259618>
Reviewed by Joseph Pecoraro.
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::elementSelectionChanged):
Null-check m_page->inspector() since it will return nullptr if the page
is closed but not yet destructed. This is triggered by teardown code
in InspectorDOMAgent::willDestroyFrontendAndBackend.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (201189 => 201190)
--- trunk/Source/WebKit2/ChangeLog 2016-05-19 22:19:48 UTC (rev 201189)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-19 22:20:10 UTC (rev 201190)
@@ -1,3 +1,17 @@
+2016-05-19 Brian Burg <[email protected]>
+
+ Web Inspector: CRASH when closing a page while element selection mode is enabled via Develop menu
+ https://bugs.webkit.org/show_bug.cgi?id=157925
+ <rdar://problem/26259618>
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
+ (WebKit::WebInspectorClient::elementSelectionChanged):
+ Null-check m_page->inspector() since it will return nullptr if the page
+ is closed but not yet destructed. This is triggered by teardown code
+ in InspectorDOMAgent::willDestroyFrontendAndBackend.
+
2016-05-19 Enrica Casucci <[email protected]>
Drag cannot start if no drag data is available in the Pasteboard.
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp (201189 => 201190)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2016-05-19 22:19:48 UTC (rev 201189)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2016-05-19 22:20:10 UTC (rev 201190)
@@ -194,7 +194,8 @@
void WebInspectorClient::elementSelectionChanged(bool active)
{
- m_page->inspector()->elementSelectionChanged(active);
+ if (m_page->inspector())
+ m_page->inspector()->elementSelectionChanged(active);
}
void WebInspectorClient::pageOverlayDestroyed(PageOverlay&)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
