Title: [201288] trunk/Tools
- Revision
- 201288
- Author
- beid...@apple.com
- Date
- 2016-05-23 09:46:38 -0700 (Mon, 23 May 2016)
Log Message
check-webkit-style gets flags std::literals::chrono_literals as bad naming.
https://bugs.webkit.org/show_bug.cgi?id=157969
Reviewed by Alex Christensen.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_names):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (201287 => 201288)
--- trunk/Tools/ChangeLog 2016-05-23 16:41:01 UTC (rev 201287)
+++ trunk/Tools/ChangeLog 2016-05-23 16:46:38 UTC (rev 201288)
@@ -1,3 +1,15 @@
+2016-05-23 Brady Eidson <beid...@apple.com>
+
+ check-webkit-style gets flags std::literals::chrono_literals as bad naming.
+ https://bugs.webkit.org/show_bug.cgi?id=157969
+
+ Reviewed by Alex Christensen.
+
+ * Scripts/webkitpy/style/checkers/cpp.py:
+ (check_identifier_name_in_declaration):
+ * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+ (WebKitStyleTest.test_names):
+
2016-05-22 Alexey Proskuryakov <a...@apple.com>
RELEASE_ASSERT(TestController::singleton().isCurrentInvocation(testInvocation)) is sometimes hit when running tests
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (201287 => 201288)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2016-05-23 16:41:01 UTC (rev 201287)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2016-05-23 16:46:38 UTC (rev 201288)
@@ -3400,7 +3400,8 @@
and not modified_identifier.find('::_q_') >= 0
and not modified_identifier == "const_iterator"
and not modified_identifier == "vm_throw"
- and not modified_identifier == "DFG_OPERATION"):
+ and not modified_identifier == "DFG_OPERATION"
+ and not modified_identifier.find('chrono_literals') >= 0):
error(line_number, 'readability/naming/underscores', 4, identifier + " is incorrectly named. Don't use underscores in your identifier names.")
# Check for variables named 'l', these are too easy to confuse with '1' in some fonts
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (201287 => 201288)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2016-05-23 16:41:01 UTC (rev 201287)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2016-05-23 16:46:38 UTC (rev 201288)
@@ -5172,6 +5172,9 @@
# const_iterator is allowed as well.
self.assert_lint('typedef VectorType::const_iterator const_iterator;', '')
+ # chrono_literals is allowed as well.
+ self.assert_lint('using namespace std::literals::chrono_literals;', '')
+
# vm_throw is allowed as well.
self.assert_lint('int vm_throw;', '')
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
