Title: [201434] trunk/Tools
- Revision
- 201434
- Author
- [email protected]
- Date
- 2016-05-26 15:03:34 -0700 (Thu, 26 May 2016)
Log Message
Unreviewed test fix after r201427.
https://bugs.webkit.org/show_bug.cgi?id=157423
<rdar://problem/23751632>
A debug assertion was firing during some test runs due to the Geolocation permission
being turned off during the test. The timer logic was originally written to assert
if the timer fired when permissions were disabled. But this is no longer valid,
because we expect the Geolocation system to be active and become deactivated if the
browsing context violates one of the security criteria.
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate timerFired]): Remove invalid assertion.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (201433 => 201434)
--- trunk/Tools/ChangeLog 2016-05-26 21:58:42 UTC (rev 201433)
+++ trunk/Tools/ChangeLog 2016-05-26 22:03:34 UTC (rev 201434)
@@ -1,3 +1,18 @@
+2016-05-26 Brent Fulgham <[email protected]>
+
+ Unreviewed test fix after r201427.
+ https://bugs.webkit.org/show_bug.cgi?id=157423
+ <rdar://problem/23751632>
+
+ A debug assertion was firing during some test runs due to the Geolocation permission
+ being turned off during the test. The timer logic was originally written to assert
+ if the timer fired when permissions were disabled. But this is no longer valid,
+ because we expect the Geolocation system to be active and become deactivated if the
+ browsing context violates one of the security criteria.
+
+ * DumpRenderTree/mac/UIDelegate.mm:
+ (-[UIDelegate timerFired]): Remove invalid assertion.
+
2016-05-26 Filip Pizlo <[email protected]>
ScopedLambda should have a lifetime story that makes sense to the compiler
Modified: trunk/Tools/DumpRenderTree/mac/UIDelegate.mm (201433 => 201434)
--- trunk/Tools/DumpRenderTree/mac/UIDelegate.mm 2016-05-26 21:58:42 UTC (rev 201433)
+++ trunk/Tools/DumpRenderTree/mac/UIDelegate.mm 2016-05-26 22:03:34 UTC (rev 201434)
@@ -266,7 +266,6 @@
- (void)timerFired
{
- ASSERT(gTestRunner->isGeolocationPermissionSet());
m_timer = 0;
NSEnumerator* enumerator = [m_pendingGeolocationPermissionListeners objectEnumerator];
id<WebAllowDenyPolicyListener> listener;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
