Title: [201438] trunk/Source/WebInspectorUI
- Revision
- 201438
- Author
- [email protected]
- Date
- 2016-05-26 16:05:09 -0700 (Thu, 26 May 2016)
Log Message
Uncaught Exception: TypeError: undefined is not an object (evaluating 'records[endIndex].endTime')
https://bugs.webkit.org/show_bug.cgi?id=158057
Reviewed by Timothy Hatcher.
* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._updateTimelineViewTimes):
When the entire recording is selected, rendering frames should use the
record count as its end time instead of the recording's end time.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (201437 => 201438)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-26 23:03:49 UTC (rev 201437)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-26 23:05:09 UTC (rev 201438)
@@ -1,3 +1,15 @@
+2016-05-26 Matt Baker <[email protected]>
+
+ Uncaught Exception: TypeError: undefined is not an object (evaluating 'records[endIndex].endTime')
+ https://bugs.webkit.org/show_bug.cgi?id=158057
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/TimelineRecordingContentView.js:
+ (WebInspector.TimelineRecordingContentView.prototype._updateTimelineViewTimes):
+ When the entire recording is selected, rendering frames should use the
+ record count as its end time instead of the recording's end time.
+
2016-05-25 Joseph Pecoraro <[email protected]>
Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'collectionData.affectedSnapshots')
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (201437 => 201438)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2016-05-26 23:03:49 UTC (rev 201437)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2016-05-26 23:05:09 UTC (rev 201438)
@@ -727,12 +727,15 @@
let endTime = this._timelineOverview.selectionStartTime + this._timelineOverview.selectionDuration;
if (entireRangeSelected) {
- // Clamp selection to the end of the recording (with padding), so that OverviewTimelineView
- // displays an autosized graph without a lot of horizontal white space or tiny graph bars.
- if (isNaN(this._recording.endTime))
- endTime = this._currentTime;
- else
- endTime = Math.min(endTime, this._recording.endTime + timelineRuler.minimumSelectionDuration);
+ if (timelineView instanceof WebInspector.RenderingFrameTimelineView) {
+ endTime = this._renderingFrameTimeline.records.length;
+ } else {
+ // Clamp selection to the end of the recording (with padding),
+ // so graph views will show an auto-sized graph without a lot of
+ // empty space at the end.
+ endTime = isNaN(this._recording.endTime) ? this._recording.currentTime : this._recording.endTime;
+ endTime += timelineRuler.minimumSelectionDuration;
+ }
}
timelineView.startTime = this._timelineOverview.selectionStartTime;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
