Title: [201567] trunk/Source/WebCore
- Revision
- 201567
- Author
- [email protected]
- Date
- 2016-06-01 13:55:30 -0700 (Wed, 01 Jun 2016)
Log Message
setVideoFullscreenGravity() has no effect on the fullscreen video layer
https://bugs.webkit.org/show_bug.cgi?id=158267
Reviewed by Eric Carlson.
When we moved to a 2-AVPlayerLayer solution, we didn't update setVideoFullscreenGravity()
to change the correct layer's videoGravity property.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (201566 => 201567)
--- trunk/Source/WebCore/ChangeLog 2016-06-01 20:32:57 UTC (rev 201566)
+++ trunk/Source/WebCore/ChangeLog 2016-06-01 20:55:30 UTC (rev 201567)
@@ -1,3 +1,16 @@
+2016-06-01 Jer Noble <[email protected]>
+
+ setVideoFullscreenGravity() has no effect on the fullscreen video layer
+ https://bugs.webkit.org/show_bug.cgi?id=158267
+
+ Reviewed by Eric Carlson.
+
+ When we moved to a 2-AVPlayerLayer solution, we didn't update setVideoFullscreenGravity()
+ to change the correct layer's videoGravity property.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity):
+
2016-06-01 Alex Christensen <[email protected]>
Fix null dereferencing in ResourceTimingInformation::addResourceTiming
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (201566 => 201567)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2016-06-01 20:32:57 UTC (rev 201566)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2016-06-01 20:55:30 UTC (rev 201567)
@@ -1218,7 +1218,9 @@
void MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity(MediaPlayer::VideoGravity gravity)
{
m_videoFullscreenGravity = gravity;
- if (!m_videoLayer)
+
+ auto activeLayer = m_secondaryVideoLayer.get() ?: m_videoLayer.get();
+ if (!activeLayer)
return;
NSString *videoGravity = AVLayerVideoGravityResizeAspect;
@@ -1231,10 +1233,10 @@
else
ASSERT_NOT_REACHED();
- if ([m_videoLayer videoGravity] == videoGravity)
+ if ([activeLayer videoGravity] == videoGravity)
return;
- [m_videoLayer setVideoGravity:videoGravity];
+ [activeLayer setVideoGravity:videoGravity];
syncTextTrackBounds();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
