Title: [201574] trunk/Source/WebCore
- Revision
- 201574
- Author
- [email protected]
- Date
- 2016-06-01 15:49:07 -0700 (Wed, 01 Jun 2016)
Log Message
REGRESSION(r201385) ASSERT in WebCore::HTMLMediaElement::updateActiveTextTrackCues + 5688
https://bugs.webkit.org/show_bug.cgi?id=158164
<rdar://problem/26498634>
Reviewed by Jer Noble.
No new tests, this prevents an assert in existing tests.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Call beginIgnoringTrackDisplayUpdateRequests
so we avoid doing unnecessary work triggered by destruction.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (201573 => 201574)
--- trunk/Source/WebCore/ChangeLog 2016-06-01 22:22:04 UTC (rev 201573)
+++ trunk/Source/WebCore/ChangeLog 2016-06-01 22:49:07 UTC (rev 201574)
@@ -1,3 +1,17 @@
+2016-06-01 Eric Carlson <[email protected]>
+
+ REGRESSION(r201385) ASSERT in WebCore::HTMLMediaElement::updateActiveTextTrackCues + 5688
+ https://bugs.webkit.org/show_bug.cgi?id=158164
+ <rdar://problem/26498634>
+
+ Reviewed by Jer Noble.
+
+ No new tests, this prevents an assert in existing tests.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::~HTMLMediaElement): Call beginIgnoringTrackDisplayUpdateRequests
+ so we avoid doing unnecessary work triggered by destruction.
+
2016-06-01 Dean Jackson <[email protected]>
Fix iOS build.
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (201573 => 201574)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2016-06-01 22:22:04 UTC (rev 201573)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2016-06-01 22:49:07 UTC (rev 201574)
@@ -497,6 +497,7 @@
{
LOG(Media, "HTMLMediaElement::~HTMLMediaElement(%p)", this);
+ beginIgnoringTrackDisplayUpdateRequests();
allMediaElements().remove(this);
m_asyncEventQueue.close();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
