Title: [201611] trunk/Source
- Revision
- 201611
- Author
- [email protected]
- Date
- 2016-06-02 12:40:20 -0700 (Thu, 02 Jun 2016)
Log Message
Use "= delete" for Locker(int)
Rubber stamped by Saam Barati.
Source/_javascript_Core:
* runtime/ConcurrentJITLock.h:
(JSC::ConcurrentJITLocker::ConcurrentJITLocker):
Source/WTF:
See discussion: https://bugs.webkit.org/show_bug.cgi?id=158306#c8
* wtf/Locker.h:
(WTF::Locker::Locker):
(WTF::Locker::~Locker):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (201610 => 201611)
--- trunk/Source/_javascript_Core/ChangeLog 2016-06-02 19:36:59 UTC (rev 201610)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-06-02 19:40:20 UTC (rev 201611)
@@ -1,3 +1,12 @@
+2016-06-02 Filip Pizlo <[email protected]>
+
+ Use "= delete" for Locker(int)
+
+ Rubber stamped by Saam Barati.
+
+ * runtime/ConcurrentJITLock.h:
+ (JSC::ConcurrentJITLocker::ConcurrentJITLocker):
+
2016-06-02 Keith Miller <[email protected]>
ObjectPropertyCondition should have a isStillValidAssumingImpurePropertyWatchpoint function
Modified: trunk/Source/_javascript_Core/runtime/ConcurrentJITLock.h (201610 => 201611)
--- trunk/Source/_javascript_Core/runtime/ConcurrentJITLock.h 2016-06-02 19:36:59 UTC (rev 201610)
+++ trunk/Source/_javascript_Core/runtime/ConcurrentJITLock.h 2016-06-02 19:40:20 UTC (rev 201611)
@@ -132,14 +132,7 @@
{
}
- NO_RETURN_DUE_TO_CRASH ConcurrentJITLocker(int)
- : ConcurrentJITLockerBase(NoLockingNecessary)
-#if ENABLE(CONCURRENT_JIT) && !defined(NDEBUG)
- , m_disallowGC(Nullopt)
-#endif
- {
- RELEASE_ASSERT_NOT_REACHED();
- }
+ ConcurrentJITLocker(int) = delete;
#if ENABLE(CONCURRENT_JIT) && !defined(NDEBUG)
private:
Modified: trunk/Source/WTF/ChangeLog (201610 => 201611)
--- trunk/Source/WTF/ChangeLog 2016-06-02 19:36:59 UTC (rev 201610)
+++ trunk/Source/WTF/ChangeLog 2016-06-02 19:40:20 UTC (rev 201611)
@@ -1,5 +1,17 @@
2016-06-02 Filip Pizlo <[email protected]>
+ Use "= delete" for Locker(int)
+
+ Rubber stamped by Saam Barati.
+
+ See discussion: https://bugs.webkit.org/show_bug.cgi?id=158306#c8
+
+ * wtf/Locker.h:
+ (WTF::Locker::Locker):
+ (WTF::Locker::~Locker):
+
+2016-06-02 Filip Pizlo <[email protected]>
+
Make it harder to accidentally pass an integer to a locker.
Rubber stamped by Keith Miller.
Modified: trunk/Source/WTF/wtf/Locker.h (201610 => 201611)
--- trunk/Source/WTF/wtf/Locker.h 2016-06-02 19:36:59 UTC (rev 201610)
+++ trunk/Source/WTF/wtf/Locker.h 2016-06-02 19:40:20 UTC (rev 201611)
@@ -48,10 +48,7 @@
// be accessed concurrently.
Locker(NoLockingNecessaryTag) : m_lockable(nullptr) { }
- NO_RETURN_DUE_TO_CRASH Locker(int)
- {
- RELEASE_ASSERT_NOT_REACHED();
- }
+ Locker(int) = delete;
~Locker()
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
