Title: [201639] trunk
- Revision
- 201639
- Author
- [email protected]
- Date
- 2016-06-03 00:52:13 -0700 (Fri, 03 Jun 2016)
Log Message
REGRESSION: WebGL doesn't show up in CSS reflections
https://bugs.webkit.org/show_bug.cgi?id=76489
Patch by Antoine Quint <[email protected]> on 2016-06-03
Reviewed by Dean Jackson.
Source/WebCore:
The WebGLLayer needs to notify its owning GraphicsLayer that it was displayed
such that its clones, in GraphicsLayerCA::layerDidDisplay, may have their contents
updated to match that layer's contents. The test at compositing/webgl/webgl-reflection.html
already covers this test and its expectation on Mac has been updated.
* platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer display]):
LayoutTests:
Update the expected rendering to contain the reflected WebGL <canvas>.
* platform/mac/compositing/webgl/webgl-reflection-expected.png:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (201638 => 201639)
--- trunk/LayoutTests/ChangeLog 2016-06-03 07:10:04 UTC (rev 201638)
+++ trunk/LayoutTests/ChangeLog 2016-06-03 07:52:13 UTC (rev 201639)
@@ -1,3 +1,14 @@
+2016-06-03 Antoine Quint <[email protected]>
+
+ REGRESSION: WebGL doesn't show up in CSS reflections
+ https://bugs.webkit.org/show_bug.cgi?id=76489
+
+ Reviewed by Dean Jackson.
+
+ Update the expected rendering to contain the reflected WebGL <canvas>.
+
+ * platform/mac/compositing/webgl/webgl-reflection-expected.png:
+
2016-06-02 Zalan Bujtas <[email protected]>
Repaint issue with vertical text in an out of flow container.
Modified: trunk/LayoutTests/platform/mac/compositing/webgl/webgl-reflection-expected.png
(Binary files differ)
Modified: trunk/Source/WebCore/ChangeLog (201638 => 201639)
--- trunk/Source/WebCore/ChangeLog 2016-06-03 07:10:04 UTC (rev 201638)
+++ trunk/Source/WebCore/ChangeLog 2016-06-03 07:52:13 UTC (rev 201639)
@@ -1,3 +1,18 @@
+2016-06-03 Antoine Quint <[email protected]>
+
+ REGRESSION: WebGL doesn't show up in CSS reflections
+ https://bugs.webkit.org/show_bug.cgi?id=76489
+
+ Reviewed by Dean Jackson.
+
+ The WebGLLayer needs to notify its owning GraphicsLayer that it was displayed
+ such that its clones, in GraphicsLayerCA::layerDidDisplay, may have their contents
+ updated to match that layer's contents. The test at compositing/webgl/webgl-reflection.html
+ already covers this test and its expectation on Mac has been updated.
+
+ * platform/graphics/mac/WebGLLayer.mm:
+ (-[WebGLLayer display]):
+
2016-06-02 Gavin Barraclough <[email protected]>
Refactor showModalDialog handling in JSDOMWindowCustom
Modified: trunk/Source/WebCore/platform/graphics/mac/WebGLLayer.mm (201638 => 201639)
--- trunk/Source/WebCore/platform/graphics/mac/WebGLLayer.mm 2016-06-03 07:10:04 UTC (rev 201638)
+++ trunk/Source/WebCore/platform/graphics/mac/WebGLLayer.mm 2016-06-03 07:52:13 UTC (rev 201639)
@@ -32,6 +32,8 @@
#import "GraphicsContext3D.h"
#import "GraphicsContextCG.h"
#import "GraphicsLayer.h"
+#import "GraphicsLayerCA.h"
+#import "PlatformCALayer.h"
#import <wtf/FastMalloc.h>
#import <wtf/RetainPtr.h>
@@ -179,6 +181,9 @@
[super display];
#endif
_context->markLayerComposited();
+ PlatformCALayer* layer = PlatformCALayer::platformCALayer(self);
+ if (layer && layer->owner())
+ layer->owner()->platformCALayerLayerDidDisplay(layer);
}
@end
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
