Title: [201652] trunk/LayoutTests
Revision
201652
Author
[email protected]
Date
2016-06-03 12:28:34 -0700 (Fri, 03 Jun 2016)

Log Message

storage/indexeddb/intversion-open-in-upgradeneeded.html is flaky on mac.
https://bugs.webkit.org/show_bug.cgi?id=155050

Reviewed by Alex Christensen.

The test no longer crashes/times out, but it does have text failures.
Resolve them by removing a race in the test itself.

* platform/mac-wk2/TestExpectations:
* storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt:
* storage/indexeddb/intversion-open-in-upgradeneeded-private-expected.txt:
* storage/indexeddb/resources/intversion-open-in-upgradeneeded.js:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (201651 => 201652)


--- trunk/LayoutTests/ChangeLog	2016-06-03 18:42:11 UTC (rev 201651)
+++ trunk/LayoutTests/ChangeLog	2016-06-03 19:28:34 UTC (rev 201652)
@@ -1,3 +1,18 @@
+2016-06-03  Brady Eidson  <[email protected]>
+
+        storage/indexeddb/intversion-open-in-upgradeneeded.html is flaky on mac.
+        https://bugs.webkit.org/show_bug.cgi?id=155050
+
+        Reviewed by Alex Christensen.
+
+        The test no longer crashes/times out, but it does have text failures.
+        Resolve them by removing a race in the test itself.
+        
+        * platform/mac-wk2/TestExpectations:
+        * storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt:
+        * storage/indexeddb/intversion-open-in-upgradeneeded-private-expected.txt:
+        * storage/indexeddb/resources/intversion-open-in-upgradeneeded.js:
+
 2016-06-03  Antoine Quint  <[email protected]>
 
         Reflection of element does not respect backdrop-filter property

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (201651 => 201652)


--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2016-06-03 18:42:11 UTC (rev 201651)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2016-06-03 19:28:34 UTC (rev 201652)
@@ -298,8 +298,6 @@
 
 webkit.org/b/152492 [ Debug ] inspector/debugger/break-on-exception-catch.html [ Pass Timeout ]
 
-webkit.org/b/155050 storage/indexeddb/intversion-open-in-upgradeneeded.html [ Pass Crash Failure ]
-
 webkit.org/b/155138 [ Yosemite ElCapitan ] inspector/console/addInspectedNode.html [ Pass Timeout ]
 
 webkit.org/b/154606 [ Release Yosemite ] imported/w3c/web-platform-tests/IndexedDB/idbcursor-advance-continue-async.htm [ Pass Timeout ]

Modified: trunk/LayoutTests/storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt (201651 => 201652)


--- trunk/LayoutTests/storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt	2016-06-03 18:42:11 UTC (rev 201651)
+++ trunk/LayoutTests/storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt	2016-06-03 19:28:34 UTC (rev 201652)
@@ -19,7 +19,6 @@
 request = indexedDB.open(dbname, 3)
 request._onupgradeneeded_ = upgradeNeeded2
 request._onsuccess_ = openSuccess2
-request._onblocked_ = onBlocked
 
 transactionOnComplete():
 sawTransactionComplete = true
@@ -34,8 +33,6 @@
 onVersionChange():
 db.close()
 
-onBlocked():
-
 upgradeNeeded2():
 db = event.target.result
 PASS event.newVersion is 3

Modified: trunk/LayoutTests/storage/indexeddb/intversion-open-in-upgradeneeded-private-expected.txt (201651 => 201652)


--- trunk/LayoutTests/storage/indexeddb/intversion-open-in-upgradeneeded-private-expected.txt	2016-06-03 18:42:11 UTC (rev 201651)
+++ trunk/LayoutTests/storage/indexeddb/intversion-open-in-upgradeneeded-private-expected.txt	2016-06-03 19:28:34 UTC (rev 201652)
@@ -19,7 +19,6 @@
 request = indexedDB.open(dbname, 3)
 request._onupgradeneeded_ = upgradeNeeded2
 request._onsuccess_ = openSuccess2
-request._onblocked_ = onBlocked
 
 transactionOnComplete():
 sawTransactionComplete = true
@@ -34,8 +33,6 @@
 onVersionChange():
 db.close()
 
-onBlocked():
-
 upgradeNeeded2():
 db = event.target.result
 PASS event.newVersion is 3

Modified: trunk/LayoutTests/storage/indexeddb/resources/intversion-open-in-upgradeneeded.js (201651 => 201652)


--- trunk/LayoutTests/storage/indexeddb/resources/intversion-open-in-upgradeneeded.js	2016-06-03 18:42:11 UTC (rev 201651)
+++ trunk/LayoutTests/storage/indexeddb/resources/intversion-open-in-upgradeneeded.js	2016-06-03 19:28:34 UTC (rev 201652)
@@ -44,7 +44,6 @@
     evalAndLog("request = indexedDB.open(dbname, 3)");
     evalAndLog("request._onupgradeneeded_ = upgradeNeeded2");
     evalAndLog("request._onsuccess_ = openSuccess2");
-    evalAndLog("request._onblocked_ = onBlocked");
     request._onerror_ = unexpectedErrorCallback;
 }
 
@@ -64,11 +63,6 @@
     evalAndLog("db.close()");
 }
 
-function onBlocked(evt)
-{
-    preamble(evt);
-}
-
 function upgradeNeeded2(evt)
 {
     preamble(evt);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to