Title: [201716] trunk/Source/_javascript_Core
Revision
201716
Author
[email protected]
Date
2016-06-06 11:09:20 -0700 (Mon, 06 Jun 2016)

Log Message

[jsc][mips] Implement absDouble()
https://bugs.webkit.org/show_bug.cgi?id=158206

Patch by Guillaume Emont <[email protected]> on 2016-06-06
Reviewed by Mark Lam.

Implement absDouble() for MIPS. This is needed because Math.pow() uses
it since r200208.

* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::absd):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::absDouble):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (201715 => 201716)


--- trunk/Source/_javascript_Core/ChangeLog	2016-06-06 17:56:33 UTC (rev 201715)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-06-06 18:09:20 UTC (rev 201716)
@@ -1,3 +1,18 @@
+2016-06-06  Guillaume Emont  <[email protected]>
+
+        [jsc][mips] Implement absDouble()
+        https://bugs.webkit.org/show_bug.cgi?id=158206
+
+        Reviewed by Mark Lam.
+
+        Implement absDouble() for MIPS. This is needed because Math.pow() uses
+        it since r200208.
+
+        * assembler/MIPSAssembler.h:
+        (JSC::MIPSAssembler::absd):
+        * assembler/MacroAssemblerMIPS.h:
+        (JSC::MacroAssemblerMIPS::absDouble):
+
 2016-06-03  Oliver Hunt  <[email protected]>
 
         RegExp unicode parsing reads an extra character before failing

Modified: trunk/Source/_javascript_Core/assembler/MIPSAssembler.h (201715 => 201716)


--- trunk/Source/_javascript_Core/assembler/MIPSAssembler.h	2016-06-06 17:56:33 UTC (rev 201715)
+++ trunk/Source/_javascript_Core/assembler/MIPSAssembler.h	2016-06-06 18:09:20 UTC (rev 201716)
@@ -547,6 +547,11 @@
         emitInst(0x46200004 | (fd << OP_SH_FD) | (fs << OP_SH_FS));
     }
 
+    void absd(FPRegisterID fd, FPRegisterID fs)
+    {
+        emitInst(0x46200005 | (fd << OP_SH_FD) | (fs << OP_SH_FS));
+    }
+
     void movd(FPRegisterID fd, FPRegisterID fs)
     {
         emitInst(0x46200006 | (fd << OP_SH_FD) | (fs << OP_SH_FS));

Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h (201715 => 201716)


--- trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h	2016-06-06 17:56:33 UTC (rev 201715)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h	2016-06-06 18:09:20 UTC (rev 201716)
@@ -641,10 +641,10 @@
     {
         m_assembler.sqrtd(dst, src);
     }
-    
-    void absDouble(FPRegisterID, FPRegisterID)
+
+    void absDouble(FPRegisterID src, FPRegisterID dst)
     {
-        RELEASE_ASSERT_NOT_REACHED();
+        m_assembler.absd(dst, src);
     }
 
     NO_RETURN_DUE_TO_CRASH void ceilDouble(FPRegisterID, FPRegisterID)
@@ -1275,7 +1275,16 @@
         return false;
 #endif
     }
-    static bool supportsFloatingPointAbs() { return false; }
+
+    static bool supportsFloatingPointAbs()
+    {
+#if WTF_MIPS_DOUBLE_FLOAT && WTF_MIPS_ISA_AT_LEAST(2)
+        return true;
+#else
+        return false;
+#endif
+    }
+
     static bool supportsFloatingPointRounding() { return false; }
 
     // Stack manipulation operations:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to