- Revision
- 201721
- Author
- [email protected]
- Date
- 2016-06-06 12:23:29 -0700 (Mon, 06 Jun 2016)
Log Message
Remove unused ResourceResponse::platformResponseIsUpToDate
https://bugs.webkit.org/show_bug.cgi?id=158424
Reviewed by Brady Eidson.
No change in behavior, just removing unused code that was introduced in r145007.
* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.
* platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::ResourceResponse::ResourceResponse):
* platform/network/curl/ResourceResponse.h:
(WebCore::ResourceResponse::cfURLResponse):
(WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.
* platform/network/soup/ResourceResponse.h:
(WebCore::ResourceResponse::soupMessageTLSErrors):
(WebCore::ResourceResponse::setSoupMessageTLSErrors):
(WebCore::ResourceResponse::decode):
(WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (201720 => 201721)
--- trunk/Source/WebCore/ChangeLog 2016-06-06 19:16:20 UTC (rev 201720)
+++ trunk/Source/WebCore/ChangeLog 2016-06-06 19:23:29 UTC (rev 201721)
@@ -1,3 +1,26 @@
+2016-06-06 Alex Christensen <[email protected]>
+
+ Remove unused ResourceResponse::platformResponseIsUpToDate
+ https://bugs.webkit.org/show_bug.cgi?id=158424
+
+ Reviewed by Brady Eidson.
+
+ No change in behavior, just removing unused code that was introduced in r145007.
+
+ * platform/network/cf/ResourceResponse.h:
+ (WebCore::ResourceResponse::ResourceResponse):
+ (WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.
+ * platform/network/cocoa/ResourceResponseCocoa.mm:
+ (WebCore::ResourceResponse::ResourceResponse):
+ * platform/network/curl/ResourceResponse.h:
+ (WebCore::ResourceResponse::cfURLResponse):
+ (WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.
+ * platform/network/soup/ResourceResponse.h:
+ (WebCore::ResourceResponse::soupMessageTLSErrors):
+ (WebCore::ResourceResponse::setSoupMessageTLSErrors):
+ (WebCore::ResourceResponse::decode):
+ (WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.
+
2016-06-05 Gavin & Ellie Barraclough <[email protected]>
Deprecate remaining uses of Lookup getStatic*, use HasStaticPropertyTable instead.
Modified: trunk/Source/WebCore/platform/network/cf/ResourceResponse.h (201720 => 201721)
--- trunk/Source/WebCore/platform/network/cf/ResourceResponse.h 2016-06-06 19:16:20 UTC (rev 201720)
+++ trunk/Source/WebCore/platform/network/cf/ResourceResponse.h 2016-06-06 19:23:29 UTC (rev 201721)
@@ -40,14 +40,12 @@
public:
ResourceResponse()
: m_initLevel(AllFields)
- , m_platformResponseIsUpToDate(true)
{
}
#if USE(CFNETWORK)
ResourceResponse(CFURLResponseRef cfResponse)
: m_initLevel(Uninitialized)
- , m_platformResponseIsUpToDate(true)
, m_cfResponse(cfResponse)
{
m_isNull = !cfResponse;
@@ -58,7 +56,6 @@
#else
ResourceResponse(NSURLResponse *nsResponse)
: m_initLevel(Uninitialized)
- , m_platformResponseIsUpToDate(true)
, m_nsResponse(nsResponse)
{
m_isNull = !nsResponse;
@@ -68,7 +65,6 @@
ResourceResponse(const URL& url, const String& mimeType, long long expectedLength, const String& textEncodingName)
: ResourceResponseBase(url, mimeType, expectedLength, textEncodingName)
, m_initLevel(AllFields)
- , m_platformResponseIsUpToDate(false)
{
}
@@ -91,8 +87,6 @@
WEBCORE_EXPORT NSURLResponse *nsURLResponse() const;
#endif
- bool platformResponseIsUpToDate() const { return m_platformResponseIsUpToDate; }
-
private:
friend class ResourceResponseBase;
@@ -109,7 +103,6 @@
static bool platformCompare(const ResourceResponse& a, const ResourceResponse& b);
unsigned m_initLevel : 3;
- bool m_platformResponseIsUpToDate : 1;
#if USE(CFNETWORK)
mutable RetainPtr<CFURLResponseRef> m_cfResponse;
Modified: trunk/Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm (201720 => 201721)
--- trunk/Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm 2016-06-06 19:16:20 UTC (rev 201720)
+++ trunk/Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm 2016-06-06 19:23:29 UTC (rev 201721)
@@ -127,7 +127,6 @@
ResourceResponse::ResourceResponse(NSURLResponse* nsResponse)
: m_initLevel(Uninitialized)
- , m_platformResponseIsUpToDate(true)
, m_cfResponse([nsResponse _CFURLResponse])
, m_nsResponse(nsResponse)
{
Modified: trunk/Source/WebCore/platform/network/curl/ResourceResponse.h (201720 => 201721)
--- trunk/Source/WebCore/platform/network/curl/ResourceResponse.h 2016-06-06 19:16:20 UTC (rev 201720)
+++ trunk/Source/WebCore/platform/network/curl/ResourceResponse.h 2016-06-06 19:23:29 UTC (rev 201721)
@@ -23,8 +23,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef ResourceResponse_h
-#define ResourceResponse_h
+#pragma once
#include "HTTPHeaderNames.h"
#include "HTTPParsers.h"
@@ -54,8 +53,6 @@
// Needed for compatibility.
CFURLResponseRef cfURLResponse() const { return 0; }
- bool platformResponseIsUpToDate() const { return false; }
-
private:
friend class ResourceResponseBase;
@@ -68,5 +65,3 @@
};
} // namespace WebCore
-
-#endif // ResourceResponse_h
Modified: trunk/Source/WebCore/platform/network/soup/ResourceResponse.h (201720 => 201721)
--- trunk/Source/WebCore/platform/network/soup/ResourceResponse.h 2016-06-06 19:16:20 UTC (rev 201720)
+++ trunk/Source/WebCore/platform/network/soup/ResourceResponse.h 2016-06-06 19:23:29 UTC (rev 201721)
@@ -23,8 +23,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef ResourceResponse_h
-#define ResourceResponse_h
+#pragma once
#include "ResourceResponseBase.h"
@@ -74,8 +73,6 @@
GTlsCertificateFlags soupMessageTLSErrors() const { return m_tlsErrors; }
void setSoupMessageTLSErrors(GTlsCertificateFlags tlsErrors) { m_tlsErrors = tlsErrors; }
- bool platformResponseIsUpToDate() const { return false; }
-
template<class Encoder> void encode(Encoder&) const;
template<class Decoder> static bool decode(Decoder&, ResourceResponse&);
@@ -110,5 +107,3 @@
}
} // namespace WebCore
-
-#endif // ResourceResponse_h
