Title: [201741] trunk/Source
- Revision
- 201741
- Author
- [email protected]
- Date
- 2016-06-06 22:54:11 -0700 (Mon, 06 Jun 2016)
Log Message
REGRESSION(r197595): 2% JSBench regression on iPhone 5.
<https://webkit.org/b/158459>
Unreviewed rollout.
* runtime/VM.cpp:
(JSC::VM::deleteAllRegExpCode): Deleted.
* runtime/VM.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (201740 => 201741)
--- trunk/Source/_javascript_Core/ChangeLog 2016-06-07 05:46:44 UTC (rev 201740)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-06-07 05:54:11 UTC (rev 201741)
@@ -1,3 +1,14 @@
+2016-06-06 Andreas Kling <[email protected]>
+
+ REGRESSION(r197595): 2% JSBench regression on iPhone 5.
+ <https://webkit.org/b/158459>
+
+ Unreviewed rollout.
+
+ * runtime/VM.cpp:
+ (JSC::VM::deleteAllRegExpCode): Deleted.
+ * runtime/VM.h:
+
2016-06-06 Michael Saboff <[email protected]>
octal and binary parsing is wrong for some programs
Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (201740 => 201741)
--- trunk/Source/_javascript_Core/runtime/VM.cpp 2016-06-07 05:46:44 UTC (rev 201740)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp 2016-06-07 05:54:11 UTC (rev 201741)
@@ -552,13 +552,6 @@
});
}
-void VM::deleteAllRegExpCode()
-{
- whenIdle([this]() {
- m_regExpCache->deleteAllCode();
- });
-}
-
void VM::deleteAllCode()
{
whenIdle([this]() {
Modified: trunk/Source/_javascript_Core/runtime/VM.h (201740 => 201741)
--- trunk/Source/_javascript_Core/runtime/VM.h 2016-06-07 05:46:44 UTC (rev 201740)
+++ trunk/Source/_javascript_Core/runtime/VM.h 2016-06-07 05:54:11 UTC (rev 201741)
@@ -576,7 +576,6 @@
JS_EXPORT_PRIVATE void deleteAllCode();
JS_EXPORT_PRIVATE void deleteAllLinkedCode();
- JS_EXPORT_PRIVATE void deleteAllRegExpCode();
WatchpointSet* ensureWatchpointSetForImpureProperty(const Identifier&);
void registerWatchpointForImpureProperty(const Identifier&, Watchpoint*);
Modified: trunk/Source/WebCore/bindings/js/GCController.cpp (201740 => 201741)
--- trunk/Source/WebCore/bindings/js/GCController.cpp 2016-06-07 05:46:44 UTC (rev 201740)
+++ trunk/Source/WebCore/bindings/js/GCController.cpp 2016-06-07 05:54:11 UTC (rev 201741)
@@ -128,10 +128,4 @@
JSDOMWindow::commonVM().deleteAllLinkedCode();
}
-void GCController::deleteAllRegExpCode()
-{
- JSLockHolder lock(JSDOMWindow::commonVM());
- JSDOMWindow::commonVM().deleteAllRegExpCode();
-}
-
} // namespace WebCore
Modified: trunk/Source/WebCore/bindings/js/GCController.h (201740 => 201741)
--- trunk/Source/WebCore/bindings/js/GCController.h 2016-06-07 05:46:44 UTC (rev 201740)
+++ trunk/Source/WebCore/bindings/js/GCController.h 2016-06-07 05:54:11 UTC (rev 201741)
@@ -47,7 +47,6 @@
WEBCORE_EXPORT void setJavaScriptGarbageCollectorTimerEnabled(bool);
WEBCORE_EXPORT void deleteAllCode();
WEBCORE_EXPORT void deleteAllLinkedCode();
- WEBCORE_EXPORT void deleteAllRegExpCode();
private:
GCController(); // Use singleton() instead.
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (201740 => 201741)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2016-06-07 05:46:44 UTC (rev 201740)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2016-06-07 05:54:11 UTC (rev 201741)
@@ -1790,9 +1790,6 @@
// For top-level navigations, have JSC throw away linked code. The immediate memory savings far
// outweigh the cost of recompiling in the case of a future backwards navigation.
GCController::singleton().deleteAllLinkedCode();
-
- // Same thing with RegExp bytecode and JIT code.
- GCController::singleton().deleteAllRegExpCode();
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
